Predict Forensics V2.0 #40693

Prole0 · 2025-10-04T07:20:51Z

About the PR

I merged the branch wrong, so a new one has been made. I really tempted fate with the last PR's name...

This is just #40440 without the massive amount of commits or the conflicts. Hopefully...

Below is the old PR's description.

~~Moving ForensicSystem, ForensicScannerSystem, & ForensicPadSystem to Shared. For now, its drafted due to misprediction issues I haven't found the solution for yet.~~

Its predicted, just needs a code cleanup is all.

Why / Balance

For #39286. Latency is annoying, minimizing it is an absolute benefit to the players.

Technical details

Moving and dirtying mostly. Some prediction changes to Content.Client/Forensics/ForensicScannerBoundUserInterface.cs to make the button press instant. And a blanket NetworkedComponent & AutoGenerateComponentState to most components. I don't think most of them would need them, I'll cleanup & and see what's needed when most of the major mispredictions and roadblocks ironed out.

I had to predict ForensicPadSystem due to it mispredicting if left on server. Still WIP due to issues with misprediction that I haven't found the solution for. Examples of the roadblocks in media. At least the ones I've found.

I've definitely missed something for this prediction stuff. Most likely something in components because I don't know components, or something in SharedForensicsSystem. If anyone spots an issue that could get rid of the roadblocks, LMK.

Media

Roadblocks

CLEARED

~~Misprediction with Soap Cleaning after another person cleaned it.~~

Cleared

MispredictSoapCleaningWhenFinishedCleaningSolved.mp4

~~Misprediction when new evidence is left by another player.~~

Cleared

ObjectsgettingnewinfomispredictsforotherpersonResolved.mp4

~~Misprediction with Soap Cleaning showing previous evidence to other players using the forensic scanner~~

Cleared

MispredictforotherplayerwhentheycleanevidenceSolved.mp4

Requirements

I have read and am following the Pull Request and Changelog Guidelines.
I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Moved All System & Components of Content.Server/Forensics to Content.Shared/Forensics for TLDR

ForensicsSystem merged into SharedForensicsSystem

ForensicScannerSystem moved to Shared

ForensicPadSystem moved to Shared

FingerMaskSystem moved to Shared

CleansForensicsComponent, DnaSubstanceTraceComponent, FiberComponent, ForensicPadComponent, ForensicScannerComponent, ForensicsComponent, IgnoresFingerprintsComponent, & ResidueComponent moved to Shared

Removed TransferDnaEvent in Events.cs & OnTransferDnaEvent in SharedForensicsSystem.cs.
TransferDna in SharedForensicsSystem is now used instead

Removed RandomizeDna & RandomizeFingerprint Virtual Methods in SharedForensicsSystem.cs.

Moved server-side BloodstreamSystem code to SharedBloodstreamSystem, empty in server for inheritance

Changed ForensicScannerSystem to SharedForensicScannerSystem & made it abstract

Made Client side ForensicScannerSystem for UI updates

Changelog

no cl

…sSystem (Also made it abstract) V2

…nstructor) V2

…re it out later)

Content.Shared/Forensics/Systems/SharedForensicsSystem.cs

Prole0 · 2025-10-04T07:26:51Z

Content.Client/Forensics/ForensicScannerMenu.xaml.cs

            }
            text.AppendLine();
            text.AppendLine(Loc.GetString("forensic-scanner-interface-dnas"));
-            foreach (var dna in msg.TouchDNAs)


See the comment on the BUI message.
Just send the uid and use a TryComp here to get these.

Right here

Prole0 · 2025-10-04T07:30:06Z

Content.Shared/Forensics/ForensicScannerEvent.cs

    [Serializable, NetSerializable]
    public sealed class ForensicScannerBoundUserInterfaceState : BoundUserInterfaceState
    {
        public readonly List<string> Fingerprints = new();


No need for the BUI message anymore. The scanner already has all the needed information autonetworked from its components. So you can just update the UI in an AfterAutoHandleState subscription. Look at this PR for an example #33835

👍

No BUI here so resolved, maybe.

slarticodefast · 2025-10-04T07:44:38Z

Please don't make a new PR every time, this makes it really hard to review. If you did something wrong you can always revert that commit.

github-actions · 2025-10-04T12:51:24Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

slarticodefast · 2025-10-04T18:24:46Z

Content.Server/Body/Systems/BloodstreamSystem.cs

        bloodSolution.AddReagent(new ReagentId(entity.Comp.BloodReagent, GetEntityBloodData(entity.Owner)), entity.Comp.BloodMaxVolume - bloodSolution.Volume);
    }

-    // forensics is not predicted yet


Simply removing the code comment does not address the networking issue I mentioned. This needs to be moved to shared and the changed DnaData needs to be dirtied to make sure it is networked to other clients.
So you will have to look into how reagent data is networked. And please test this with multiple clients and the VV window to make sure it works as intended.

I'm getting this error when I move server-side bloodstream to its shared counterpart.

[FATL] unhandled: Robust.Shared.IoC.Exceptions.UnregisteredDependencyException: Content.Shared.Medical.VomitSystem requested unregistered type with its field Content.Shared.Body.Systems.SharedBloodstreamSystem: _bloodstream

I got no clue about this, no errors that I see.

The only thing that VomitSystem uses is GetEntityBloodData, which the newly moved OnComponentInit & OnDnaGenerated also use.

Fixed the error, had to make SharedBloodstreamSystem sealed and delete client side BloodStreamSystem. Everything server side should be on shared & DnaData dirtied too. Visuals below for comparison.

On Master

Master.mp4

With Dirty

With.Dirty.mp4

Without Dirty

Without.Dirty.mp4

The error message is coming from here, idk what im missing here to get it to go away.

1) CLIENT: 0.773s [ERRO] system.blood_stream: Unable to set bloodstream DNA, solution entity could not be resolved Exception:

…eted client BloodStreamSystem.cs to make SharedBloodstreamSystem.cs sealed. (No Unregistered errors)

… but it doesnt crash)

Prole0 · 2025-10-10T23:06:00Z

Suffer.mp4

Yall got a clue about this? It was due to my last commit, I'm guessing the info isn't getting taken?

Prole0 · 2025-10-12T03:07:03Z

Content.Client/Forensics/Systems/ForensicScannerSystem.cs

+
+    private void OnScannerUpdate(Entity<ForensicScannerComponent> ent, ref AfterAutoHandleStateEvent args)
+    {
+        UpdateUi(ent);


It's not getting the info from UpdateState in Content.Client/Forensics/ForensicScannerMenu.xaml.cs, so a connection has to be linked.

Most likely Update() in Content.Client/Forensics/ForensicScannerBoundUserInterface.cs will make do. Just need examples of implementation, PR dig time.

github-actions · 2025-10-12T21:56:05Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

This reverts commit 5735012.

0x6273

You're auto networking way too many fields, which will make it trivial to cheat and also wastes network bandwidth. For example:

Being in PVS range of a scanner tells you everything it's scanned, even if you're not able to interact with the scanner. (like it being in someone else's hand or bag)
Being in PVS range of something with forensics data gives you the data without having to scan it.
Being in PVS range of someone with gloves tells you the fiber.

You need to make it so that data is only networked when it's needed, and only to the players that should have that data.

Prole0 · 2025-10-14T04:37:58Z

You're auto networking way too many fields, which will make it trivial to cheat and also wastes network bandwidth. For example:

Being in PVS range of a scanner tells you everything it's scanned, even if you're not able to interact with the scanner. (like it being in someone else's hand or bag)

Being in PVS range of something with forensics data gives you the data without having to scan it.

Being in PVS range of someone with gloves tells you the fiber.

You need to make it so that data is only networked when it's needed, and only to the players that should have that data.

Noted, do you know if ForensicScannerComponent AutoNetworks is part of this problem? The current way I'm trying to get the info for UI is through AfterAutoHandleState Subscription, which would need the comp parts to be AutoNetworked. Just WTK

github-actions · 2025-10-21T23:04:24Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Prole0 added 7 commits October 3, 2025 22:58

What sitting on code does to a branch + no mo owner v2

8b32741

Replacing ViewVariables with AutoNetworkedField + Missed One V2

4eced39

Removing Virtual Methods & Renaming ForensicsSystem to SharedForensic…

40df4aa

…sSystem (Also made it abstract) V2

IProduceWidgets Review Changes & some of my own V2

e848c89

Lil Cleanup V2

af89f96

Part 1 of Review Changes (Only thing left is the BUI stuff and the co…

6bc4ce4

…nstructor) V2

It now WORKS!!! (Still needs the BUI and constuctor changes, ill figu…

8cbfe61

…re it out later)

Prole0 requested review from DrSmugleaf, Princess-Cheeseballs, ficcialfaint and slarticodefast as code owners October 4, 2025 07:20

Prole0 commented Oct 4, 2025

View reviewed changes

Content.Shared/Forensics/Systems/SharedForensicsSystem.cs Outdated Show resolved Hide resolved

Prole0 commented Oct 4, 2025

View reviewed changes

github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Oct 4, 2025

Prole0 added 3 commits October 4, 2025 11:10

Test (Removal of ServerSide VomitSystem.cs)

a18f325

Merge branch 'space-wizards:master' into Predict-Forensics-2.0

64ac75f

Ok...

4f8a4f8

github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Oct 4, 2025

slarticodefast reviewed Oct 4, 2025

View reviewed changes

Prole0 added 2 commits October 5, 2025 18:39

Moved System BloodstreamSystem.cs to SharedBloodstreamSystem.cs & del…

5d7b876

…eted client BloodStreamSystem.cs to make SharedBloodstreamSystem.cs sealed. (No Unregistered errors)

Prediction

2392e97

Prole0 requested a review from crazybrain23 as a code owner October 7, 2025 00:27

Fix?

8134052

slarticodefast mentioned this pull request Oct 9, 2025

GetVerbsEvent subscriptions need to be moved to shared #39286

Open

41 tasks

No ForensicScannerBoundUserInterface.cs (It doesnt wanna scan anymore…

3a0b774

… but it doesnt crash)

Prole0 commented Oct 12, 2025

View reviewed changes

github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Oct 12, 2025

For Conflicts

b15cf95

Prole0 requested a review from sowelipililimute as a code owner October 12, 2025 22:06

Guh

af48f5a

github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Oct 12, 2025

Prole0 added 6 commits October 12, 2025 15:07

Merge branch 'space-wizards:master' into Predict-Forensics-2.0

7c6714d

Yea

a10bbb0

Organization & no ErrorHell (maybe)

5de2c5e

Dirtying

57a3ca0

Dirtying take 2

5735012

Revert "Dirtying take 2"

3354c91

This reverts commit 5735012.

0x6273 suggested changes Oct 13, 2025

View reviewed changes

Prole0 added 2 commits October 15, 2025 18:43

the dirties dont do much here

5e83d9a

Merge branch 'space-wizards:master' into Predict-Forensics-2.0

a6258a7

github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Oct 21, 2025

Prole0 added 2 commits October 21, 2025 21:54

For Conflict

33457d7

Merge branch 'space-wizards:master' into Predict-Forensics-2.0

60bb6e1

github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Oct 22, 2025

Readded

34d5875

Predict Forensics V2.0 #40693

Are you sure you want to change the base?

Predict Forensics V2.0 #40693

Conversation

Prole0 commented Oct 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

About the PR

Why / Balance

Technical details

Media

Roadblocks

CLEARED

Requirements

Breaking changes

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

slarticodefast commented Oct 4, 2025

Uh oh!

github-actions bot commented Oct 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

On Master

With Dirty

Without Dirty

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Prole0 commented Oct 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 12, 2025

Uh oh!

0x6273 left a comment

Choose a reason for hiding this comment

Uh oh!

Prole0 commented Oct 14, 2025

Uh oh!

github-actions bot commented Oct 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Prole0 commented Oct 4, 2025 •

edited

Loading