Skip to content

Hand labeler UI improvements #40318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Hand labeler UI improvements #40318

wants to merge 5 commits into from
+38 −3

Conversation

Absotively
Copy link
Contributor

About the PR

Changes to the hand labeler UI:

  • The LineEdit populated with current label text on open, but selected so the user can still just start typing to replace it
  • The window is now wide enough for long-ish labels
  • Added a Reset button that resets the LineEdit to the text it had when the window was open
  • Added a Clear button that clears the LineEdit

Why / Balance

I like being able to see all of the label text, and also being reassured that it didn't somehow disappear while I had the window closed.

The buttons probably aren't needed super frequently but I felt like they'd be nice to have occasionally.

Technical details

Updated the hand labeler window xaml to have the wider width and the new buttons. Added a function to set up the LineEdit and store the initial text after the window's _label is initially set. Added handling for the new buttons. Added a function to disable the new buttons when appropriate, and called it when the LineEdit contents have changed.

Media

image

Requirements

Changelog
🆑

  • tweak: Minor hand labeler UI improvements

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S Denotes a PR that changes 10-99 lines. Changes: UI Changes: Might require knowledge of UI design or code. labels Sep 13, 2025
@iaada iaada added P3: Standard Priority: Default priority for repository items. T: UI / UX Improvement Type: UI and player facing interactive graphical interfaces A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Sep 13, 2025
@opl- opl- mentioned this pull request Sep 13, 2025
Closed
2 tasks
@opl-
Copy link
Contributor

opl- commented Sep 13, 2025

Window content gets cut off when made smaller:
image

Check my closed PR for how I fixed that.

@Absotively
Copy link
Contributor Author

Added @opl-'s resizing fix.

image

@Absotively Absotively mentioned this pull request Sep 22, 2025
Open
2 tasks
PJB3005
PJB3005 requested changes Oct 21, 2025
View reviewed changes
Copy link
Member

@PJB3005 PJB3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor XAML nits

@PJBot PJBot added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Oct 21, 2025
@Absotively
Copy link
Contributor Author

Cleaned up the xaml.

@Absotively Absotively requested a review from PJB3005 October 22, 2025 00:25
@PJBot PJBot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PJB3005 PJB3005 Awaiting requested review from PJB3005

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: UI Changes: Might require knowledge of UI design or code. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S Denotes a PR that changes 10-99 lines. T: UI / UX Improvement Type: UI and player facing interactive graphical interfaces

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Absotively @opl- @PJB3005 @PJBot @iaada