Battlecry UI improvements

[Absotively]

About the PR

• Battlecry is now updated when the user edits it even if they don't press enter
• Battlecry length limit is now enforced in UI; you can't enter a too-long battlecry that will be clipped
• Battlecry window layout can no longer be broken by making the window narrower
• When the battlecry window is opened, it is populated with the current battlecry
• When the battlecry window is opened, the LineEdit grabs focus, and any existing battlecry is selected, so the user can immediately begin typing a new battlecry

Why / Balance

Prevent the battlecry being unchanged when it looks changed in the window. Allow the user to check the current battlecry without attacking something.

Technical details

Adjusted window xaml, added more dialog setup, modified change detection to use OnTextChanged instead of OnTextEntered.

Media

Before

New min width

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

• MeleeSpeechWindow::OnBattlecryEntered is now MeleeSpeechWindow::OnBattlecryChanged and fires more often.
• MeleeSpeechWindow::SetCurrentBattlecry will not update the displayed battlecry edit control if that control has the keyboard focus.

Changelog
🆑

• tweak: Battlecry changes don't require pressing enter, are visible on battlecry window reopen
• tweak: Can't enter too-long battlecry that then gets cut off

[Absotively]

I should mention that the changes here are similar enough to the hand labeler changes in #40318 that it might save time reviewing to look at both at once.