Skip to content

Conversation

@Quantum-cross
Copy link
Contributor

@Quantum-cross Quantum-cross commented Jul 25, 2025

About the PR

Atomizing #37350

Makes constructing and deconstructing turnstiles more like regular airlocks.

Adds more steps, materials, and uses door electronics in order to have user-configurable access using a multitool.

Adds higher security versions with a welded steel plate and/or electrified wires. The electrification comes from the wire node underneath it. (Note that currently you do not need insuls to bypass this, see #37625 )

Also clean up some of the animation code and split out different parts of the turnstile sprite in anticipation of future parts implementing more of #37350

Why / Balance

Turnstiles are way too easy to deconstruct, and once deconstructed, simple engineers cannot properly set the proper access requirements.

Technical details

Mostly YAML changes.

The rest is just splitting up the sprites and then cleaning up some of the animation code to control the individual sprite component animations.

Media

Place construction ghost

Screen.Recording.2025-07-25.164755.mp4

Add steel and rods

Screenshot 2025-07-25 164826

Anchor the assembly (Note that the arrows shows the direction)

Screen.Recording.2025-07-25.164900.mp4

Add LV cable

Screenshot 2025-07-25 164916

Need door electronics

Screenshot 2025-07-25 164946

Configuring door electronics

Screen.Recording.2025-07-25.165035.mp4

Finish with screwdriver

Screenshot 2025-07-25 165052

Done!

Screenshot 2025-07-25 165106

Wire panel

The wire panel is quite bare currently, but this will be filled out in future parts, implementing more of #37350

Screenshot 2025-07-25 165130

Electric grille upgrade

Screen.Recording.2025-07-25.165931.mp4

Requirements

Breaking changes

The currently mapped entities of id TurnstileGenpopLeave and TurnstileGenpopEnter should work as is.

For mappers: consider if you want easy turnstile wires panel electrification upgrades by providing powered wires under security turnstiles.

Changelog
🆑

  • tweak: Turnstiles are constructed/deconstructed more like airlocks
  • add: Turnstiles require Door Electronics and access can be configured as usual with a multitool
  • add: Turnstile wire panels can be upgraded with a steel plate and/or metal rods for electrified security grille. Electrification requires powered wires directly under turnstile.

- split the spinner and indicator lights into different sprite layers
- add an indicator on the left side and add bolted sprite
- add wire panel to turnstile, allow electrification, bolting, ai access
- add power reciever, turnstile will act as if bolted when unpowered
- turnstiles can log access as well and be door probed
…trified grille.

add TurnstileGenpop wire layout so it's different from constructed ones

add WiresPanelSecurity component for examines

add medium security turnstile with steel panel

add medium security shocked turnstile with steel panel and electric grille
@PJBot PJBot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Jul 25, 2025
@github-actions github-actions bot added the size/M Denotes a PR that changes 100-999 lines. label Jul 25, 2025
@github-actions
Copy link
Contributor

RSI Diff Bot; head commit e03af41 merging into 2be968c
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Doors/turnstile.rsi

State Old New Status
deny Modified
operate Modified
turnstile Modified
turnstile_map Modified
assembly Added
bolted Added
granted Added
panel_open Added
turnstile_idle Added
wired Added

@Quantum-cross
Copy link
Contributor Author

Fixes #37225, partially fixes #37227

@southbridge-fur southbridge-fur added P3: Standard Priority: Default priority for repository items. D2: Medium Difficulty: A good amount of codebase knowledge required. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it A: Engineering Area: Engineering department, including Atmospherics. A: Security Area: Security department, including Detectives, HoS and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jul 26, 2025
Copy link
Contributor

@southbridge-fur southbridge-fur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@PJBot PJBot added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Jul 26, 2025
@southbridge-fur
Copy link
Contributor

I'm not too sure how I feel about them being shocked with a wire underneath them, as most maps are likely to have idle wires under their turnstyles anyway. That being said if it doesn't affect regular usage then it should be fine. It just might need to be mentioned to mappers so they can ensure their turnstyles are all shocked or not.

@Quantum-cross
Copy link
Contributor Author

I'm not too sure how I feel about them being shocked with a wire underneath them, as most maps are likely to have idle wires under their turnstyles anyway. That being said if it doesn't affect regular usage then it should be fine. It just might need to be mentioned to mappers so they can ensure their turnstyles are all shocked or not.

The turnstiles itself doesn't become shock on touch. It's an electrified security grille to access the wires panel, and was a request from the other PR.

There currently is no entity prototype that starts in the high security variant, so if security wants their turnstiles upgraded, the wiring would have to be done by an engineer anyway.

@southbridge-fur
Copy link
Contributor

I'm not too sure how I feel about them being shocked with a wire underneath them, as most maps are likely to have idle wires under their turnstyles anyway. That being said if it doesn't affect regular usage then it should be fine. It just might need to be mentioned to mappers so they can ensure their turnstyles are all shocked or not.

The turnstiles itself doesn't become shock on touch. It's an electrified security grille to access the wires panel, and was a request from the other PR.

There currently is no entity prototype that starts in the high security variant, so if security wants their turnstiles upgraded, the wiring would have to be done by an engineer anyway.

Oh I didn't mean to change it, I was just saying how that feature should be advertised to map makers so they can add wires under their turnstyles if they want

@Quantum-cross
Copy link
Contributor Author

I'm not too sure how I feel about them being shocked with a wire underneath them, as most maps are likely to have idle wires under their turnstyles anyway. That being said if it doesn't affect regular usage then it should be fine. It just might need to be mentioned to mappers so they can ensure their turnstyles are all shocked or not.

The turnstiles itself doesn't become shock on touch. It's an electrified security grille to access the wires panel, and was a request from the other PR.
There currently is no entity prototype that starts in the high security variant, so if security wants their turnstiles upgraded, the wiring would have to be done by an engineer anyway.

Oh I didn't mean to change it, I was just saying how that feature should be advertised to map makers so they can add wires under their turnstyles if they want

I'll throw it in the changelog as well.

@Quantum-cross
Copy link
Contributor Author

Also check in #37350 I have a pretty full guidebook entry on turnstiles with all my upgrades. I'll include it when all parts are merged:

https://github.com/space-wizards/space-station-14/blob/5877ed4eb59fd1d4398351ab7ae798a6176bc04d/Resources/ServerInfo/Guidebook/Engineering/Turnstiles.xml

@iaada iaada added the S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. label Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: Engineering Area: Engineering department, including Atmospherics. A: Security Area: Security department, including Detectives, HoS Changes: Sprites Changes: Might require knowledge of spriting or visual design. D2: Medium Difficulty: A good amount of codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/M Denotes a PR that changes 100-999 lines. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants