Turnstile improvements -- Auth breaker & Emag -- Part 3 #39252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, not just a locstring. Take the random default BaseTime out of the GetPryTimeModifierEvent, this default was never used. BaseTime is set at construction of the event from PryableComponent instead of an event on PryableComponent. Use `Entity<T>` for OnDoorAltVerb, OnDoAfter Use `Resolve` on nullable component arguments in public functions. Use `Entity<T>` pattern in private functions Add some comments and change some variable names in `PryingSystem for clarity.`
fix high sec door not being pryable fix blast door being pryable
…s so that access can be configured.
- split the spinner and indicator lights into different sprite layers - add an indicator on the left side and add bolted sprite - add wire panel to turnstile, allow electrification, bolting, ai access - add power reciever, turnstile will act as if bolted when unpowered - turnstiles can log access as well and be door probed
…trified grille. add TurnstileGenpop wire layout so it's different from constructed ones add WiresPanelSecurity component for examines add medium security turnstile with steel panel add medium security shocked turnstile with steel panel and electric grille
…pen, pry closed, powered, unpowered, welded, unwelded, hand pry, crowbar, jaws of life.
Add ability to pry turnstiles while solenoid is bypassed
… but also doesn't flash the Access Granted lights on a chain pull, the turnstile just continues turning.
PJBot
added
S: Needs Review
|
RSI Diff Bot; head commit 39a926f merging into 45cef10 Resources/Textures/Structures/Doors/turnstile.rsi
|
|
Would it be out of scope to make it so an AI could temporarily apply the access breaker effect to a turnstile in place of EA'ing it, as currently the AI has no way to let players out of an area enclosed via turnstiles. |
Part 4 will be bolting, which I've already written but need to make an atomized PR. I plan on doing a Part 5 that includes Emergency access mode, which still needs to be decoupled from the Door system. |
Killerqu00
added
P2: Raised
github-actions
bot
added
the
S: Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
NOTE: THIS DEPENDS ON #39217 AND #37689 AND #39251
This is part 3 of my turnstile improvements.
This PR introduces the ability to break turnstiles with the Authentication Disruptor and EMAG.
The auth breaker will make the turnstile constantly spin, so there is a visible side effect of breaking a turnstile.
The Emag will covertly flip the direction of operation 180 degrees. The arrow shown on examination does not change.
Why / Balance
Auth breaker functionality should be included for parity. The turnstile has an access reader so the auth breaker should be able to break it.
The Emag functionality is funny, but if it falls afoul of the emag "content restriction", it can be disabled for now.
Technical details
In this PR there is a fair amount of refactoring of the animation code. Besides that, the auth/emag interactions are pretty simple
Media
Will upload later closer to prerequisite PRs being merged.
Requirements
Breaking changes
Only really stuff internal to the turnstile system.
Changelog
🆑