Food Item Size Adjustment

[5tickman]

Why is a pat of butter bigger then a whole tray of brownies?

About the PR

I went through all of the food/chef items, and tweaked their size and sprite offsets.

Why / Balance

I play a lot of chef and have noticed some common issues with many of their items:

Items are too big or too small.

Many items inherit the default 1x2 size, regardless if it makes sense. Items that can be sliced (butter, raw meat) turn into many items that are the same size. Very big meals with lots of ingredients and reagents are the same size as a normal sandwich.

Sprites spilling over the edge of their item frame.

This sort of ties in with the previous point. Many items have larger or some times fantastical sprites, but still have the boring old 1x2 size. Many sprites are just too big for their item frame, or need to have there item frame rotated to fit the sprite.

Sprites are off center in their item frames.

Not much to say. Egg cartons, Pizzas, and pizza boxes are some of the worst offenders.

Items by default get placed sideways in inventories.

Not the end of the world, but its odd to have so many things rotated 90 degrees from how they appear in the world. Soups, and plates of food look especially strange shoved sideways.

Here are some of the new items sizes. Some are bigger now, some are smaller. This is not an exhaustive list, but should cover the biggest changes:

• Bread loafs and wads of dough are now 2x2 in size.
• Slices of dough are now 1x1 in size.
• Rolled out Pizza dough is now 3x2 in size. (Same size as a pizza)
• Baguettes are now 1x4 in size.
• Croissants are now 2x2 with a chunk missing. (Handgun shaped)
• Bagels are now 1x1 in size. (Dough ropes are still 1x2)
• Slabs of meat are 2x1 in size.
• Donut box, egg carton, and donk pocket box are all now 3x2 in size. (Same as a pizza box. All of these have whitelisted storage, so no power creep here)
• Starting box of cotton is now 2x2 in size. (It only stores 2x2 anyway)
• Butter pat, and cheese wedge are 1x1 in size.

Update:
Because of the new size of baguettes, mimes will now start with a Nutribrick instead. The "combat bakery kit" has to be a 4x4 to accommodate the new baguette size.

Technical details

I got rid of the -90 stored rotation offsets. Some custom item shapes were use to accommodate this.

Just about every food item was spawned in and given a custom storage offset, if needed.

I did a small rename of the plastic plates found in the condiment vender. Both the smaller plate and larger plate were both named "plastic plate". I renamed them to "large plastic plate" and "small plastic plate" to match the naming convention of their ceramic counter parts.

Media

All items have been placed with there default rotation.

Before:

After:

Before:

After:

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

None, yml changes only.

Changelog

🆑

• tweak: Food and ingredient item sizes have been adjusted.
• tweak: Mimes now start with a Nutribrick instead of a Baguette.
• tweak: The combat bakery kit is now a 4x4 sized box.

[5tickman]

Oops, that long baguette is causing some issues...

[AgentSmithRadio]

Grilled cheese guy here, I definitely screwed up by making them 1x1, they should be 1x2 like you have here.

I like this, good changes and cleanup.

[themias]

Oops, that long baguette is causing some issues...

Yes, they can't fit in the survival kit anymore (for mimes).

I think it's OK to remove them from there. This PR is a good balance change, and mimes can ask pantomime to the chef to make one easily. I originally added it to the mime survival kit to make the weapon version harder to meta, but the rules around the metashield changed on wizden (and everyone is aware of the weapon version), so this may no longer be needed.

[5tickman]

Mimes will now have a Nutribrick in there starting box instead of a baguette. Also the "combat bakery kit" is a 4x4 box with 4x4 internal storage to fit the baguette. The PR has been updated to reflect this.

[5tickman]

I think a tray of brownies would be about the size of a loaf of bread, plus they already can be cut like pizza. I think the important thing is that a whole tray of brownies is not a 1x1 any more.

[qrwas]

baguette 1 by 3? and put it vertically?

[5tickman]

baguette 1 by 3? and put it vertically?

I don't think that would help. The survival boxes only have a 1x2 space for their food item, and the combat bakery kit is jammed full from how the croissants are handgun shaped now. It would be nice if baguettes would stay 1x4 to match the area of the now 2x2 bread loafs.

[5tickman]

oops, clicking random buttons on github. sorry about that.

[Princess-Cheeseballs]

oops, clicking random buttons on github. sorry about that.

No worries. When you're done making changes feel free to hit the request review button. It lets me know you're ready for me to review it so I don't forget.

I noticed one thing and the rest looks good.

[Princess-Cheeseballs]

Test fail real. Seems you need to update either the HappyHonk fill table or adjust the container size of the HappyHonk.

[5tickman]

Test fail real. Seems you need to update either the HappyHonk fill table or adjust the container size of the HappyHonk.

I'm confused by that test fail because I couldn't recreate it running the test locally. I'm guessing because the crazy burger is bigger now, there was no space for it. I removed it from that fill list, and it looks like its working now.

[Princess-Cheeseballs]

Test fail real. Seems you need to update either the HappyHonk fill table or adjust the container size of the HappyHonk.

I'm confused by that test fail because I couldn't recreate it running the test locally. I'm guessing because the crazy burger is bigger now, there was no space for it. I removed it from that fill list, and it looks like its working now.

Yeah that's the exact issue, should also remove any other food item that's too big. That test specifically will fail randomly because the contain fills are well... random.

[Princess-Cheeseballs]

Looks good. I think the crazy hamburger being removed from happy honks is only a minor loss considering people were gambling for the toys.

[iaada]

P1 due to #40046

[SlamBamActionman]

There's some minor issue with bowls where they still use the crunch sound instead of drinking, but the prototype itself seems set up correctly. Should be fixed but I see no point in delaying the PR for such a minor error.

Thank you for your contribution.

[lzk228]

looks like a copy paste issue, gonna fix that soon