Skip to content

FoodComponent and DrinkComponent need to be completely removed as soon as possible #40046

@slarticodefast

Description

@slarticodefast

Description

FoodComponent and DrinkComponent were unified into EdibleComponent in
#39031
The problem is that right now not all prototypes have been ported over, and some of them have both the Food/DrinkComponent and the EdibleComponent.
Since the three systems are basically all copy pasted from each other this means many event subscription are running multiple times. Some of them are handled events, which means it will randomly pick one of the systems where the subscription runs.
Also a lot of systems still have hardcoded checks for FoodComponent, DrinkComponent, meaning they won't work for prototypes that were ported. And if we port the system over, then it won't work for unported prototypes.
See for example #39773
So there will always be broken cases until we fully port over everything.

Metadata

Metadata

Labels

A: General InteractionsArea: General in-game interactions that don't relate to another area.A: ServiceArea: Service department, including cooking, botany, etcP1: HighPriority: Higher priority than other items, but isn't an emergency.T: BugfixType: Bugs and/or bugfixesT: CleanupType: Code clean-up, without being a full refactor or feature

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions