Skip to content

Reduce storage implant to a 2x L shape/6 slots #36272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2025
Merged

Reduce storage implant to a 2x L shape/6 slots #36272

merged 1 commit into from
Apr 5, 2025

Conversation

@SlamBamActionman
Copy link
Member

@SlamBamActionman SlamBamActionman commented Apr 3, 2025

About the PR

This PR changes the storage implant's inventory size to be compromised by two L-shaped areas, totaling 6 slots.

Why / Balance

The storage implant is the most-purchased traitor item in the game, and was shadowbuffed with the grid inventory update to be able to contain a lot more than original. More information here: #36145

The choice to make it 2 Ls was to reduce the number of slots to 2~ items while still allowing small guns to fit in the implant.

Technical details

Just yaml.

Media

image
image

Requirements

Breaking changes

Changelog

🆑

  • tweak: The storage implant's storage has been changed to a new pattern with 6 grid slots.

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. size/XS Denotes a PR that changes 0-9 lines. labels Apr 3, 2025
@Djungelskog2
Copy link

Djungelskog2 commented Apr 3, 2025

Let's see how this one goes

@kosticia
Copy link
Contributor

kosticia commented Apr 3, 2025

No test merge?

@lexaSvarshik
Copy link

lexaSvarshik commented Apr 3, 2025

How then poor stealth traitors should hide something like magboots or QM's tablet?

@deltanedas
Copy link
Contributor

deltanedas commented Apr 3, 2025

in a toilet git gud

@SlamBamActionman
Copy link
Member Author

SlamBamActionman commented Apr 3, 2025

Worth posting the result of the maintainer discussion from #36145 here as well:

Heyo! After a discussion within the maintainer team we've reached the following conclusion:

The storage implant should be nerfed, but there was no consensus on what functionality would have the most impact. Since the implant was shadowbuffed when gridinventory was introduced by increasing the storage size, the choice was made to split this PR up in two parts and monitor the effects of merging a storage size reduction first. We'll return in about a month's time and reevaluate the change, and if necessary look at some sort of blacklist or similar solution for objective items.

As per the author's request, this PR will remain as the blacklist PR, and a new PR will be opened targetting storage size. Maintainers decided upon 2x L-shape = L⅂ = 6 slots which had unanimous approval.

@SlimmSlamm

This comment was marked as off-topic.

Sign in to view
@keronshb
Copy link
Member

keronshb commented Apr 3, 2025 •
edited
Loading

Again I'll state here:

The current storage the storage implant has was never intended. It was accidentally shadowbuffed when Gridinv was made but it went way under the radar until now.

Accidental buffs and nerfs are suppose to be basically reverted instantly on discovery.

So this PR is putting it to what it should be.

@IWearKhakis
Copy link

IWearKhakis commented Apr 3, 2025

After the syndicate backpack buff I'm a fan of more cursed grid inv layouts

@FairlySadPanda
Copy link
Contributor

FairlySadPanda commented Apr 3, 2025

tragically missed opportunity
New Project(2)

@ScarKy0
Copy link
Contributor

ScarKy0 commented Apr 3, 2025

How then poor stealth traitors should hide something like magboots or QM's tablet?

Pay 2 TC for a smuggler's satchel. Or just get one out of a clothesmat. They are pretty handy

@HelpTheSteak
Copy link

HelpTheSteak commented Apr 3, 2025

Slimes now technically have a better storage implant real shit

@TeenSarlacc
Copy link
Contributor

TeenSarlacc commented Apr 3, 2025

I like this but I propose both L's be in the same orientation for maximum cursedness

@TeenSarlacc
Copy link
Contributor

TeenSarlacc commented Apr 3, 2025

The current storage the storage implant has was never intended. It was accidentally shadowbuffed when Gridinv was made but it went way under the radar until now.

100% out of curiosity, since I didn't start playing till after the gridinv was introduced, what was the original capacity of the storage implant?

@ScarKy0
Copy link
Contributor

ScarKy0 commented Apr 3, 2025

100% out of curiosity, since I didn't start playing till after the gridinv was introduced, what was the original capacity of the storage implant?

2 <=Small items

@K-Dynamic
Copy link
Contributor

K-Dynamic commented Apr 3, 2025

Slimes now technically have a better storage implant real shit

Difference being you can easily inspect slime internal storage

@ilovehans10
Copy link
Contributor

ilovehans10 commented Apr 3, 2025

Slimes now technically have a better storage implant real shit

Difference being you can easily inspect slime internal storage

And opening slime storage is technically more unergonomic and slower (which can matter quite a lot when trying to quickly hide items). Just saying, opening storage implant can be done with one key press whereas you have to move your mouse to the player + click and then move it to a button + click, which while it doesn't sound like much, but does make it the slowest inventory to open in the game.

@PicklOH
Copy link
Contributor

PicklOH commented Apr 3, 2025

Also intended to still be full TC price?

@BramvanZijp BramvanZijp added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities P3: Standard Priority: Default priority for repository items. and removed P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Apr 3, 2025
@Djungelskog2
Copy link

Djungelskog2 commented Apr 3, 2025

Also intended to still be full TC price?

Yea

@SlimmSlamm

This comment was marked as abuse.

Sign in to view
@Quantum-cross
Copy link
Contributor

Quantum-cross commented Apr 4, 2025

this is basically exactly how I imagined my fix to me, I love it.

@Princess-Cheeseballs
Copy link
Member

Princess-Cheeseballs commented Apr 4, 2025

Evil PR, I love it.

beck-thompson
beck-thompson approved these changes Apr 5, 2025
View reviewed changes
Copy link
Member

@beck-thompson beck-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested works in game!

@beck-thompson beck-thompson added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Apr 5, 2025
@SlamBamActionman SlamBamActionman merged commit cb03ea3 into space-wizards:master Apr 5, 2025
14 checks passed
@ScarKy0
Copy link
Contributor

ScarKy0 commented Apr 5, 2025

Based. We can start monitoring stats after next stable release it seems.

@cfif126

This comment has been minimized.

Sign in to view
@SpeltIncorrectyl SpeltIncorrectyl mentioned this pull request Apr 7, 2025
Closed
Happyrobot33 referenced this pull request in Happyrobot33/space-station-14 Apr 24, 2025
@Happyrobot33
Revert "Reduce storage implant to a 2x L shape/6 slots (#36272)"
c0ad662 
This reverts commit cb03ea3.
ss14-Starlight referenced this pull request in ss14Starlight/space-station-14 Apr 24, 2025
@ss14-Starlight
Merge pull request #526 from Happyrobot33/revert-implanter-change
846cd2e 
Revert "Reduce storage implant to a 2x L shape/6 slots (#36272)"
Princess-Cheeseballs pushed a commit to Princess-Cheeseballs/space-station-14 that referenced this pull request Apr 29, 2025
@SlamBamActionman @Princess-Cheeseballs
Reduce storage implant to a 2x L shape/6 slots (space-wizards#36272)
04e42e0 
Change subdermal implant
@Zap527 Zap527 mentioned this pull request May 25, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beck-thompson beck-thompson beck-thompson approved these changes

Assignees

No one assigned

Labels

A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/XS Denotes a PR that changes 0-9 lines. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.