Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Stationary Contraband Detector #378

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Mixelz
Copy link

@Mixelz Mixelz commented Jan 10, 2025

A very simple in concept machine that should be a breath of fresh air for contraband as a mechanic in addition to creating the potential for more roleplay opportunities.

Link to the initial Discord Conversation that spurred this PR into action!

@IWearKhakis
Copy link

IWearKhakis commented Jan 11, 2025

Really good proposal, I don't think there should be much pushback to have something like this roll out for being ONLY on evac shuttles at first- regardless of if this doc doesn't get fully implemented, I think reducing the frequency of shuttle bombing is worth the ludo-narrative dissonance of Nanotrasen having no reason to not have contraband detectors in their stations.

As for when implementation on stations is considered, this would of course really help with the implant check metagaming issue as well seeing as how popular storage implants are, though it feels like discussion around that has barely got anywhere, as some PRs to help fix that are still stuck in review purgatory (see #32136)

Though speaking of, detectors giving false-positives WOULD pair really well with #32136, it would give some risk and make secoffs think more carefully about checking for storage implants on everyone that trips a detector

(almost full edit because I wanted to make some of my thoughts more clear)

@beck-thompson
Copy link

I think this is a good solution to the shuttle bombing issue. Feels much better than just making explorations not work or something!

@BramvanZijp
Copy link

What if the handheld one is a HoS steal objective item?

@PotentiallyTom
Copy link

Having false positives wouldn't add anything, it just means anyone being flagged would be forced to walk through again. Having a plan involving no contraband, but but with clear bad-guy items be foiled by a radom false positive would be lame.

@EthanQix
Copy link

I have a few suggestions about the design/balance of this device.

  • The SCD should be located in the Security department. Its mechanics can be used beyond a mere evac checkpoint, and Security is where you'd want to be to conduct a thorough search during the shift.
  • There should only be one SCD on the station. This would induce a cost for a secoff wanting to conduct a more than just a random search, namely the time to bring the searchee to Security for the thorough check. That would also give the searchee a chance to book it if they do have sus shit on them, at the cost of their cover being blown.
  • According to the previous point, I don't think there should be a portable version of the SCD. HoS would be all too happy to randomly check crew in the corridors.
  • The SCD should be unanchorable so sec can setup a proper checkpoint at evac when the time comes, or anywhere they deem necessary at the time.
  • There should be no way of building extra SCDs. Otherwise sec will be all too happy to put the whole station into 1984-style lockdown with a detector in every corridor. This would also make the SCD a valuable, if risky, target to destroy for traitors.
  • Speaking of which, the SCD or the SCD board should be a high risk theif/traitor objective.
  • Emagging the SCD should cause it to give random results. Much messier to deal with than a few false positives/negatives, as the machine would have to be deconstructed and rebuilt (especially bad with time constraints at an evac checkpoint).
  • And last but not least, I'm not sure the SCD should detect anything beyond Syndicate items? Department-restricted items themselves are technically not illegal, and the machine would have to be smart enough (read: more coding required) to check against the searchee's ID. On the other hand, it would be funny to see the captain trigger all the beeps because someone stole their ID...

@Aisu9
Copy link

Aisu9 commented Jan 11, 2025

this will not do anything regarding shuttle bombing, because shuttle bombing is in essence using uplink aboard shuttle, spawn explosive and trigger them. unless there is a plan to make uplink unuseable when shuttle reached the station.

you should also consider that this was introduced on TG, and everyone hates it. ain't talking about the handheld version that was even more hated. volume should ALSO not deafen people just to be sure. had enough of the contraband scanner gate SCREAMING in my ears because there is no options nor the volume itself was tuned down.

@Killerqu00
Copy link

this will not do anything regarding shuttle bombing, because shuttle bombing is in essence using uplink aboard shuttle, spawn explosive and trigger them. unless there is a plan to make uplink unuseable when shuttle reached the station.

you should also consider that this was introduced on TG, and everyone hates it. ain't talking about the handheld version that was even more hated. volume should ALSO not deafen people just to be sure. had enough of the contraband scanner gate SCREAMING in my ears because there is no options nor the volume itself was tuned down.

that is the plan (to lock uplinks)

@Mixelz
Copy link
Author

Mixelz commented Jan 11, 2025

Having false positives wouldn't add anything, it just means anyone being flagged would be forced to walk through again. Having a plan involving no contraband, but but with clear bad-guy items be foiled by a radom false positive would be lame.

It keeps the device from being able to be power gamed by introducing a factor of unreliability, one at the expense of security of needing to check someone that does not have anything and then purge their own record of the false accusation.

There is the possibility of it being a false negative instead, but I feel the onus should be on the antag to work with a bad dice roll rather than the station as a whole for one false negative allowing the shuttle bomber to slip in undetected.

Copy link

@Killerqu00 Killerqu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi i work on this thing

@PotentiallyTom
Copy link

It keeps the device from being able to be power gamed by introducing a factor of unreliability, one at the expense of security of needing to check someone that does not have anything and then purge their own record of the false accusation.

If this were implemented, then anyone knowingly carrying contraband has very little reason walk through it. So you end up with the majority of alarms being false positives. The majority of these would be solved instantly by asking whoever it was to walk through again, and the rest would just turn into :s ward remove x from wanted please. If the majority of alarms are false positives then people stop caring when it goes off, and we're back to square 1.

Additionally, it can be used as a method to more reliably indicate the presence of a Storage Implant (I.E. Someone consistently setting one off despite having an empty inventory.), which has been a point of contention as Meta Knowledge due to the limited avenues of knowing when one is in play.

Adding any false positives completely blocks this as an option. Metashield on implants is broken when "experiencing a situation where absolutely no other explanation is possible". It's possible that the contraband scanner just keeps reading false positive.

@Killerqu00
Copy link

If this were implemented, then anyone knowingly carrying contraband has very little reason walk through it. So you end up with the majority of alarms being false positives. The majority of these would be solved instantly by asking whoever it was to walk through again, and the rest would just turn into :s ward remove x from wanted please. If the majority of alarms are false positives then people stop caring when it goes off, and we're back to square 1.

That assumes that the scanner is somewhere in a public spot. It is supposed to be either on the evac shuttle or in security for checking incoming prisoners. In the first case, you mostly don't have access to crimerecords - you just have the wanted list and search those marked by a scanner. In the second case, it just acts as QoL for the process of taking a prisoner in.

Adding any false positives completely blocks this as an option. Metashield on implants is broken when "experiencing a situation where absolutely no other explanation is possible". It's possible that the contraband scanner just keeps reading false positive.

In that case, you can also rule out that due to bluespace existing, the item could have bluespaced somewhere out of the person's hands. Besides, there is a PR that makes implant checking an actually good mechanic with risk to security - I think that should be mentioned in the doc.

@EthanQix
Copy link

If this were implemented, then anyone knowingly carrying contraband has very little reason walk through it.

People wouldn't just "walk through it", it would be used by sec for a thorough search / checkpoint.

@Pronana
Copy link

Pronana commented Jan 11, 2025

Though speaking of, detectors giving false-positives WOULD pair really well with #32136, it would give some risk and make secoffs think more carefully about checking for storage implants on everyone that trips a detector

They will already give enough non-antag positives when salvage and tiders walk through evac. I don't think we should add a random chance for them to have security search someone who doesn't have contraband, even worse if they then try to storage implant check them if that PR gets merged.

@PotentiallyTom
Copy link

PotentiallyTom commented Jan 11, 2025

That assumes that the scanner is somewhere in a public spot. It is supposed to be either on the evac shuttle or in security for checking incoming prisoners. In the first case, you mostly don't have access to crimerecords - you just have the wanted list and search those marked by a scanner. In the second case, it just acts as QoL for the process of taking a prisoner in.

No matter what, you're going to completely search anyone being brought into sec because they might have the tools to break out, so the only thing having a scanner in sec does is check storage implants, what does having false positives do for that except encourage implant checking when they don't exist?

People wouldn't just "walk through it", it would be used by sec for a thorough search / checkpoint.

Let's say I'm a syndie and I know sec are going to be checking people on evac. I'm not going to walk through the scanner with contraband on me. Whether that means I dump my contra before getting on the shuttle or find a way to avoid getting scanned doesn't matter. The scanner has done its job of stopping me from bringing a bomb onto evac. If I do get flagged, it's going to be a false positive because I have nothing on me. Everyone that gets flagged is going to be a false positive or a new player. These false positives are gonna be sorted out in 5 seconds by asking the person to be scanned again. All the false positive does is add 5 seconds to processing anyone and give innocent people random marks for the evac ride. You don't want people to stop trusting the scanner because then you get people ignoring it.

@PotentiallyTom
Copy link

Unrelated to false positives but having it detect major and minor contraband makes it almost impossible to complete any steal objectives and escape. You would basically be forced to try to steal it on the shuttle, which is the opposite of what this PR is trying to do. It would probably need to be syndie contra only or have a blacklist for steal objectives.

@Killerqu00
Copy link

Unrelated to false positives but having it detect major and minor contraband makes it almost impossible to complete any steal objectives and escape. You would basically be forced to try to steal it on the shuttle, which is the opposite of what this PR is trying to do. It would probably need to be syndie contra only or have a blacklist for steal objectives.

There are many ways to bypass the scanner, such as:

  • Board the shuttle not via main entrances
  • Use any sort of technique to hide items (plushies or implants, no one is checking you for implants at the evac). You will be tagged, but it will be most likely deemed as a false positive
  • Use a stolen ID/EMAG to disable the scanner manually

@PotentiallyTom
Copy link

There are many ways to bypass the scanner

Board the shuttle not via main entrances

Then it's going to do very little to stop shuttle bombing, which is the first goal of the proposal. If it's going to be possible for ~3 syndies to bypass it every round for a steal objective, then it's going to be possible for 1 of them to also shuttle bomb.

Use any sort of technique to hide items (plushies or implants, no one is checking you for implants at the evac). You will be tagged, but it will be most likely deemed as a false positive.

"Ok you've been flagged as positive 3 times, we're going to be keeping you in cuffs until evac arrives at cc"

Use a stolen ID/EMAG to disable the scanner manually

The only time that would work is if it checked for IDs in your inventory as well as the main ID you're wearing, which seems pretty arbitrary, otherwise sec would just instantly get you as soon as you changed ID.

@Mixelz
Copy link
Author

Mixelz commented Jan 11, 2025

Love this thorough idea bucket for the machine! Thank you for taking the time to type all this out, I'll try to go through each piece here and then summarize my thoughts as a whole.

  • The SCD should be located in the Security department. Its mechanics can be used beyond a mere evac checkpoint, and Security is where you'd want to be to conduct a thorough search during the shift.
  • There should only be one SCD on the station. This would induce a cost for a secoff wanting to conduct a more than just a random search, namely the time to bring the searchee to Security for the thorough check. That would also give the searchee a chance to book it if they do have sus shit on them, at the cost of their cover being blown.

I believe using the SCD already comes with a significant operating cost, that being needing to plant an officer by the machine in order to actually manually search and detain any suspects. The machine itself cannot tell us what item set it off, only that something DID set it off. It is on the responsibility of the accompanying officer to follow through on that flagged result to actually find the source of the problem. Limiting it to one machine in sec would most likely ensure the machine is only used as a once over for confirming storage implants, which is not a design intention of the machine.

  • According to the previous point, I don't think there should be a portable version of the SCD. HoS would be all too happy to randomly check crew in the corridors.

I agree that random HoS maints checks would bad and should be discouraged. Perhaps the portable version could be more likely to give a bad result or have a long Do After, but that version will need it's own PR and balance discussion separately from this one.

  • The SCD should be unanchorable so sec can setup a proper checkpoint at evac when the time comes, or anywhere they deem necessary at the time.
  • There should be no way of building extra SCDs. Otherwise sec will be all too happy to put the whole station into 1984-style lockdown with a detector in every corridor. This would also make the SCD a valuable, if risky, target to destroy for traitors.

I very much like the idea of Sec needing to set up checkpoints for the device ahead of time, it should not be something that can be slapped down and forgotten about. Given the high value of this machine I would struggle to think of a scenario of destruction that wouldn't just end up as throwing a c4 bundle ontop a group of sec offs and running away. If instead we devalue the machine it would be much more likely to be left alone, and then therefore sabotaged through means that aren't just blowing it up.

  • Speaking of which, the SCD or the SCD board should be a high risk theif/traitor objective.

Very fun idea! I think this would work well on the portable version, though I also worry about having too many steal objs for Sec equipment.

  • Emagging the SCD should cause it to give random results. Much messier to deal with than a few false positives/negatives, as the machine would have to be deconstructed and rebuilt (especially bad with time constraints at an evac checkpoint).

This would be much harder to notice than always giving a positive result. I think that determining if the device is Emagged shouldn't be a guessing game and should instead be something obvious that will require time and effort to undo, much like emagging a door and needing to take the time to unbolt it and reset it's permissions.

  • And last but not least, I'm not sure the SCD should detect anything beyond Syndicate items? Department-restricted items themselves are technically not illegal, and the machine would have to be smart enough (read: more coding required) to check against the searchee's ID. On the other hand, it would be funny to see the captain trigger all the beeps because someone stole their ID...

The idea of it scanning everything by default was to ensure that it had value outside of Syndicate rounds, such as Revolutionaries, Particularly Ornery Tiders or Theifs needing to sneak past with their objective in tow. If it ends up being too restrictive for traitors it can be reigned into something such as only including Command Items or only High Tier contraband.

In addition, Tying it to IDs is a method to ensure that you cannot effectively "hide in a crowd", assuming an evac scenario where you have a servers worth of people all come through at once. That being said, I am all on board for having the cap get flagged by security due to ID shenanigans because adding potential misinformation chaos should be a valid method of getting past it as a traitor.

Based on the overall discussion, we'll probably want to keep the device as something that only exists outside of Security at a designated/manned checkpoint and emphasize that it should be tremendously difficult to produce additional ones, if we allow them to be craftable at all.

@Mixelz
Copy link
Author

Mixelz commented Jan 11, 2025

Though speaking of, detectors giving false-positives WOULD pair really well with #32136, it would give some risk and make secoffs think more carefully about checking for storage implants on everyone that trips a detector

They will already give enough non-antag positives when salvage and tiders walk through evac. I don't think we should add a random chance for them to have security search someone who doesn't have contraband, even worse if they then try to storage implant check them if that PR gets merged.

The alternative would be having this thing be a 100% confirmation of the presense of contraband itself or of a storage implant, which I think would solidly push the item as being too powerful.
I think that allowing a chance for security to be wrong is the better resolution here, though through a false positive or false negative is still undecided.

@Mixelz
Copy link
Author

Mixelz commented Jan 11, 2025

If this were implemented, then anyone knowingly carrying contraband has very little reason walk through it. So you end up with the majority of alarms being false positives. The majority of these would be solved instantly by asking whoever it was to walk through again, and the rest would just turn into :s ward remove x from wanted please. If the majority of alarms are false positives then people stop caring when it goes off, and we're back to square 1.

That is why it should be a low chance for a false result as suggested. I would agree with this point if it was going to be guaranteed effect but the specific amount for this to feel fair will need to be tested and itterated upon to figure out a healthy balance. Figuring out that balanced value is something that is outside the scope of any design document, only the general idea of it being a "low" chance is required as a baseline.

@ilovehans10
Copy link

One thing that would make it harder to move would be making it a multiblock with three separate parts that all need to be anchored. The different parts could be something like control computer, scanner, and power modulator. It could also require one of it's pieces to be on top of MV or HV wire directly, so that you need a t-ray scanner or crowbar to get placement correct. Granted none of these would fully stop sec from moving it, but if only one sec officer is moving it a long distance it would provide a tider with a fair bit of time to walk over and hack one of the pieces not yet moved.

I really like false positives, even though they do raise some interesting implementation questions. One idea to weaken the "just walk back through" meta would be to have the scanner keep a list of recent false positives it's done, and if one of those players walks through again, they have a high chance of getting another false positive. This would mean that sometimes walking back through would work, but other times it would just set off the scanner again and make sec redouble their efforts. This list could then have items removed from it after a set period of time so players aren't cursed with false positives for all time.

Another idea would be to have certain items be targets of "scanner miscalibration". This miscalibration would be applied round start, and would choose a random item from a list of rareish items to always flag. For example, if mousetraps are selected at round start as the miscalibration item, then if anyone gets scanned with a mousetrap in their inventory they will scan as positive the same as if they had contraband. Some other example items could be things like bar shakers, jaws of life, kitchen knife, or any other item that close to only 1% of players will have on them. The idea in this paragraph is definitely half-baked, but I just wanted it out in the world for feedback/ideas.

I think an interesting way to do counterplay with this would be to have the radio jammer interfere with this in some way, but I am unsure whether it would be best to have the jammer block the scanner, or make it give a false positive at range. I feel like if the jammer is used to block the scanner it would have to only work for a couple of seconds, after which the machine goes into some sort of error mode and notifies its operator that it is being jammed. The idea in this paragraph is definitely half-baked, but I just wanted it out in the world for feedback/ideas.

Overall, I love this idea, and wish the best of luck on getting it approved and then implemented.

@lorahart2
Copy link

What if it spurts out a picture of their character like used their id picture of them in Grays with a single outline of the most dangerous item on them either a gun or a bomb

@0x6273
Copy link
Contributor

0x6273 commented Jan 14, 2025

I think this should be limited to only detecting explosives, and should only exist on the evac shuttle.

@Killerqu00
Copy link

I think this should be limited to only detecting explosives, and should only exist on the evac shuttle.

This is one of the options of implementing that, however, there are still problems with that:

  • Explosives are not the only things that can sabotage a shuttle completely
  • Shuttle is a way easier way to achieve almost any objective due to how small it is. There should be something that makes it harder to just wait until the shuttle to do objectives, and this scanner aims to be one of these things

@lorahart2
Copy link

What of it detects both unspent TC and explosives meaning you should be incentivized to preplan

@Smugman
Copy link

Smugman commented Jan 14, 2025

I personally really do not like this, especially in regards to steal objectives, and ESPECIALLY with a portable version.
I think this structure is a bandaid solution that would outsource a lot of the detective work of security.
If this is yet another PR mainly conceptualised to deal with shuttlebombing, then it should likely be constrained to shuttlebombing instead of detecting every kind of antag activity at once.

  • Shuttle is a way easier way to achieve almost any objective due to how small it is. There should be something that makes it harder to just wait until the shuttle to do objectives, and this scanner aims to be one of these things

Yes, but it is also significantly harder to go unseen when acomplishing objectives. The EVAC shuttle is incredibly chaotic, and security is appropriatly short tempered there. In most cases any incident on the EVAC shuttle is addressed by simply cuffing them and waiting to "deal with them at CC" and/or lethalling them.

  • There are many ways to bypass the scanner, such as:

That is not the point, the fact is that this is yet another complication to steal objectives which is unneeded. If you manage to steal an object unseen, and manage to avoid random searches or hide your contraband cleverly, I do not think that a random machine at roundend should immediatly bust you at no cost or effort to Security.

Searches can be avoided by clever players in two ways

  1. Dont get searched, Simply dont be suspicious, or avoid security officers during their "random search" period. If the CMOs hypospray got stolen, security is most likely to search people close to medical, for example.
  2. Hide your contraband. Maybe you have a storage implant to hide your viper in. maybe you stuffed the Emergency Orders into your Survival box, or your zipped up labcoat, or another place that not every security officer knows to check.

The Contradetector circumvents both of these, especially the storage implant (Free metashield break exploit, 2655, unpatched)
You are forced to walk through it, and no matter how cleverly you hide it, or even if you spent your limited TC on anti-search items, it will detect them.

"Ok you've been flagged as positive 3 times, we're going to be keeping you in cuffs until evac arrives at cc"

This is very accurate to how this is going to go.

If this were implemented, then anyone knowingly carrying contraband has very little reason walk through it

Most Evac shuttles would likely be set up to not give you a choice, or security would funnel everyone through the one entrance with a Scanner.

I feel this is very overcorrective and will be relentlessly powergamed, no matter how high the rate of false positives or negatives is.

@Killerqu00
Copy link

That is not the point, the fact is that this is yet another complication to steal objectives which is unneeded. If you manage to steal an object unseen, and manage to avoid random searches or hide your contraband cleverly, I do not think that a random machine at roundend should immediatly bust you at no cost or effort to Security.

"it should trigger on any contraband that is not department specific"
emergency orders (which don't exist anymore btw) are department-specific (command), as well as hypospray. this does not affect steal objectives in any way, since steal objectives are either department restricted or not even contraband

The Contradetector circumvents both of these, especially the storage implant (Free metashield break exploit, 2655, unpatched) You are forced to walk through it, and no matter how cleverly you hide it, or even if you spent your limited TC on anti-search items, it will detect them.

  1. The detector is supposed to be mapped on evacshuttles and in brig. If you're in brig, the odds are you're being searched already. If you come to evac with syndicate contraband, consider either not doing that or at least being somewhat smart about it.
  2. If you're getting searched in the field (not in security), then you're not being scanned anyway, meaning that strat is working. Otherwise, the officer won't be able to find the stuff anyway, since they don't know what to check, specifically. A case could be made for repeated scans, but I'm currently working on that flaw in design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Related to design documentation for Space Station 14. English
Projects
None yet
Development

Successfully merging this pull request may close these issues.