Further clarify ITF-8 and LTF-8 encodings#858
Open
jkbonfield wants to merge 1 commit into
Open
Conversation
yfarjoun
reviewed
Jul 10, 2026
| number of bytes used to encode a single value. To do so 64 bits are required and | ||
| this can be done with 9 byte at most with the first byte consisting of just 1s | ||
| or 0xFF value. | ||
| This is an extension of ITF-8 above to accommodate 64-bit unsigned quantities. |
Contributor
There was a problem hiding this comment.
not sure what you mean by "above". the table? some other reference to ITF-8?
Contributor
Author
There was a problem hiding this comment.
It meant the ITF-8 definition as a whole, rather than any specific bit. I'll remove the word "above" as it's unnecessary. (Plus LaTeX being what it is, there's no guarantee the table will remain above this paragraph in future versions.)
yfarjoun
reviewed
Jul 10, 2026
yfarjoun
left a comment
yfarjoun
left a comment
Contributor
There was a problem hiding this comment.
just one question but otherwise LGTM!
Thanks to Yossi Farjoun for the table. Fixes samtools#855. Signed-off-by: James Bonfield <jkb@sanger.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to Yossi Farjoun for the table.
Fixes #855.