Use at least regex 1.5.1 to avoid build build failures without perf-literal feature
#2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f-literal` feature When building a crate that depends on `bindgen` with `-Zminimal-features`, `cargo` ends up selecting `regex 1.5.0` which fails to compile when its `perf-literal` feature wasn't enabled. This was aptly fixed in `1.5.1`, albeit without yanking the `1.5.0` release. rust-lang/regex#931
This was referenced Jan 10, 2024
tgross35
suggested changes
Jan 12, 2024
| @@ -36,7 +36,7 @@ peeking_take_while = "0.1.2" | |||
| prettyplease = { version = "0.2.7", optional = true, features = ["verbatim"] } | |||
| proc-macro2 = { version = "1", default-features = false } | |||
| quote = { version = "1", default-features = false } | |||
| regex = { version = "1.5", default-features = false, features = ["std", "unicode-perl"] } | |||
| regex = { version = "1.5.1", default-features = false, features = ["std", "unicode-perl"] } | |||
There was a problem hiding this comment.
Suggested change
| regex = { version = "1.5.1", default-features = false, features = ["std", "unicode-perl"] } | |
| regex = { version = "1.9.6", default-features = false, features = ["std", "unicode-perl"] } |
I think it is OK to bump to the latest version supported by bindgen's MSRV (1.60, regex 1.10 is the first to jump to 1.65)
MarijnS95
added a commit
to Traverse-Research/adlx-rs
that referenced
this pull request
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a crate that depends on
bindgenwith-Zminimal-features,cargoends up selectingregex 1.5.0which fails to compile when itsperf-literalfeature isn't enabled. This was aptly fixed in1.5.1, albeit without yanking the1.5.0release.rust-lang/regex#931