Skip to content

Update minimum regex version to fix compile error #2721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

kawasin73
Copy link
Contributor

This is reopened PR of #2717 because I don't have the permission to reopen it.

Even with regex 1.5.1, bindgen fails to build with -Z minimal-versions.

$ cd path/to/rust-bindgen
$ cargo +nightly update -Z minimal-versions
$ cargo build
   Compiling regex-syntax v0.6.24
error[E0433]: failed to resolve: use of undeclared crate or module `unicode_tables`
   --> /home/kawasin/.cargo/registry/src/index.crates.io-6f17d22bba15001f/regex-syntax-0.6.24/src/unicode.rs:351:13
    |
351 |         use unicode_tables::perl_space::WHITE_SPACE;
    |             ^^^^^^^^^^^^^^ use of undeclared crate or module `unicode_tables`

error[E0433]: failed to resolve: use of undeclared crate or module `unicode_tables`
   --> /home/kawasin/.cargo/registry/src/index.crates.io-6f17d22bba15001f/regex-syntax-0.6.24/src/unicode.rs:375:13
    |
375 |         use unicode_tables::perl_decimal::DECIMAL_NUMBER;
    |             ^^^^^^^^^^^^^^ use of undeclared crate or module `unicode_tables`

For more information about this error, try `rustc --explain E0433`.
error: could not compile `regex-syntax` (lib) due to 2 previous errors


regex 1.5.3 solves the compile error with unicode-perl feature. https://github.com/rust-lang/regex/blob/master/CHANGELOG.md#153-2021-05-01

Specifing wrong version as the minimum version can cause compile errors on products which depend on bindgen. Minimum versions can be checked with this cargo command.

cargo +nightly update -Z minimal-versions

regex 1.5.3 solves the compile error with unicode-perl feature.
https://github.com/rust-lang/regex/blob/master/CHANGELOG.md#153-2021-05-01

Specifing wrong version as the minimum version can cause compile errors
on products which depend on bindgen. Minimum versions can be checked
with this cargo command.

```
cargo +nightly update -Z minimal-versions
```
@kawasin73
Copy link
Contributor Author

r? @emilio

@rustbot
Copy link
Collaborator

rustbot commented Jan 15, 2024

Error: The feature assign is not enabled in this repository.
To enable it add its section in the triagebot.toml in the root of the repository.

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@tgross35
Copy link
Contributor

Can you just bump it to the latest version that works for our MSRV? I don’t think there’s any reason to keep such an old version as long as we can build, more bugs have been fixed since #2714 (comment)

@emilio
Copy link
Contributor

emilio commented Feb 7, 2024

It's fine, the lockfile uses a newer one.

@emilio emilio merged commit 8b1f971 into rust-lang:main Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants