Update minimum regex version to fix compile error #2717
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regex 1.5.3 solves the compile error with unicode-perl feature. https://github.com/rust-lang/regex/blob/master/CHANGELOG.md#153-2021-05-01 Specifing wrong version as the minimum version can cause compile errors on products which depend on bindgen. Minimum versions can be checked with this cargo command. ``` cargo +nightly update -Z minimal-versions ```
|
r? @emilio |
|
I think you may as well go all the way up to version 1.9.6, which has a lot more bugfixes and is the last version to support bindgen's MSRV of 1.60. 1.7.1 is what is in Cargo.lock anyway. |
tgross35
suggested changes
Jan 12, 2024
| proc-macro2 = { version = "1", default-features = false } | ||
| quote = { version = "1", default-features = false } | ||
| regex = { version = "1.5", default-features = false, features = ["std", "unicode-perl"] } | ||
| regex = { version = "1.5.3", default-features = false, features = ["std", "unicode-perl"] } |
There was a problem hiding this comment.
Suggested change
| regex = { version = "1.5.3", default-features = false, features = ["std", "unicode-perl"] } | |
| regex = { version = "1.9.6", default-features = false, features = ["std", "unicode-perl"] } |
|
Ah, this is actually a duplicate of #2714 |
|
Let's close as a dup. Happy to take a patch updating to a newer regex version, though given users can use the very latest it's not a big deal. |
|
☔ The latest upstream changes (presumably 11aeae4) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Even with regex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regex 1.5.3 solves the compile error with unicode-perl feature. https://github.com/rust-lang/regex/blob/master/CHANGELOG.md#153-2021-05-01
Specifing wrong version as the minimum version can cause compile errors on products which depend on bindgen. Minimum versions can be checked with this cargo command.