RJS-2810: Add privacy manifest for Apple App Store #6642
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kneth
force-pushed
the
kneth/privacy-manifest
branch
from
8ef5f48
to
922c970
Compare
kneth
force-pushed
the
kneth/privacy-manifest
branch
from
1eed0df
to
a336be6
Compare
* [12.8.1-alpha.0] Bump version * [12.8.1-alpha.0] Bump version --------- Co-authored-by: kneth <[email protected]> Co-authored-by: Kenneth Geisshirt <[email protected]>
Co-authored-by: kneth <[email protected]>
Co-authored-by: LJ <[email protected]>
elle-j
approved these changes
Jun 10, 2024
| @@ -20,6 +20,21 @@ | |||
| <!-- * Using Realm Core vX.Y.Z --> | |||
| <!-- * Upgraded Realm Core from vX.Y.Z to vA.B.C --> | |||
|
|
|||
| ## 12.8.1-alpha.0 (2024-05-03) | |||
There was a problem hiding this comment.
Just needs a rebase to add the CHANGELOG entries to the latest 👍
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "realm", | |||
| "version": "12.8.0", | |||
| "version": "12.8.1-alpha.0", | |||
kraenhansen
reviewed
Jun 10, 2024
Comment on lines
-52
to
-54
| # Setting up clang | ||
| 'CLANG_CXX_LANGUAGE_STANDARD' => 'c++17', | ||
| 'CLANG_CXX_LIBRARY' => 'libc++', |
There was a problem hiding this comment.
I'm surprised this deletion really needed 🤔 And this change conflicts with a change on #6650
|
Redoing the changes in #6715 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This closes #6638
The manifest
The actual privacy manifest is based on our current understanding of what is needed.
Testing
npm packis used to create atgzfilenpm install realm-x.y.z.tgzcd ios && pod installUnknowns
I am a bit uncertain if the proposed privacy manifest (in particular the location of it) is compatible with Catalyst.
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessary