Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RJS-2810: Add privacy manifest for Apple App Store #6642

Closed
wants to merge 7 commits into from
Closed

RJS-2810: Add privacy manifest for Apple App Store #6642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
93c27dc
Add privacy manifest for Apple App Store
kneth May 1, 2024
a336be6
Cleaner solution
kneth May 3, 2024
0ef7370
wip
kneth May 3, 2024
20d54b7
core commit
kneth May 3, 2024
17a58b3
Prepare for 12.8.1-alpha.0 (#6652)
fealebenpae May 4, 2024
04176cb
Prepare for vNext (#6655)
github-actions[bot] May 4, 2024
d336714
Update CHANGELOG.md
kneth May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,21 @@
<!-- * Using Realm Core vX.Y.Z -->
<!-- * Upgraded Realm Core from vX.Y.Z to vA.B.C -->

## 12.8.1-alpha.0 (2024-05-03)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a rebase to add the CHANGELOG entries to the latest 👍


### Fixed
* <How to hit and notice issue? what was the impact?> ([#????](https://github.com/realm/realm-js/issues/????), since v?.?.?)
* None

### Compatibility
* React Native >= v0.71.4
* Realm Studio v15.0.0.
* File format: generates Realms with format v24 (reads and upgrades file format v10.

### Internal
* Using Realm Core v14.6.1.
* Added [privacy manifest](https://developer.apple.com/documentation/bundleresources/privacy_manifest_files) for Apple App Store. ([#6638](https://github.com/realm/realm-js/issues/6638))

## 12.8.0 (2024-05-01)

### Deprecations
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

31 changes: 31 additions & 0 deletions packages/realm/PrivacyInfo.xcprivacy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>NSPrivacyTrackingDomains</key>
<array/>
<key>NSPrivacyCollectedDataTypes</key>
<array/>
<key>NSPrivacyAccessedAPITypes</key>
<array>
<dict>
<key>NSPrivacyAccessedAPITypeReasons</key>
<array>
<string>C617.1</string>
</array>
<key>NSPrivacyAccessedAPIType</key>
<string>NSPrivacyAccessedAPICategoryFileTimestamp</string>
</dict>
<dict>
<key>NSPrivacyAccessedAPITypeReasons</key>
<array>
<string>E174.1</string>
</array>
<key>NSPrivacyAccessedAPIType</key>
<string>NSPrivacyAccessedAPICategoryDiskSpace</string>
</dict>
</array>
<key>NSPrivacyTracking</key>
<false/>
</dict>
</plist>
10 changes: 2 additions & 8 deletions packages/realm/RealmJS.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,12 @@ Pod::Spec.new do |s|

s.source_files = 'react-native/ios/RealmReact/*.mm'
s.public_header_files = 'react-native/ios/RealmReact/*.h'

s.resource_bundles = { 'RealmJS' => ['PrivacyInfo.xcprivacy'] }

s.frameworks = uses_frameworks ? ['React'] : []

s.library = 'c++', 'z', 'compression'

s.pod_target_xcconfig = {
# Setting up clang
'CLANG_CXX_LANGUAGE_STANDARD' => 'c++17',
'CLANG_CXX_LIBRARY' => 'libc++',
Comment on lines -52 to -54
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this deletion really needed 🤔 And this change conflicts with a change on #6650

# Setting the current project version and versioning system to get a symbol for analytics
'CURRENT_PROJECT_VERSION' => s.version,
'VERSIONING_SYSTEM' => 'apple-generic',
elle-j marked this conversation as resolved.
Show resolved Hide resolved
# Header search paths are prefixes to the path specified in #include macros
'HEADER_SEARCH_PATHS' => [
'"$(PODS_TARGET_SRCROOT)/react-native/ios/RealmReact/"',
Expand Down
3 changes: 2 additions & 1 deletion packages/realm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "realm",
"version": "12.8.0",
"version": "12.8.1-alpha.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as previous comment 🙂

"description": "Realm by MongoDB is an offline-first mobile database: an alternative to SQLite and key-value stores",
"license": "apache-2.0",
"homepage": "https://www.mongodb.com/docs/realm/",
Expand Down Expand Up @@ -74,6 +74,7 @@
"scripts/submit-analytics.mjs",
"react-native.config.js",
"RealmJS.podspec",
"PrivacyInfo.xcprivacy",
"binding.gyp"
],
"scripts": {
Expand Down
Loading