Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify RealmJS.podspec to avoid passing the version #6686

Merged
merged 1 commit into from
May 28, 2024

Conversation

kraenhansen
Copy link
Member

What, How & Why?

I believe this was only used by https://github.com/realm/realm-js/blob/6593a851cd0a7f49fb85ad13bb7c4e1fd245f346/react-native/ios/RealmReact/RealmAnalytics.mm#L69C23-L69C43 and we've later refactored the analytics to send this information from the SDK: here and here.

@kraenhansen kraenhansen self-assigned this May 27, 2024
@kraenhansen kraenhansen added the no-jira-ticket Skip checking the PR title for Jira reference label May 27, 2024
@kraenhansen kraenhansen requested review from kneth and elle-j May 27, 2024 18:19
Copy link
Contributor

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

Copy link
Contributor

@kneth kneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and you can remove even more if you want: see #6642

@kraenhansen kraenhansen merged commit 5f66e14 into main May 28, 2024
30 of 32 checks passed
@kraenhansen kraenhansen deleted the kh/remove-version-in-podspec branch May 28, 2024 08:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-jira-ticket Skip checking the PR title for Jira reference T-Internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants