Identifier name

.swiftlint.yml

@@ -62,6 +62,7 @@ attributes:
 identifier_name:
  excluded:
  - id
+ previous_function_behavior: true
 large_tuple: 3
 number_separator:
  minimum_length: 5

CHANGELOG.md

@@ -2,7 +2,10 @@
 
 #### Breaking
 
-* None.
+* `identifier_name` now evaluates function names for both length and non 
+ alphanumeric violations. Set the option 
+ `previous_function_behavior: true` in your config file to revert to older 
+ behavior
 
 #### Experimental
 
@@ -19,6 +22,11 @@
 * Rewrite `control_statement` rule using SwiftSyntax. 
  [SimplyDanny](https://github.com/SimplyDanny)
 
+* `identifier_name` now has the option to ignore minimum variable length 
+ within short closures. 
+ [mredig](https://github.com/mredig)
+ [5140](https://github.com/realm/SwiftLint/pull/5140)
+
 #### Bug Fixes
 
 * Fix false positive in `control_statement` rule that triggered on conditions
@@ -52,6 +60,11 @@
  [Martin Redington](https://github.com/mildm8nnered)
  [#5120](https://github.com/realm/SwiftLint/issues/5120)
 
+* `identifier_name` behavior corrected for accuracy to its description. See the
+ breaking change for more info 
+ [mredig](https://github.com/mredig)
+ [5140](https://github.com/realm/SwiftLint/pull/5140) 
+
 ## 0.52.4: Lid Switch
 
 #### Breaking

CONTRIBUTING.md

@@ -57,8 +57,8 @@ with Swift Package Manager on Linux. When contributing code changes, please
 ensure that all three supported build methods continue to work and pass tests.
 
 ```shell
-$ xcodebuild -scheme swiftlint test
-$ swift test
+$ xcodebuild -scheme swiftlint clean test -destination 'platform=macOS' | xcpretty
+$ swift test | xcpretty
 $ make docker_test
 ```
 

Source/SwiftLintBuiltInRules/Rules/RuleConfigurations/NameConfiguration.swift

@@ -18,6 +18,18 @@ struct NameConfiguration<Parent: Rule>: RuleConfiguration, Equatable {
  private(set) var unallowedSymbolsSeverity = Severity.error
  @ConfigurationElement(key: "validates_start_with_lowercase")
  private(set) var validatesStartWithLowercase = StartWithLowercaseConfiguration.error
+ /// Only valid for `identifier_name`
+ @ConfigurationElement(key: "ignore_min_length_for_short_closure_content")
+ private(set) var ignoreMinLengthForShortClosureContent = false
+ /// Only valid for `identifier_name`
+ /// Before this update, the code skipped over functions in evaluating both their length and their special
+ /// characters. The code read `if !SwiftDeclarationKind.functionKinds.contains(kind) {` which is incredibly hard
+ /// to follow double negative logic, plus the description for the rule made no indication that functions were
+ /// excluded from this rule. And given the history of this rule as previously being variables only, but refactored
+ /// to the generic concept of identifiers (which should include function *identifiers*, this leads me to believe it
+ /// was unintentional. Hence, I'm defaulting to `false`.
+ @ConfigurationElement(key: "previous_function_behavior")
+ private(set) var previousFunctionBehavior = false
 
  var minLengthThreshold: Int {
  return max(minLength.warning, minLength.error ?? minLength.warning)
@@ -38,7 +50,9 @@ struct NameConfiguration<Parent: Rule>: RuleConfiguration, Equatable {
  excluded: [String] = [],
  allowedSymbols: [String] = [],
  unallowedSymbolsSeverity: Severity = .error,
- validatesStartWithLowercase: StartWithLowercaseConfiguration = .error) {
+ validatesStartWithLowercase: StartWithLowercaseConfiguration = .error,
+ ignoreMinLengthForShortClosureContent: Bool = false,
+ previousFunctionBehavior: Bool = false) {
  minLength = SeverityLevels(warning: minLengthWarning, error: minLengthError)
  maxLength = SeverityLevels(warning: maxLengthWarning, error: maxLengthError)
  self.excludedRegularExpressions = Set(excluded.compactMap {
@@ -47,6 +61,8 @@ struct NameConfiguration<Parent: Rule>: RuleConfiguration, Equatable {
  self.allowedSymbols = Set(allowedSymbols)
  self.unallowedSymbolsSeverity = unallowedSymbolsSeverity
  self.validatesStartWithLowercase = validatesStartWithLowercase
+ self.ignoreMinLengthForShortClosureContent = ignoreMinLengthForShortClosureContent
+ self.previousFunctionBehavior = previousFunctionBehavior
  }
 
  mutating func apply(configuration: Any) throws {
@@ -84,6 +100,12 @@ struct NameConfiguration<Parent: Rule>: RuleConfiguration, Equatable {
  """
  ).print()
  }
+ if let ignoreMinLengthForClosures = configurationDict[$ignoreMinLengthForShortClosureContent] as? Bool {
+ self.ignoreMinLengthForShortClosureContent = ignoreMinLengthForClosures
+ }
+ if let previousFunctionBehavior = configurationDict[$previousFunctionBehavior] as? Bool {
+ self.previousFunctionBehavior = previousFunctionBehavior
+ }
  }
 }