Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identifier name #5140

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Identifier name #5140

wants to merge 17 commits into from

Commits on Jul 25, 2023

  1. (fix) remove deprecated usage in test

    @mredig
    mredig committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    89c674c View commit details
    Browse the repository at this point in the history

  2. (refactor) migrate identifier name to the modern SwiftSyntaxRule

    @mredig
    mredig committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    2c80f84 View commit details
    Browse the repository at this point in the history

  3. (refactor) also check function identifiers

    @mredig
    mredig committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    5b367ec View commit details
    Browse the repository at this point in the history

  4. (fix) skip checking identifiers for operators

    @mredig
    mredig committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    277e0fd View commit details
    Browse the repository at this point in the history

  5. (refactor) include enum cases in identifier_name 

    (fix) identifier name can now handle backtick escaped names

(refactor) remove deprecated values from tests
    @mredig
    mredig committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    90c71aa View commit details
    Browse the repository at this point in the history

  6. (refactor) remove original identifier name file

    @mredig
    mredig committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    019d5bb View commit details
    Browse the repository at this point in the history

  7. (feat) added option to ignore small identifiers in short closures

    @mredig
    mredig committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    0d3464c View commit details
    Browse the repository at this point in the history

  8. (refactor) implement auto swiftlint changes

    @mredig
    mredig committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    8dcd003 View commit details
    Browse the repository at this point in the history

  9. (refactor) include character count in warning text

    @mredig
    mredig committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    284e309 View commit details
    Browse the repository at this point in the history

  10. (refactor) address swiftlint issues

    @mredig
    mredig committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    a25b7d8 View commit details
    Browse the repository at this point in the history

  11. (refactor) code organization

    @mredig
    mredig committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    5cca388 View commit details
    Browse the repository at this point in the history

  12. (feat) add option to maintain previous functionality in identifier_name 

    but default is now to actually evaluate function name lengths
    @mredig
    mredig committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    d14da77 View commit details
    Browse the repository at this point in the history

  13. (fix) change regex on test because it was accidentally matching 

    additional values it should not be
    @mredig
    mredig committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    cceeba5 View commit details
    Browse the repository at this point in the history

  14. (refactor) renamed previous_function_behavior because it was twofold 

    both length and non alphanumeric character evaluation was being ignored in the previous code. also use it to allow for older behavior in both cases
    @mredig
    mredig committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    e4491c9 View commit details
    Browse the repository at this point in the history

  15. (nit) updated changelog

    @mredig
    mredig committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    11f3dcf View commit details
    Browse the repository at this point in the history

  16. (refactor) tweaked the contributing file to correct and enhance the t… 

    …est commands
    @mredig
    mredig committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    6936262 View commit details
    Browse the repository at this point in the history

  17. (nit) changelog vertical whitespace

    @mredig
    mredig committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    23b55bf View commit details
    Browse the repository at this point in the history