Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identifier name #5140

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Identifier name #5140

wants to merge 17 commits into from

Conversation

mredig
Copy link
Contributor

@mredig mredig commented Jul 23, 2023

Refactors identifier_name to use the newer SwiftSyntaxRule protocol to enable a new option to disable minimum variable length within short closures.

Basically, I want to be able to make these kinds of closures:

let queue: OperationQueue = {
    let q = OperationQueue()
    q.maxConcurrentSomething = 4
    return q
}()

or

[5, 3, 4, 2, 1, 6].sorted(by: { a, b in
    a < b
}

As a side effect, the first test I ran showed that the previous rule's code didn't evaluate functions for a couple promises from the rule's description:

Identifier names should only contain alphanumeric characters and start with a lowercase character or should only contain capital letters. In an exception to the above, variable names may start with a capital letter when they are declared as static. Variable names should not be too long or too short.

As stated there, function names should be limited to alphanumeric characters, start with a lowercase character, and not be too long or too short. (Okay, so as I'm writing this, I see that only Variable names is specifically called out for length limitations, but wouldn't we want that on functions too? If we want to adjust that, I'll happily do so, just not tonight!)

Anyways, I defaulted to what the description says (or at least what I thought it said until a moment ago), but added a configuration option to revert to the older behavior.

@SwiftLintBot
Copy link

SwiftLintBot commented Jul 23, 2023

16580 Warnings
⚠️ Big PR
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:53:5: warning: Identifier Name Violation: Variable name 'sw' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:39:5: warning: Identifier Name Violation: Variable name 'dt' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:51:9: warning: Identifier Name Violation: Enum Element name 'dt' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:100:5: warning: Identifier Name Violation: Variable name 'dt' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:111:9: warning: Identifier Name Violation: Enum Element name 'dt' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:134:5: warning: Identifier Name Violation: Variable name 'dt' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:50:5: warning: Identifier Name Violation: Variable name 'dt' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:62:9: warning: Identifier Name Violation: Enum Element name 'dt' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:31:5: warning: Identifier Name Violation: Variable name 'dt' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Aerial.swift:175:1: warning: Superfluous Disable Command Violation: SwiftLint rule 'identifier_name' did not trigger a violation in the disabled region; remove the disable command (superfluous_disable_command)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:185:17: warning: Identifier Name Violation: Variable name 'cc' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:200:13: warning: Identifier Name Violation: Variable name 'cc' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:85:12: warning: Identifier Name Violation: Variable name 'sb' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:89:16: warning: Identifier Name Violation: Variable name 'sd' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/CustomVideoFolders.swift:145:9: warning: Identifier Name Violation: Variable name 'me' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/CustomVideoFolders.swift:25:9: warning: Identifier Name Violation: Variable name 'me' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/CustomVideoFolders.swift:80:9: warning: Identifier Name Violation: Variable name 'me' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Extensions/AVAsset+VideoOrientation.swift:19:19: warning: Identifier Name Violation: Enum Element name 'up' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/Battery.swift:50:13: warning: Identifier Name Violation: Variable name 'ps' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Hardware/NightShift.swift:52:20: warning: Identifier Name Violation: Variable name 'ts' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Music/Music.swift:114:28: error: Identifier Name Violation: Variable name '_artwork' should only contain alphanumeric and other allowed characters (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Music/Music.swift:36:19: warning: Identifier Name Violation: Variable name 'MRMediaRemoteRegisterForNowPlayingNotificationsPointer' should be between 3 and 40 characters long (54 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/Music/Music.swift:38:13: warning: Identifier Name Violation: Variable name 'MRMediaRemoteRegisterForNowPlayingNotifications' should be between 3 and 40 characters long (47 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView+Brightness.swift:19:24: warning: Identifier Name Violation: Variable name 'to' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/AnimatableLayer.swift:179:9: warning: Identifier Name Violation: Variable name 'mx' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/AnimatableLayer.swift:202:9: warning: Identifier Name Violation: Variable name 'my' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/AnimatableLayer.swift:71:9: warning: Identifier Name Violation: Variable name 'mx' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/AnimatableLayer.swift:72:9: warning: Identifier Name Violation: Variable name 'my' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/AnimationTextLayer.swift:85:9: warning: Identifier Name Violation: Variable name 'mx' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/LocationLayer.swift:84:21: warning: Identifier Name Violation: Variable name 'ts' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/Weather/ConditionLayer.swift:155:1: warning: Superfluous Disable Command Violation: SwiftLint rule 'identifier_name' did not trigger a violation in the disabled region; remove the disable command (superfluous_disable_command)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/Weather/WeatherLayer.swift:26:13: warning: Identifier Name Violation: Variable name 'fm' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/Layers/Weather/WeatherLayer.swift:59:13: warning: Identifier Name Violation: Variable name 'fm' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/PrefPanel/InfoCommonView.swift:155:12: warning: Identifier Name Violation: Variable name 'fp' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/PrefPanel/InfoWeatherView.swift:130:9: warning: Identifier Name Violation: Variable name 'fm' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/Alamofire.swift:37:8: warning: Identifier Name Violation: Variable name 'AF' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/AlamofireExtended.swift:44:12: warning: Identifier Name Violation: Variable name 'af' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/AlamofireExtended.swift:46:5: warning: Identifier Name Violation: Variable name 'af' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/AlamofireExtended.swift:51:19: warning: Identifier Name Violation: Variable name 'af' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/AlamofireExtended.swift:57:12: warning: Identifier Name Violation: Variable name 'af' should be between 3 and 40 characters long (2 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:618:10: warning: Identifier Name Violation: Variable name 'requestDidFailToCreateURLRequestWithError' should be between 3 and 40 characters long (41 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:621:10: warning: Identifier Name Violation: Variable name 'requestDidAdaptInitialRequestToAdaptedRequest' should be between 3 and 40 characters long (45 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:666:10: warning: Identifier Name Violation: Variable name 'requestDidValidateRequestResponseDataWithResult' should be between 3 and 40 characters long (47 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:672:10: warning: Identifier Name Violation: Variable name 'requestDidValidateRequestResponseWithResult' should be between 3 and 40 characters long (43 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:678:10: warning: Identifier Name Violation: Variable name 'requestDidFailToCreateUploadableWithError' should be between 3 and 40 characters long (41 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:684:10: warning: Identifier Name Violation: Variable name 'requestDidFinishDownloadingUsingTaskWithResult' should be between 3 and 40 characters long (46 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/EventMonitor.swift:690:10: warning: Identifier Name Violation: Variable name 'requestDidValidateRequestResponseFileURLWithResult' should be between 3 and 40 characters long (50 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/NetworkReachabilityManager.swift:278:9: error: Identifier Name Violation: Variable name 'W' should be between 3 and 40 characters long (1 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/NetworkReachabilityManager.swift:279:9: error: Identifier Name Violation: Variable name 'R' should be between 3 and 40 characters long (1 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/NetworkReachabilityManager.swift:280:9: error: Identifier Name Violation: Variable name 'c' should be between 3 and 40 characters long (1 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/NetworkReachabilityManager.swift:281:9: error: Identifier Name Violation: Variable name 't' should be between 3 and 40 characters long (1 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/NetworkReachabilityManager.swift:282:9: error: Identifier Name Violation: Variable name 'i' should be between 3 and 40 characters long (1 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/NetworkReachabilityManager.swift:283:9: error: Identifier Name Violation: Variable name 'C' should be between 3 and 40 characters long (1 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/NetworkReachabilityManager.swift:284:9: error: Identifier Name Violation: Variable name 'D' should be between 3 and 40 characters long (1 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/NetworkReachabilityManager.swift:285:9: error: Identifier Name Violation: Variable name 'l' should be between 3 and 40 characters long (1 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/NetworkReachabilityManager.swift:286:9: error: Identifier Name Violation: Variable name 'd' should be between 3 and 40 characters long (1 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/NetworkReachabilityManager.swift:287:9: error: Identifier Name Violation: Variable name 'a' should be between 3 and 40 characters long (1 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/RequestTaskMap.swift:115:14: warning: Identifier Name Violation: Function name 'disassociateIfNecessaryAfterGatheringMetricsForTask' should be between 3 and 40 characters long (51 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/RequestTaskMap.swift:127:14: warning: Identifier Name Violation: Function name 'disassociateIfNecessaryAfterCompletingTask' should be between 3 and 40 characters long (42 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/Session.swift:1002:22: error: Identifier Name Violation: Variable name 'r' should be between 3 and 40 characters long (1 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/Session.swift:1003:22: error: Identifier Name Violation: Variable name 'r' should be between 3 and 40 characters long (1 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/Session.swift:1004:22: error: Identifier Name Violation: Variable name 'r' should be between 3 and 40 characters long (1 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Source/Session.swift:1005:22: error: Identifier Name Violation: Variable name 'r' should be between 3 and 40 characters long (1 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/AuthenticationInterceptorTests.swift:176:5: warning: Identifier Name Violation: Function name 'testThatInterceptorQueuesAdaptOperationWhenRefreshing' should be between 3 and 40 characters long (53 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/AuthenticationInterceptorTests.swift:218:5: error: Identifier Name Violation: Function name 'testThatInterceptorThrowsMissingCredentialErrorWhenCredentialIsNil' should be between 3 and 40 characters long (66 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/AuthenticationInterceptorTests.swift:251:5: warning: Identifier Name Violation: Function name 'testThatInterceptorRethrowsRefreshErrorFromAdapt' should be between 3 and 40 characters long (48 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/AuthenticationInterceptorTests.swift:293:5: warning: Identifier Name Violation: Function name 'testThatInterceptorDoesNotRetryWithoutResponse' should be between 3 and 40 characters long (46 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/AuthenticationInterceptorTests.swift:328:5: error: Identifier Name Violation: Function name 'testThatInterceptorDoesNotRetryWhenRequestDoesNotFailDueToAuthError' should be between 3 and 40 characters long (67 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/AuthenticationInterceptorTests.swift:362:5: error: Identifier Name Violation: Function name 'testThatInterceptorThrowsMissingCredentialErrorWhenCredentialIsNilAndRequestShouldBeRetried' should be between 3 and 40 characters long (91 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/AuthenticationInterceptorTests.swift:405:5: error: Identifier Name Violation: Function name 'testThatInterceptorRetriesRequestThatFailedWithOutdatedCredential' should be between 3 and 40 characters long (65 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/AuthenticationInterceptorTests.swift:448:5: error: Identifier Name Violation: Function name 'testThatInterceptorDoesNotDeadlockWhenAuthenticatorCallsRefreshCompletionSynchronouslyOnCallingQueue' should be between 3 and 40 characters long (100 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/AuthenticationInterceptorTests.swift:492:5: warning: Identifier Name Violation: Function name 'testThatInterceptorRetriesRequestAfterRefresh' should be between 3 and 40 characters long (45 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/AuthenticationInterceptorTests.swift:527:5: warning: Identifier Name Violation: Function name 'testThatInterceptorRethrowsRefreshErrorFromRetry' should be between 3 and 40 characters long (48 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/AuthenticationInterceptorTests.swift:566:5: error: Identifier Name Violation: Function name 'testThatInterceptorTriggersRefreshWithMultipleParallelRequestsReturning401Responses' should be between 3 and 40 characters long (83 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/AuthenticationInterceptorTests.swift:614:5: error: Identifier Name Violation: Function name 'testThatInterceptorIgnoresExcessiveRefreshWhenRefreshWindowIsNil' should be between 3 and 40 characters long (64 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/AuthenticationInterceptorTests.swift:61:22: warning: Identifier Name Violation: Variable name 'isRequestAuthenticatedWithCredentialCount' should be between 3 and 40 characters long (41 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/AuthenticationInterceptorTests.swift:654:5: error: Identifier Name Violation: Function name 'testThatInterceptorThrowsExcessiveRefreshErrorWhenExcessiveRefreshOccurs' should be between 3 and 40 characters long (72 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/AuthenticationTests.swift:146:5: error: Identifier Name Violation: Function name '_testHTTPDigestAuthenticationWithInvalidCredentials' should only contain alphanumeric and other allowed characters (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/AuthenticationTests.swift:172:5: error: Identifier Name Violation: Function name '_testHTTPDigestAuthenticationWithValidCredentials' should only contain alphanumeric and other allowed characters (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/AuthenticationTests.swift:30:5: warning: Identifier Name Violation: Function name 'testHTTPBasicAuthenticationFailsWithInvalidCredentials' should be between 3 and 40 characters long (54 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/AuthenticationTests.swift:56:5: warning: Identifier Name Violation: Function name 'testHTTPBasicAuthenticationWithValidCredentials' should be between 3 and 40 characters long (47 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/AuthenticationTests.swift:83:5: warning: Identifier Name Violation: Function name 'testHTTPBasicAuthenticationWithStoredCredentials' should be between 3 and 40 characters long (48 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CacheTests.swift:198:5: warning: Identifier Name Violation: Function name 'testURLCacheContainsCachedResponsesForAllRequests' should be between 3 and 40 characters long (49 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CacheTests.swift:246:5: warning: Identifier Name Violation: Function name 'testUseLocalCacheDataIfExistsOtherwiseLoadFromNetworkPolicy' should be between 3 and 40 characters long (59 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CacheTests.swift:257:5: warning: Identifier Name Violation: Function name 'testUseLocalCacheDataAndDontLoadFromNetworkPolicy' should be between 3 and 40 characters long (49 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CachedResponseHandlerTests.swift:102:5: warning: Identifier Name Violation: Function name 'testThatSessionCachedResponseHandlerCanCacheResponse' should be between 3 and 40 characters long (52 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CachedResponseHandlerTests.swift:122:5: warning: Identifier Name Violation: Function name 'testThatSessionCachedResponseHandlerCanNotCacheResponse' should be between 3 and 40 characters long (55 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CachedResponseHandlerTests.swift:142:5: warning: Identifier Name Violation: Function name 'testThatSessionCachedResponseHandlerCanModifyCacheResponse' should be between 3 and 40 characters long (58 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CachedResponseHandlerTests.swift:172:5: error: Identifier Name Violation: Function name 'testThatRequestCachedResponseHandlerIsPrioritizedOverSessionCachedResponseHandler' should be between 3 and 40 characters long (81 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CachedResponseHandlerTests.swift:216:5: error: Identifier Name Violation: Function name 'testThatCacheResponseCacherCanBeCreatedStaticallyFromProtocol' should be between 3 and 40 characters long (61 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CachedResponseHandlerTests.swift:221:5: error: Identifier Name Violation: Function name 'testThatDoNotCacheResponseCacherCanBeCreatedStaticallyFromProtocol' should be between 3 and 40 characters long (66 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CachedResponseHandlerTests.swift:226:5: error: Identifier Name Violation: Function name 'testThatModifyResponseCacherCanBeCreatedStaticallyFromProtocol' should be between 3 and 40 characters long (62 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CachedResponseHandlerTests.swift:32:5: warning: Identifier Name Violation: Function name 'testThatRequestCachedResponseHandlerCanCacheResponse' should be between 3 and 40 characters long (52 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CachedResponseHandlerTests.swift:52:5: warning: Identifier Name Violation: Function name 'testThatRequestCachedResponseHandlerCanNotCacheResponse' should be between 3 and 40 characters long (55 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CachedResponseHandlerTests.swift:72:5: warning: Identifier Name Violation: Function name 'testThatRequestCachedResponseHandlerCanModifyCacheResponse' should be between 3 and 40 characters long (58 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:1009:5: warning: Identifier Name Violation: Function name 'testThatNonAutomaticDownloadRequestCanBePublished' should be between 3 and 40 characters long (49 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:1073:5: warning: Identifier Name Violation: Function name 'testThatDownloadRequestCanPublishUnserialized' should be between 3 and 40 characters long (45 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:1115:5: warning: Identifier Name Violation: Function name 'testThatDownloadRequestCanPublishWithMultipleHandlers' should be between 3 and 40 characters long (53 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:1162:5: warning: Identifier Name Violation: Function name 'testThatDownloadRequestCanPublishValueWithFailure' should be between 3 and 40 characters long (49 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:1191:5: warning: Identifier Name Violation: Function name 'testThatPublishedDownloadRequestIsNotResumedUnlessSubscribed' should be between 3 and 40 characters long (60 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:1219:5: error: Identifier Name Violation: Function name 'testThatDownloadRequestCanSubscribedFromNonMainQueueButPublishedOnMainQueue' should be between 3 and 40 characters long (75 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:121:5: warning: Identifier Name Violation: Function name 'testThatDataRequestCanBePublishedUnserialized' should be between 3 and 40 characters long (45 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:1248:5: error: Identifier Name Violation: Function name 'testThatDownloadRequestPublishedOnSeparateQueueIsReceivedOnThatQueue' should be between 3 and 40 characters long (68 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:1277:5: error: Identifier Name Violation: Function name 'testThatDownloadRequestPublishedOnSeparateQueueCanBeReceivedOntoMainQueue' should be between 3 and 40 characters long (73 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:1306:5: warning: Identifier Name Violation: Function name 'testThatPublishedDownloadRequestCanBeCancelledAutomatically' should be between 3 and 40 characters long (59 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:1335:5: warning: Identifier Name Violation: Function name 'testThatPublishedDownloadRequestCanBeCancelledManually' should be between 3 and 40 characters long (54 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:1361:5: warning: Identifier Name Violation: Function name 'testThatMultipleDownloadRequestPublishersCanBeCombined' should be between 3 and 40 characters long (54 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:1391:5: warning: Identifier Name Violation: Function name 'testThatMultipleDownloadRequestPublishersCanBeChained' should be between 3 and 40 characters long (53 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:142:5: warning: Identifier Name Violation: Function name 'testThatDataRequestCanBePublishedWithMultipleHandlers' should be between 3 and 40 characters long (53 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:211:5: warning: Identifier Name Violation: Function name 'testThatDataRequestCanPublishValueWithFailure' should be between 3 and 40 characters long (45 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:240:5: warning: Identifier Name Violation: Function name 'testThatPublishedDataRequestIsNotResumedUnlessSubscribed' should be between 3 and 40 characters long (56 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:268:5: error: Identifier Name Violation: Function name 'testThatDataRequestCanSubscribedFromNonMainQueueButPublishedOnMainQueue' should be between 3 and 40 characters long (71 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:297:5: error: Identifier Name Violation: Function name 'testThatDataRequestPublishedOnSeparateQueueIsReceivedOnThatQueue' should be between 3 and 40 characters long (64 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:326:5: error: Identifier Name Violation: Function name 'testThatDataRequestPublishedOnSeparateQueueCanBeReceivedOntoMainQueue' should be between 3 and 40 characters long (69 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:355:5: warning: Identifier Name Violation: Function name 'testThatPublishedDataRequestCanBeCancelledAutomatically' should be between 3 and 40 characters long (55 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:384:5: warning: Identifier Name Violation: Function name 'testThatPublishedDataRequestCanBeCancelledManually' should be between 3 and 40 characters long (50 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:410:5: warning: Identifier Name Violation: Function name 'testThatMultipleDataRequestPublishersCanBeCombined' should be between 3 and 40 characters long (50 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:440:5: warning: Identifier Name Violation: Function name 'testThatMultipleDataRequestPublishersCanBeChained' should be between 3 and 40 characters long (49 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:506:5: warning: Identifier Name Violation: Function name 'testThatNonAutomaticDataStreamRequestCanBePublished' should be between 3 and 40 characters long (51 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:55:5: warning: Identifier Name Violation: Function name 'testThatNonAutomaticDataRequestCanBePublished' should be between 3 and 40 characters long (45 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:563:5: warning: Identifier Name Violation: Function name 'testThatDataStreamRequestCanPublishString' should be between 3 and 40 characters long (41 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:591:5: warning: Identifier Name Violation: Function name 'testThatDataStreamRequestCanBePublishedWithMultipleHandlers' should be between 3 and 40 characters long (59 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:630:5: warning: Identifier Name Violation: Function name 'testThatDataStreamRequestCanPublishResult' should be between 3 and 40 characters long (41 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:655:5: warning: Identifier Name Violation: Function name 'testThatDataStreamRequestCanPublishResultWithResponseFailure' should be between 3 and 40 characters long (60 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:706:5: warning: Identifier Name Violation: Function name 'testThatDataStreamRequestCanPublishValueWithFailure' should be between 3 and 40 characters long (51 characters) (identifier_name)
⚠️ This PR introduced a violation in Alamofire: /Tests/CombineTests.swift:735:5: error: Identifier Name Violation: Function name 'testThatPublishedDataStreamRequestIsNotResumedUnlessSubscribed' should be between 3 and 40 characters long (62 characters) (identifier_name)
⚠️ Danger found 16580 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 127.
11493 Messages
📖 Linting Aerial with this PR took 1.11s vs 1.11s on main (0% slower)
📖 Linting Alamofire with this PR took 1.43s vs 1.42s on main (0% slower)
📖 Linting Brave with this PR took 8.06s vs 8.09s on main (0% faster)
📖 Linting DuckDuckGo with this PR took 3.93s vs 3.92s on main (0% slower)
📖 Linting Firefox with this PR took 9.5s vs 9.53s on main (0% faster)
📖 Linting Kickstarter with this PR took 10.33s vs 10.28s on main (0% slower)
📖 Linting Moya with this PR took 0.59s vs 0.59s on main (0% slower)
📖 Linting NetNewsWire with this PR took 3.1s vs 3.11s on main (0% faster)
📖 Linting Nimble with this PR took 0.76s vs 0.76s on main (0% slower)
📖 Linting PocketCasts with this PR took 8.0s vs 8.0s on main (0% slower)
📖 Linting Quick with this PR took 0.38s vs 0.38s on main (0% slower)
📖 Linting Realm with this PR took 11.19s vs 11.17s on main (0% slower)
📖 Linting Sourcery with this PR took 2.3s vs 2.3s on main (0% slower)
📖 Linting Swift with this PR took 5.16s vs 5.17s on main (0% faster)
📖 Linting VLC with this PR took 1.39s vs 1.4s on main (0% faster)
📖 Linting Wire with this PR took 8.56s vs 8.56s on main (0% slower)
📖 Linting WordPress with this PR took 12.38s vs 12.36s on main (0% slower)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:53:5: warning: Identifier Name Violation: Variable name 'sw' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:39:5: warning: Identifier Name Violation: Variable name 'dt' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:51:14: warning: Identifier Name Violation: Enum element name 'dt' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:100:5: warning: Identifier Name Violation: Variable name 'dt' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:111:14: warning: Identifier Name Violation: Enum element name 'dt' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:134:5: warning: Identifier Name Violation: Variable name 'dt' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:50:5: warning: Identifier Name Violation: Variable name 'dt' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:62:14: warning: Identifier Name Violation: Enum element name 'dt' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:31:5: warning: Identifier Name Violation: Variable name 'dt' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/Cache.swift:546:44: warning: Identifier Name Violation: Variable name 'at' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:185:17: warning: Identifier Name Violation: Variable name 'cc' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:200:13: warning: Identifier Name Violation: Variable name 'cc' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:85:16: warning: Identifier Name Violation: Variable name 'sb' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/PoiStringProvider.swift:89:20: warning: Identifier Name Violation: Variable name 'sd' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/VideoCache.swift:134:36: warning: Identifier Name Violation: Variable name 'at' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/CustomVideoFolders.swift:145:9: warning: Identifier Name Violation: Variable name 'me' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/CustomVideoFolders.swift:25:9: warning: Identifier Name Violation: Variable name 'me' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/CustomVideoFolders.swift:80:9: warning: Identifier Name Violation: Variable name 'me' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Extensions/AVAsset+VideoOrientation.swift:19:21: warning: Identifier Name Violation: Enum element name 'up' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Hardware/Battery.swift:50:17: warning: Identifier Name Violation: Variable name 'ps' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Hardware/NightShift.swift:52:9: warning: Identifier Name Violation: Variable name 'ts' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Music/Music.swift:114:32: error: Identifier Name Violation: Variable name '_artwork' should only contain alphanumeric and other allowed characters (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Music/Music.swift:36:23: warning: Identifier Name Violation: Variable name 'MRMediaRemoteRegisterForNowPlayingNotificationsPointer' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Models/Music/Music.swift:38:13: warning: Identifier Name Violation: Variable name 'MRMediaRemoteRegisterForNowPlayingNotifications' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/AerialView+Brightness.swift:19:13: warning: Identifier Name Violation: Variable name 'to' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/AerialView.swift:849:46: warning: Identifier Name Violation: Variable name 'to' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Layers/AnimatableLayer.swift:179:9: warning: Identifier Name Violation: Variable name 'mx' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Layers/AnimatableLayer.swift:202:9: warning: Identifier Name Violation: Variable name 'my' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Layers/AnimatableLayer.swift:71:9: warning: Identifier Name Violation: Variable name 'mx' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Layers/AnimatableLayer.swift:72:9: warning: Identifier Name Violation: Variable name 'my' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Layers/AnimationTextLayer.swift:85:9: warning: Identifier Name Violation: Variable name 'mx' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Layers/LocationLayer.swift:84:21: warning: Identifier Name Violation: Variable name 'ts' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Layers/Weather/ConditionSymbolLayer.swift:121:30: warning: Identifier Name Violation: Variable name 'dt' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Layers/Weather/ConditionSymbolLayer.swift:293:18: warning: Identifier Name Violation: Variable name 'dt' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Layers/Weather/ConditionSymbolLayer.swift:86:30: warning: Identifier Name Violation: Variable name 'dt' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Layers/Weather/WeatherLayer.swift:26:13: warning: Identifier Name Violation: Variable name 'fm' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/Layers/Weather/WeatherLayer.swift:59:13: warning: Identifier Name Violation: Variable name 'fm' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/PrefPanel/InfoCommonView.swift:155:16: warning: Identifier Name Violation: Variable name 'fp' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Aerial/Source/Views/PrefPanel/InfoWeatherView.swift:130:9: warning: Identifier Name Violation: Variable name 'fm' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/PanelWindowController.swift:141:43: warning: Identifier Name Violation: Variable name 'to' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Aerial: /Resources/MainUI/Settings panels/BrightnessViewController.swift:52:32: warning: Identifier Name Violation: Variable name 'to' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/AFError.swift:100:33: warning: Identifier Name Violation: Variable name 'at' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/AFError.swift:119:34: warning: Identifier Name Violation: Variable name 'at' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/AFError.swift:35:38: warning: Identifier Name Violation: Variable name 'in' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/AFError.swift:37:39: warning: Identifier Name Violation: Variable name 'at' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/AFError.swift:41:38: warning: Identifier Name Violation: Variable name 'at' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/AFError.swift:43:43: warning: Identifier Name Violation: Variable name 'at' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/AFError.swift:51:44: warning: Identifier Name Violation: Variable name 'at' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/Alamofire.swift:37:8: warning: Identifier Name Violation: Variable name 'AF' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/AlamofireExtended.swift:44:5: warning: Identifier Name Violation: Variable name 'af' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/AlamofireExtended.swift:46:5: warning: Identifier Name Violation: Variable name 'af' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/AlamofireExtended.swift:51:12: warning: Identifier Name Violation: Variable name 'af' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/AlamofireExtended.swift:57:12: warning: Identifier Name Violation: Variable name 'af' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/EventMonitor.swift:618:10: warning: Identifier Name Violation: Variable name 'requestDidFailToCreateURLRequestWithError' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/EventMonitor.swift:621:10: warning: Identifier Name Violation: Variable name 'requestDidAdaptInitialRequestToAdaptedRequest' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/EventMonitor.swift:666:10: warning: Identifier Name Violation: Variable name 'requestDidValidateRequestResponseDataWithResult' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/EventMonitor.swift:672:10: warning: Identifier Name Violation: Variable name 'requestDidValidateRequestResponseWithResult' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/EventMonitor.swift:678:10: warning: Identifier Name Violation: Variable name 'requestDidFailToCreateUploadableWithError' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/EventMonitor.swift:684:10: warning: Identifier Name Violation: Variable name 'requestDidFinishDownloadingUsingTaskWithResult' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/EventMonitor.swift:690:10: warning: Identifier Name Violation: Variable name 'requestDidValidateRequestResponseFileURLWithResult' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/HTTPHeaders.swift:173:23: error: Identifier Name Violation: Variable name 'i' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/NetworkReachabilityManager.swift:278:9: error: Identifier Name Violation: Variable name 'W' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/NetworkReachabilityManager.swift:279:9: error: Identifier Name Violation: Variable name 'R' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/NetworkReachabilityManager.swift:280:9: error: Identifier Name Violation: Variable name 'c' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/NetworkReachabilityManager.swift:281:9: error: Identifier Name Violation: Variable name 't' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/NetworkReachabilityManager.swift:282:9: error: Identifier Name Violation: Variable name 'i' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/NetworkReachabilityManager.swift:283:9: error: Identifier Name Violation: Variable name 'C' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/NetworkReachabilityManager.swift:284:9: error: Identifier Name Violation: Variable name 'D' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/NetworkReachabilityManager.swift:285:9: error: Identifier Name Violation: Variable name 'l' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/NetworkReachabilityManager.swift:286:9: error: Identifier Name Violation: Variable name 'd' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/NetworkReachabilityManager.swift:287:9: error: Identifier Name Violation: Variable name 'a' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/Session.swift:1002:26: error: Identifier Name Violation: Variable name 'r' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/Session.swift:1003:26: error: Identifier Name Violation: Variable name 'r' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/Session.swift:1004:26: error: Identifier Name Violation: Variable name 'r' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Source/Session.swift:1005:26: error: Identifier Name Violation: Variable name 'r' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Tests/AuthenticationInterceptorTests.swift:61:22: warning: Identifier Name Violation: Variable name 'isRequestAuthenticatedWithCredentialCount' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Tests/AuthenticationTests.swift:146:5: error: Identifier Name Violation: Function name '_testHTTPDigestAuthenticationWithInvalidCredentials()' should start with a lowercase character (identifier_name)
📖 This PR fixed a violation in Alamofire: /Tests/AuthenticationTests.swift:172:5: error: Identifier Name Violation: Function name '_testHTTPDigestAuthenticationWithValidCredentials()' should start with a lowercase character (identifier_name)
📖 This PR fixed a violation in Alamofire: /Tests/ParameterEncoderTests.swift:1093:5: error: Identifier Name Violation: Variable name 'a' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Tests/ParameterEncoderTests.swift:1149:5: error: Identifier Name Violation: Variable name 'a' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Tests/ParameterEncoderTests.swift:1150:5: error: Identifier Name Violation: Variable name 'b' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Tests/ParameterEncoderTests.swift:1157:14: error: Identifier Name Violation: Enum element name 'a' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Tests/ParameterEncoderTests.swift:1157:17: error: Identifier Name Violation: Enum element name 'b' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Tests/ParameterEncoderTests.swift:1182:47: error: Identifier Name Violation: Enum element name 'a' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Tests/ProtectedTests.swift:146:63: error: Identifier Name Violation: Variable name 'i' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Tests/ProtectedTests.swift:37:63: error: Identifier Name Violation: Variable name 'i' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Tests/ProtectedTests.swift:52:63: error: Identifier Name Violation: Variable name 'i' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Tests/ProtectedTests.swift:76:63: error: Identifier Name Violation: Variable name 'i' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Tests/ProtectedTests.swift:90:63: error: Identifier Name Violation: Variable name 'i' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Tests/RequestTests.swift:551:64: error: Identifier Name Violation: Variable name 'i' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Tests/ServerTrustEvaluatorTests.swift:79:10: warning: Identifier Name Violation: Enum element name 'leafValidDNSNameWithIncorrectIntermediate' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Tests/SessionTests.swift:334:5: error: Identifier Name Violation: Function name '_testDefaultAcceptEncodingSupportsAppropriateEncodingsOnAppropriateSystems()' should start with a lowercase character (identifier_name)
📖 This PR fixed a violation in Alamofire: /Tests/TestHelpers.swift:178:5: warning: Identifier Name Violation: Variable name 'ip' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Tests/TestHelpers.swift:72:14: warning: Identifier Name Violation: Enum element name 'ip' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Tests/URLProtocolTests.swift:73:50: error: Identifier Name Violation: Variable name 'a' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Alamofire: /Tests/URLProtocolTests.swift:73:67: error: Identifier Name Violation: Variable name 'b' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /App/BraveWidgets/News Topics/NewsTopicsModel.swift:40:15: error: Identifier Name Violation: Variable name 'i' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /App/BraveWidgets/News Topics/NewsTopicsModel.swift:96:15: error: Identifier Name Violation: Variable name 'i' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /App/BraveWidgets/TopNewsWidget.swift:262:11: warning: Identifier Name Violation: Variable name 'df' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Extensions/NSURLExtensionsMailTo.swift:12:10: warning: Identifier Name Violation: Variable name 'to' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Extensions/NSURLExtensionsMailTo.swift:32:5: warning: Identifier Name Violation: Variable name 'to' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Extensions/Rewards/BraveLedgerExtensions.swift:137:61: error: Identifier Name Violation: Variable name 'c' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Extensions/Rewards/BraveLedgerExtensions.swift:150:44: error: Identifier Name Violation: Variable name 'c' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Extensions/Rewards/BraveLedgerExtensions.swift:182:61: error: Identifier Name Violation: Variable name 'c' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Extensions/Rewards/BraveLedgerExtensions.swift:98:37: error: Identifier Name Violation: Variable name 'c' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Brave Notifications/Brave Rewards/RewardsNotification.swift:106:7: warning: Identifier Name Violation: Variable name 'tx' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Brave Notifications/Brave Rewards/RewardsNotification.swift:115:7: warning: Identifier Name Violation: Variable name 'tx' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Brave Notifications/Brave Rewards/RewardsNotification.swift:26:3: warning: Identifier Name Violation: Variable name 'ad' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Brave Notifications/Brave Rewards/RewardsNotification.swift:46:5: warning: Identifier Name Violation: Variable name 'ad' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Brave Notifications/BraveNotificationsPresenter.swift:232:7: warning: Identifier Name Violation: Variable name 'ty' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Brave Notifications/BraveNotificationsPresenter.swift:242:7: error: Identifier Name Violation: Variable name 'y' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Brave Rewards/Ads/AdView.swift:57:28: warning: Identifier Name Violation: Variable name 'tx' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Brave Rewards/Ads/AdsNotificationHandler.swift:73:13: warning: Identifier Name Violation: Variable name 'vc' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Brave Rewards/Ads/AdsNotificationHandler.swift:77:13: warning: Identifier Name Violation: Variable name 'vc' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/BackForwardTableViewCell.swift:68:14: error: Identifier Name Violation: Variable name 's' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1393:15: warning: Identifier Name Violation: Variable name 'vc' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:1599:15: warning: Identifier Name Violation: Variable name 'kp' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:2636:5: warning: Identifier Name Violation: Variable name 'vc' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:2952:5: warning: Identifier Name Violation: Variable name 'vc' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:555:57: warning: Identifier Name Violation: Variable name 'ad' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController.swift:556:34: warning: Identifier Name Violation: Variable name 'ad' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController+Menu.swift:124:9: warning: Identifier Name Violation: Variable name 'vc' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController+Menu.swift:132:9: warning: Identifier Name Violation: Variable name 'vc' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController+Menu.swift:175:9: warning: Identifier Name Violation: Variable name 'vc' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController+Menu.swift:195:5: warning: Identifier Name Violation: Variable name 'vc' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController+Menu.swift:22:49: warning: Identifier Name Violation: Variable name 'vc' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController+Menu.swift:40:9: warning: Identifier Name Violation: Variable name 'vc' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController+Menu.swift:58:49: warning: Identifier Name Violation: Variable name 'vc' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController+Menu.swift:79:9: warning: Identifier Name Violation: Variable name 'vc' should be between 3 and 40 characters long (identifier_name)
📖 This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController+TabManagerDelegate.swift:21:12: warning: Identifier Name Violation: Variable name 'wv' should be between 3 and 40 characters long (identifier_name)
⚠️ Danger found 11493 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 147.

Generated by 🚫 Danger

@mredig mredig marked this pull request as ready for review July 23, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants