truncate debug log output in conformance tests #16117
Merged
+22
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This debug log output can get way too long, and GitHub Actions logs can't even display it anymore when there are test failures. Cut each individual message short, with an escape hatch in case someone wants to run with the full output locally.
tgummerer
added
the
impact/no-changelog-required
Changelog[uncommitted] (2024-05-03) |
Yeah I don't mind having that merged as well. We shouldn't need that output for successful tests in any case. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 6, 2024
Sometimes we show hundreds of repeated messages in the logs, e.g. "waiting for quiescence; 3 outputs outstanding". This just makes the logs harder to read. Since we need to wait for the test to finish before any of this is shown anyway, only log each message once and show a little blurb about how often the message has been repeated. (Note that for simplicity if the last message is repeated we don't show the same blurb, but that should be okay since the last messages we're logging are always different.) Based on #16117 where I noticed this, and I didn't want to rebase it to avoid conflicts.
tgummerer
added a commit
that referenced
this pull request
May 16, 2024
We initially introduced this limit for log messages in #16117. However I've since realized that these log messages also include useful stacktraces (when the program being tested throws an exception), which are a bit longer. The intention here is really to avoid *really* long messages, so increase the maximum message size a little to still avoid those, but allow us to see more of the stacktrace that should hopefully be useful for debugging. The number is mostly still based on a guesstimate of what's useful, but it's easy to tweak if we need to tweak it further.
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 16, 2024
…6213) We initially introduced this limit for log messages in #16117. However I've since realized that these log messages also include useful stacktraces (when the program being tested throws an exception), which are a bit longer. The intention here is really to avoid *really* long messages, so increase the maximum message size a little to still avoid those, but allow us to see more of the stacktrace that should hopefully be useful for debugging. The number is mostly still based on a guesstimate of what's useful, but it's easy to tweak if we need to tweak it further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This debug log output can get way too long, and GitHub Actions logs can't even display it anymore when there are test failures. Cut each individual message short, with an escape hatch in case someone wants to run with the full output locally.
I had a look at the test failure in #16116 and it seems like it's still having the same issue. Looking again at the test output it's actually this t.Log that includes the registered resource outputs, that contains the large amounts of data. I arbitrarily decided to make the cutoff 100 chars, but that could be adjusted.