avoid showing repeated messages #16118
Merged
+28
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgummerer
added
the
impact/no-changelog-required
Changelog[uncommitted] (2024-05-06) |
tgummerer
commented
May 3, 2024
| @@ -66,6 +69,15 @@ func (e *hostEngine) Log(_ context.Context, req *pulumirpc.LogRequest) (*pbempty | |||
| } | |||
| } | |||
|
|
|||
| if e.previousMessage == message { | |||
There was a problem hiding this comment.
We're intentionally using the shortened message here, since we don't want to keep a large amount of data in memory.
lunaris
approved these changes
May 3, 2024
Sometimes we show hundreds of repeated messages in the logs, e.g. "waiting for quiescence; 3 outputs outstanding". This just makes the logs harder to read. Since we need to wait for the test to finish before any of this is shown anyway, only log each message once and show a little blurb about how often the message has been repeated. (Note that for simplicity if the last message is repeated we don't show the same blurb, but that should be okay since the last messages we're logging are always different.)
tgummerer
force-pushed
the
tg/avoid-repeated-messages
branch
from
31c7b5c
to
99692e9
Compare
tgummerer
force-pushed
the
tg/avoid-repeated-messages
branch
from
13516ec
to
9283e49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we show hundreds of repeated messages in the logs, e.g. "waiting for quiescence; 3 outputs outstanding". This just makes the logs harder to read. Since we need to wait for the test to finish before any of this is shown anyway, only log each message once and show a little blurb about how often the message has been repeated.
(Note that for simplicity if the last message is repeated we don't show the same blurb, but that should be okay since the last messages we're logging are always different.)
Based on #16117 where I noticed this, and I didn't want to rebase it to avoid conflicts.