Don't log test results on success #16116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frassle
added
the
impact/no-changelog-required
Changelog[uncommitted] (2024-05-03) |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Looking at the failure in the merge queue here, this doesn't quite do what we want unfortunately. I had another look at the test output, and I think #16117 will solve this. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 6, 2024
This debug log output can get way too long, and GitHub Actions logs can't even display it anymore when there are test failures. Cut each individual message short, with an escape hatch in case someone wants to run with the full output locally. I had a look at the test failure in #16116 and it seems like it's still having the same issue. Looking again at the test output it's actually this t.Log that includes the registered resource outputs, that contains the large amounts of data. I arbitrarily decided to make the cutoff 100 chars, but that could be adjusted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't log the test stdout/err unless it failed. These logs are very verbose and printing them all, all of the time is unproductive for seeing how the failed tests failed.