-
Notifications
You must be signed in to change notification settings - Fork 5.5k
fix(ci): Use PrestoC++ license check script for protocol #26676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the Presto native execution protocol generation script to use the project-local PrestoC++ license header checker instead of the Velox one, decoupling protocol generation from Velox tooling. Flow diagram for special file processing in protocol generationflowchart TD
A["Start processing special file"] --> B["Determine current_class and key"]
B --> C["Set classes[current_class].class_name = current_class"]
C --> D["Call util.run with ../../scripts/license-header.py --header ../../license.header --remove filepath"]
D --> E["Receive status, stdout, stderr"]
E --> F["Set classes[current_class][key] = stdout"]
F --> G["Continue protocol generation"]
G --> H["End"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The protocol generation used the Velox license check script to remove the license headers from special files. But presto-native-execution has its own license check that should be used. This decouples PrestoC++ and Velox.
7ad9c60 to
bd0aab1
Compare
unidevel
approved these changes
Nov 21, 2025
tdcmeehan
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protocol generation used the Velox
license check script to remove the license headers from special files. But presto-native-execution
has its own license check that should be used.
This decouples PrestoC++ and Velox.
Description
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes