Skip to content

Conversation

@amitkdutta
Copy link
Contributor

== NO RELEASE NOTE ==

@amitkdutta amitkdutta requested review from a team as code owners November 20, 2025 17:04
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Nov 20, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 20, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR advances the Velox submodule to the latest upstream commit, updating the local reference and ensuring the build picks up recent fixes and improvements from Velox.

File-Level Changes

Change Details Files
Bump Velox submodule to newest upstream commit
  • Updated git submodule reference to the new commit SHA
  • Checked out the updated Velox repo in presto-native-execution/velox
  • Verified build configuration still points to the Velox directory
presto-native-execution/velox

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

gggrace14
gggrace14 previously approved these changes Nov 20, 2025
@czentgr
Copy link
Contributor

czentgr commented Nov 21, 2025

@amitkdutta Found the issue. PR facebookincubator/velox#15284 added code that inserts an error message to the license-check.py if we want to remove the header. And we are regenerating the protocol in github and so it triggers the message to be added to the output file causing the compile errors.

} // namespace facebook::presto::protocol
::error file = core / special / VariableReferenceExpression.hpp.inc, line = 1,
        endLine = 1,
        title = Missing license header::Please add the properly commented
                    license header.namespace facebook::presto::protocol {

@czentgr
Copy link
Contributor

czentgr commented Nov 21, 2025

@amitkdutta The issue is that it uses the Velox license script which might change behavior for Velox purposes. Presto-native-execution has its own license check and this should be used to remove the header from the special protocol files.
I created PR #26676 to address that.
I included it as a test commit into the current branch.

Edit: PrestoC++ CI is ok now. Only temp issues with some of the Java tests. Removing the test commit. Need to rebase once the fix merges.

@czentgr
Copy link
Contributor

czentgr commented Nov 21, 2025

@amitkdutta The Presto branch was updated and I rebased now. CI should be clean now.

@pramodsatya
Copy link
Contributor

Thanks @amitkdutta, could you please rebase Velox to the latest commit, it would be helpful to include this change.

@gggrace14 gggrace14 self-requested a review November 21, 2025 23:34
@amitkdutta amitkdutta merged commit 4c3cf73 into prestodb:master Nov 21, 2025
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:Meta PR from Meta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants