Skip to content

Commit 608f139

Browse files
authored
fix(ci): Use PrestoC++ license check script for protocol (#26676)
The protocol generation used the Velox license check script to remove the license headers from special files. But presto-native-execution has its own license check that should be used. This decouples PrestoC++ and Velox. ## Description <!---Describe your changes in detail--> ## Motivation and Context <!---Why is this change required? What problem does it solve?--> <!---If it fixes an open issue, please link to the issue here.--> ## Impact <!---Describe any public API or user-facing feature change or any performance impact--> ## Test Plan <!---Please fill in how you tested your change--> ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. - [ ] If adding new dependencies, verified they have an [OpenSSF Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or higher (or obtained explicit TSC approval for lower scores). ## Release Notes ``` == NO RELEASE NOTE == ```
1 parent 7aed5f2 commit 608f139

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

presto-native-execution/presto_cpp/presto_protocol/java-to-struct-json.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ def member_name(name):
169169
def special(filepath, current_class, key, classes, depends):
170170
classes[current_class].class_name = current_class
171171
(status, stdout, stderr) = classes[current_class][key] = util.run(
172-
"../../velox/scripts/checks/license-header.py --header ../../license.header --remove "
172+
"../../scripts/license-header.py --header ../../license.header --remove "
173173
+ filepath
174174
)
175175
classes[current_class][key] = stdout

0 commit comments

Comments
 (0)