[TODO] chore: cleanup done TODOs #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Olshansky <[email protected]>
Co-authored-by: Daniel Olshansky <[email protected]>
…param/proof_request_probability
…param/proof_request_probability
…request_probability * pokt/main: [Proof Module] feat: on-chain proof window validation (#588)
…/579/param/proof_requirement_threshold
…requirement_threshold * pokt/main: [Proof Module] Add `proof_request_probability` param (#593)
Co-authored-by: Daniel Olshansky <[email protected]>
…n-id-validation * pokt/main: [Telemetry] chore: add probabilistic proof telemetry (#605) [E2E] Test REST Relays (#611) [E2E] Make relay feature to wait for the ClaimSettled event (#615) [Tokenomics] feat: add probabilistic proof requirement case (#604) [E2E/Quickfix] Move E2E pre-run script to protocol-infra (#614) [Off-Chain] Add support to REST RPCType (#594) [Dev Tools] Add .devcontainer support (#597) [Relay Mining] Updates to reflect SMT changes (#606)
bryanchriswhite
commented
Jun 20, 2024
bryanchriswhite
commented
Jun 20, 2024
| @@ -15,9 +15,6 @@ func (k msgServer) CreateClaim( | |||
| ctx context.Context, | |||
| msg *types.MsgCreateClaim, | |||
| ) (_ *types.MsgCreateClaimResponse, err error) { | |||
| // TODO_BLOCKER(@bryanchriswhite): Prevent Claim upserts after the ClaimWindow is closed. | |||
| // TODO_BLOCKER(@bryanchriswhite): Validate the signature on the Claim message corresponds to the supplier before Upserting. | |||
There was a problem hiding this comment.
This is guaranteed by the presence of the the cosmos.msg.v1.signer option on the MsgCreateClaim protobuf type.
bryanchriswhite
force-pushed
the
issues/586/todos/session-id-validation
branch
from
287eb78
to
be36e39
Compare
bryanchriswhite
force-pushed
the
issues/586/todos/done
branch
from
ac2fdb4
to
2bb0f1c
Compare
bryanchriswhite
changed the title
15 tasks
…/todos/done * issues/586/todos/session-id-validation: fix: unit test
Olshansk
approved these changes
Jun 20, 2024
bryanchriswhite
changed the base branch from
issues/586/todos/session-id-validation
to
main
bryanchriswhite
added a commit
that referenced
this pull request
Jun 26, 2024
…02/refactor/relayminer * pokt/issues/402/feat/rng: [Code Health] refactor: tx hash encoding (#617) [Docs] Relay session & claim/proof diagrams (#478) Empty commit [Code Health] refactor: block query client interface (#616) [TODO] chore: cleanup done TODOs (#627) [TODOs] chore: cleanup validate session ID TODOs (#608) [LocalNet] Switch to CosmosSDK defaults (#609) [Relay Mining] Emit events and refactor test helpers (#610) [Docs] Minor improvements to `adding_params.md` (#623) [Telemetry] chore: add probabilistic proof telemetry (#605)
bryanchriswhite
added a commit
that referenced
this pull request
Jun 27, 2024
…aim-proof-distribution * issues/402/refactor/relayminer: (21 commits) fix: unflake and speed up tests chore: speed up & improve tests chore: update comments chore: simplify [E2E] Add logging output from the init-container step (#635) fix: failing test Empty commit [Code Health] refactor: random number generation (#618) chore: review improvements chore: review improvments [Code Health] refactor: tx hash encoding (#617) [Docs] Relay session & claim/proof diagrams (#478) Empty commit [Code Health] refactor: block query client interface (#616) chore: review feedback improvements [TODO] chore: cleanup done TODOs (#627) [TODOs] chore: cleanup validate session ID TODOs (#608) [LocalNet] Switch to CosmosSDK defaults (#609) [Relay Mining] Emit events and refactor test helpers (#610) [Docs] Minor improvements to `adding_params.md` (#623) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes TODOs which either are done or will be done once in-review PRs are merged.
Issue
Type of change
Select one or more:
Testing
Documentation changes (only if making doc changes)
make docusaurus_start; only needed if you make doc changesLocal Testing (only if making code changes)
make go_develop_and_testmake test_e2ePR Testing (only if making code changes)
devnet-test-e2elabel to the PR.make trigger_ciif you want to re-trigger tests without any code changesSanity Checklist