Skip to content

Commit

Permalink
chore: cleanup done TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
bryanchriswhite committed Jun 20, 2024
1 parent 287eb78 commit ac2fdb4
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 10 deletions.
2 changes: 0 additions & 2 deletions load-testing/tests/relays_stress_helpers_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -730,7 +730,6 @@ func (plan *actorLoadTestIncrementPlan) shouldIncrementActorCount(
}

initialSessionNumber := testsession.GetSessionNumberWithDefaultParams(startBlockHeight)
// TODO_BLOCKER(@bryanchriswhite): replace with gov param query when available.
actorSessionIncRate := plan.blocksPerIncrement / int64(sharedParams.GetNumBlocksPerSession())
nextSessionNumber := sessionInfo.sessionNumber + 1 - initialSessionNumber
isSessionStartHeight := sessionInfo.blockHeight == sessionInfo.sessionStartBlockHeight
Expand All @@ -757,7 +756,6 @@ func (plan *actorLoadTestIncrementPlan) shouldIncrementSupplierCount(
}

initialSessionNumber := testsession.GetSessionNumberWithDefaultParams(startBlockHeight)
// TODO_BLOCKER(@bryanchriswhite): replace with gov param query when available.
supplierSessionIncRate := plan.blocksPerIncrement / int64(sharedParams.GetNumBlocksPerSession())
nextSessionNumber := sessionInfo.sessionNumber + 1 - initialSessionNumber
isSessionEndHeight := sessionInfo.blockHeight == sessionInfo.sessionEndBlockHeight
Expand Down
2 changes: 0 additions & 2 deletions pkg/relayer/session/session.go
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,6 @@ func (rs *relayerSessionsManager) forEachBlockClaimSessionsFn(
// no longer eligible to be claimed, but that's not always the case.
// Once claim window closing is implemented, they will be filtered out
// downstream at the waitForEarliestCreateClaimsHeight step.
// TODO_BLOCKER(@bryanchriswhite): Introduce governance claim and
// proof window durations, implement off-chain window closing and on-chain window checks.
if sessionGracePeriodEndHeight <= block.Height() {
// Iterate over the sessionsTrees that have grace period ending at this
// block height and add them to the list of sessionTrees to be published.
Expand Down
3 changes: 0 additions & 3 deletions x/proof/keeper/msg_server_create_claim.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ func (k msgServer) CreateClaim(
ctx context.Context,
msg *types.MsgCreateClaim,
) (_ *types.MsgCreateClaimResponse, err error) {
// TODO_BLOCKER(@bryanchriswhite): Prevent Claim upserts after the ClaimWindow is closed.
// TODO_BLOCKER(@bryanchriswhite): Validate the signature on the Claim message corresponds to the supplier before Upserting.

// Declare claim to reference in telemetry.
var claim types.Claim

Expand Down
3 changes: 0 additions & 3 deletions x/proof/keeper/msg_server_submit_proof.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,6 @@ func init() {
// A proof that's stored on-chain is what leads to rewards (i.e. inflation)
// downstream, making the series of checks a critical part of the protocol.
//
// TODO_BLOCKER(@bryanchriswhite): Prevent proof upserts after the tokenomics
// module has processed the respective session.
//
// Note: The entity sending the SubmitProof messages does not necessarily need
// to correspond to the supplier signing the proof. For example, a single entity
// could (theoretically) batch multiple proofs (signed by the corresponding supplier)
Expand Down

0 comments on commit ac2fdb4

Please sign in to comment.