[TODO] @bryanchriswhite's Iteration16 TODOs

[bryanchriswhite]

Objective

Tackle all on-chain blockers assigned to @bryanchriswhite

Origin Document

• [TODO] Team's Iteration16 TODO preparation #577
  

Goals

• Tackle all major TODO's in the codebase assigned to @bryanchriswhite

Deliverables

The output of the following command from #577:

grep -r "TODO_BLOCKER(@bryanchriswhite)" . | sed 's/^/- [ ] `/' | sed 's/:/`:/'

#608

• [TODOs] chore: cleanup validate session ID TODOs #608
• ./x/proof/types/query_validation.go: // TODO_BLOCKER(@bryanchriswhite): Validate the session ID once we have a deterministic way to generate it
• ./x/proof/types/query_validation.go: Msg("TODO_BLOCKER(@bryanchriswhite): Validate the session ID once we have a deterministic way to generate it")
• ./x/proof/types/query_validation.go: // TODO_BLOCKER(@bryanchriswhite): Validate the session ID once we have a deterministic way to generate it
• ./x/proof/types/query_validation.go: Msg("TODO_BLOCKER(@bryanchriswhite): Validate the session ID once we have a deterministic way to generate it")

#627

• [TODO] chore: cleanup done TODOs #627
• ./x/proof/keeper/msg_server_create_claim.go: // TODO_BLOCKER(@bryanchriswhite): Prevent Claim upserts after the ClaimWindow is closed.
• ./x/proof/keeper/msg_server_create_claim.go: // TODO_BLOCKER(@bryanchriswhite): Validate the signature on the Claim message corresponds to the supplier before Upserting.
• ./x/proof/keeper/msg_server_submit_proof.go:// TODO_BLOCKER(@bryanchriswhite): Prevent proof upserts after the tokenomics
• ./pkg/relayer/session/session.go: // TODO_BLOCKER(@bryanchriswhite): Introduce governance claim and
• ./load-testing/tests/relays_stress_helpers_test.go: // TODO_BLOCKER(@bryanchriswhite): replace with gov param query when available.
• ./load-testing/tests/relays_stress_helpers_test.go: // TODO_BLOCKER(@bryanchriswhite): replace with gov param query when available.

#628

• [On-Chain] Refactor grace_period_end_offset_blocks as a shared module param #628
• ./x/shared/types/params.go: // TODO_BLOCKER(@bryanchriswhite): Add SessionGracePeriodBlocks as a shared param,
• ./x/shared/session.go:// TODO_BLOCKER(@bryanchriswhite): This is a place-holder that will be removed

#629

• [On-Chain] Claim/Proof on-chain events #629
• ./e2e/tests/session.feature: # TODO_BLOCKER(@bryanchriswhite): And a cosmos-sdk event (e.g. EventClaimCreated) should be emitted.
• ./e2e/tests/session.feature: # TODO_BLOCKER(@bryanchriswhite): And a cosmos-sdk event (e.g. EventClaimCreated) should be emitted.

#478

• [Docs] Relay session & claim/proof diagrams #478
• ./x/proof/keeper/msg_server_submit_proof.go: TODO_BLOCKER(@bryanchriswhite): Document these steps in proof

---

Creator: @bryanchriswhite

[bryanchriswhite]

Closing despite #629 still being in review as it is tracked by #580