[On-Chain] Refactor `grace_period_end_offset_blocks` as a `shared` module param #628

bryanchriswhite · 2024-06-20T13:03:29Z

Summary

Refactor grace_period_end_offset_blocks as a shared module param

Issue

[TODO] @bryanchriswhite's Iteration16 TODOs #586

Type of change

Select one or more:

Testing

Documentation changes (only if making doc changes)

make docusaurus_start; only needed if you make doc changes

Local Testing (only if making code changes)

Unit Tests: make go_develop_and_test
LocalNet E2E Tests: make test_e2e
See quickstart guide for instructions

PR Testing (only if making code changes)

DevNet E2E Tests: Add the devnet-test-e2e label to the PR.
- THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
- Optionally run make trigger_ci if you want to re-trigger tests without any code changes
- If tests fail, try re-running failed tests only using the GitHub UI as shown here

Sanity Checklist

I have tested my changes using the available tooling
I have commented my code
I have performed a self-review of my own code; both comments & source code
I create and reference any new tickets, if applicable
I have left TODOs throughout the codebase, if applicable

…dule param

Co-authored-by: Daniel Olshansky <[email protected]>

…param/proof_request_probability

…request_probability * pokt/main: [Proof Module] feat: on-chain proof window validation (#588)

…/579/param/proof_requirement_threshold

…requirement_threshold * pokt/main: [Proof Module] Add `proof_request_probability` param (#593)

Co-authored-by: Daniel Olshansky <[email protected]>

…lpers

pkg/client/interface.go

x/shared/keeper/msg_server_update_param_test.go

proto/poktroll/shared/params.proto

config.yml

…period * pokt/main: [Code Health] refactor: random number generation (#618) [Code Health] refactor: tx hash encoding (#617) [Docs] Relay session & claim/proof diagrams (#478) [Code Health] refactor: block query client interface (#616)

Co-authored-by: Daniel Olshansky <[email protected]>

red-0ne

Added a few comments but the changes look good.

My only concern (probably not to be dealt with in this PR) is that (mainly in tests) we're still using grace period for C&P commitments while we should use their respective windows.

tools/scripts/params/shared_all.json

tools/scripts/params/shared_grace_period_end_offset_blocks.json

x/proof/keeper/msg_server_submit_proof_test.go

testutil/keeper/params.go

…period * pokt/main: [Relayminer] off-chain claim/proof message distribution (#619)

red-0ne · 2024-06-28T19:52:44Z

x/shared/types/params.go

@@ -173,3 +177,15 @@ func validateIsUint64(value any) error {

 return nil
 }
+
+func validateClaimWindowOpenOffsetIsAtLeastGracePeriodEndOffset(params *Params) error {


red-0ne

Love the grace period/claim window open enforcement.

Approving.

Change request addressed

…tor+feat * pokt/main: [On-Chain] Refactor `grace_period_end_offset_blocks` as a `shared` module param (#628) [Docs] Add "Session Windows & On-Chain Parameters" section to claim/proof/lifecycle docs (#632)

bryanchriswhite and others added 30 commits June 6, 2024 12:25

refactor: relayminer to use proof_window_open_offset_blocks shared mo…

88e4cd4

…dule param

feat: add on-chain proof window validation

6b6df27

chore: add proof_request_probability proof module param

f105c8c

Merge branch 'main' into issues/516/feat/on-chain-proof-window

54bec5c

chore: review improvements

01fd0d6

Co-authored-by: Daniel Olshansky <[email protected]>

chore: review

6b74295

Co-authored-by: Daniel Olshansky <[email protected]>

Merge branch 'issues/516/feat/on-chain-proof-window' into issues/579/…

1f19a18

…param/proof_request_probability

fix: test error format strings

34d7ffb

Merge branch 'issues/516/feat/on-chain-proof-window' into issues/579/…

d169254

…param/proof_request_probability

fix: param update json

0b53c3f

fix: test types

f8a6f91

chore: regen protobufs

c2f442c

feat: add proof_requirement_threshold proof module param

a4f6ac0

Merge remote-tracking branch 'pokt/main' into issues/579/param/proof_…

de0a5ce

…request_probability * pokt/main: [Proof Module] feat: on-chain proof window validation (#588)

Merge branch 'issues/579/param/proof_request_probability' into issues…

0880826

…/579/param/proof_requirement_threshold

Merge remote-tracking branch 'pokt/main' into issues/579/param/proof_…

c8b7472

…requirement_threshold * pokt/main: [Proof Module] Add `proof_request_probability` param (#593)

chore: self-review

07e0d96

feat: add proof_missing_penalty proof module param

1b8fe2d

refactor: pre-generated-accounts

63963c7

fix: pre-generated-accounts prefix

f0c4d1e

chore: regenerate pre-generated-accounts

65d20f0

chore: review

151c4e3

Co-authored-by: Daniel Olshansky <[email protected]>

chore: self-review

1917db6

refactor: tokenomics keeper tests

66b678c

chore: self-review improvements

87d7c65

fixup! chore: self-review improvements

9fa62e3

test: add coverage for proof required via probability only

f93d42f

feat: add probabilistic proof requirement case when settling

638a31e

refactor: tokenomics keeper tests to use claim/proof window height he…

3c9bf6f

…lpers

test: secureRandomProbability

499588e

bryanchriswhite requested a review from Olshansk June 20, 2024 13:49

bryanchriswhite mentioned this pull request Jun 20, 2024

[TODO] @bryanchriswhite's Iteration16 TODOs #586

Closed

15 tasks

Olshansk previously requested changes Jun 20, 2024

View reviewed changes

pkg/client/interface.go Show resolved Hide resolved

x/shared/keeper/msg_server_update_param_test.go Outdated Show resolved Hide resolved

proto/poktroll/shared/params.proto Show resolved Hide resolved

config.yml Outdated Show resolved Hide resolved

Base automatically changed from issues/586/todos/done to main June 24, 2024 08:25

bryanchriswhite and others added 5 commits June 24, 2024 10:49

Merge branch 'main' into issues/586/param/grace-period

51ceda0

test: refactor unchanged default param assertion helper

d5a6e4c

revert: autoformatting

64755f3

chore: review feedback improvements

fc24457

Co-authored-by: Daniel Olshansky <[email protected]>

bryanchriswhite requested a review from Olshansk June 26, 2024 07:30

wip: chore: review improvements

5289c2e

red-0ne reviewed Jun 27, 2024

View reviewed changes

bryanchriswhite added 2 commits June 27, 2024 14:02

chore: make proto_regen

7bdb1a8

chore: review feedback improvements

4ad41b5

bryanchriswhite requested a review from red-0ne June 27, 2024 13:51

bryanchriswhite added 2 commits June 27, 2024 15:51

Merge branch 'main' into issues/586/param/grace-period

71eff42

Merge branch 'main' into issues/586/param/grace-period

8f800e7

bryanchriswhite linked an issue Jun 27, 2024 that may be closed by this pull request

[TODO] @bryanchriswhite's Iteration16 TODOs #586

Closed

15 tasks

Merge remote-tracking branch 'pokt/main' into issues/586/param/grace-…

77ec3c5

…period * pokt/main: [Relayminer] off-chain claim/proof message distribution (#619)

red-0ne reviewed Jun 28, 2024

View reviewed changes

red-0ne approved these changes Jun 28, 2024

View reviewed changes

Merge branch 'main' into issues/586/param/grace-period

3e71fbb

bryanchriswhite added 4 commits June 28, 2024 23:31

chore: review feedback improvements

abdef7f

Merge branch 'main' into issues/586/param/grace-period

95aee83

fix: failing tests

89afe73

Merge branch 'main' into issues/586/param/grace-period

616089f

bryanchriswhite merged commit e208b42 into main Jun 28, 2024
10 checks passed

bryanchriswhite deleted the issues/586/param/grace-period branch June 28, 2024 22:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[On-Chain] Refactor `grace_period_end_offset_blocks` as a `shared` module param #628

[On-Chain] Refactor `grace_period_end_offset_blocks` as a `shared` module param #628

bryanchriswhite commented Jun 20, 2024 •

edited

Loading

red-0ne left a comment

red-0ne Jun 28, 2024

red-0ne left a comment

[On-Chain] Refactor grace_period_end_offset_blocks as a shared module param #628

[On-Chain] Refactor grace_period_end_offset_blocks as a shared module param #628

Conversation

bryanchriswhite commented Jun 20, 2024 • edited Loading

Summary

Issue

Type of change

Testing

Sanity Checklist

red-0ne left a comment

Choose a reason for hiding this comment

red-0ne Jun 28, 2024

Choose a reason for hiding this comment

red-0ne left a comment

Choose a reason for hiding this comment

[On-Chain] Refactor `grace_period_end_offset_blocks` as a `shared` module param #628

[On-Chain] Refactor `grace_period_end_offset_blocks` as a `shared` module param #628

bryanchriswhite commented Jun 20, 2024 •

edited

Loading