Complete rewrite of get_ovmf_binaries() #164
Merged
+120
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a horrible, unreliable and non-portable hack. Signed-off-by: Marc Herbert <[email protected]>
|
@ikitayama this should help a lot with AAVMF, please try it. |
ikitayama
reviewed
Apr 13, 2025
| qcmd+=("-drive" "if=pflash,format=raw,unit=1,file=OVMF_VARS.fd") | ||
| edk2_vmf_get_images | ||
| qcmd+=("-drive" "if=pflash,format=raw,unit=0,file=${edk2_vmf_code},readonly=on") | ||
| qcmd+=("-drive" "if=pflash,format=raw,unit=1,file=${edk2_vmf_vars}") | ||
| qcmd+=("-debugcon" "file:uefi_debug.log" "-global" "isa-debugcon.iobase=0x402") |
There was a problem hiding this comment.
@marc-hb This is not valid for the "virt" machine. With this fixed.
Tested-by: Itaru Kitayama [email protected]
There was a problem hiding this comment.
Thanks @ikitayama for trying this, much appreciated! As I did not change that line, this looks like a good candidate for a followup PR. Which... you could submit after this one is merged? I tried but I don't have any easy way to test qemu-system-aarch64.
There was a problem hiding this comment.
Nevermind: I will fix this.
There was a problem hiding this comment.
This is not valid for the "virt" machine.
Fix submitted in #166
stellarhopper
approved these changes
Apr 14, 2025
This was referenced Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a horrible, unreliable and non-portable hack.