Skip to content

Add new aamvf_path variable in ubuntu_vars.sh file #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ikitayama
Copy link
Collaborator

Ubuntu's arm64 port, at least 24.10, packages EFI binaries the /usr/share/AAVMF directory. Add a new variable, aavmf_path in ubuntu_vars.sh, depending on the arch, run_qemu.sh can pick up the appropriate "path" to the EFI binaries.

in the /usr/share/AAVMF directory. Add a new variable, aavmf_path
in ubuntu_vars.sh, depending on the arch, run_qemu.sh can pick
up the appropriate "path" to the EFI binaries.
@stellarhopper
Copy link
Member

FWIW, Fedora has:

$ ls -l /usr/share/AAVMF
total 12
lrwxrwxrwx. 1 root root 42 Nov 26 17:00 AAVMF_CODE.fd -> ../edk2/aarch64/QEMU_EFI-silent-pflash.raw
lrwxrwxrwx. 1 root root 35 Nov 26 17:00 AAVMF_CODE.verbose.fd -> ../edk2/aarch64/QEMU_EFI-pflash.raw
lrwxrwxrwx. 1 root root 40 Nov 26 17:00 AAVMF_VARS.fd -> ../edk2/aarch64/vars-template-pflash.raw

$ ls -l /usr/share/edk2/aarch64/
total 208444
-rw-r--r--. 1 root root  2097152 Nov 26 17:00 QEMU_EFI.fd
-rw-r--r--. 1 root root  2097152 Nov 26 17:00 QEMU_EFI.kernel.fd
-rw-r--r--. 1 root root  2117632 Nov 26 17:00 QEMU_EFI-pflash.qcow2
-rw-r--r--. 1 root root 67108864 Nov 26 17:00 QEMU_EFI-pflash.raw
-rw-r--r--. 1 root root  2097152 Nov 26 17:00 QEMU_EFI.silent.fd
-rw-r--r--. 1 root root  2117632 Nov 26 17:00 QEMU_EFI-silent-pflash.qcow2
-rw-r--r--. 1 root root 67108864 Nov 26 17:00 QEMU_EFI-silent-pflash.raw
-rw-r--r--. 1 root root   786432 Nov 26 17:00 QEMU_VARS.fd
-rw-r--r--. 1 root root   806912 Nov 26 17:00 vars-template-pflash.qcow2
-rw-r--r--. 1 root root 67108864 Nov 26 17:00 vars-template-pflash.raw

We should probably update the _vars files for all distros, so that the script has a reasonable chance of working everywhere once the new arm option is implemented and added.

@ikitayama
Copy link
Collaborator Author

Could this be pulled, as this does not affect Intel badly, it's an addition of a new variable.

@marc-hb
Copy link
Collaborator

marc-hb commented Apr 2, 2025

I know I asked for smaller PRs in #140 but this might be taking it a bit "too far". I think it's better to add such variables and one-liners in the same PR where they are actually used.

Moreover, let's finalize the "arch-framework" in #143 first.

@ikitayama
Copy link
Collaborator Author

Okay.

@marc-hb
Copy link
Collaborator

marc-hb commented Apr 14, 2025

Superseded by #164, thank you for testing the latter.

@marc-hb marc-hb closed this Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants