Skip to content

Add a new function get_aavmf_binaries() #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ikitayama
Copy link
Collaborator

so that EFI binaries are copied over to the build directory if they are located in /usr/share/AAVMF.

directory is they are located in /usr/share/AAVMF.
@ikitayama ikitayama requested a review from stellarhopper as a code owner April 2, 2025 07:47
fi
if ! [ -e "AAVMF_CODE.fd" ] && ! [ -e "AAVMF_VARS.fd" ]; then
if [ ! -f "$aavmf_path/AAVMF_CODE.fd" ]; then
echo "AAVMF binaries not found, please install '[edk2-]ovmf' or similar, 'edk2-shell', ..."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this package suggestion cannot just be copied, it probably needs to be adjusted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, for Fedora this would be edk2-aarch64.

@marc-hb
Copy link
Collaborator

marc-hb commented Apr 10, 2025

@ikitayama please hold off with this as I'd like to clean up get_ovmf_binaries() first. I've been using ugly hacks to make it work across Fedora, Arch Linux, Ubuntu 22 and 24 and I'd like to get rid of these. This should help with AAVMF - I'll keep it in mind.

@marc-hb marc-hb marked this pull request as draft April 10, 2025 02:18
@ikitayama
Copy link
Collaborator Author

@ikitayama please hold off with this as I'd like to clean up get_ovmf_binaries() first. I've been using ugly hacks to make it work across Fedora, Arch Linux, Ubuntu 22 and 24 and I'd like to get rid of these. This should help with AAVMF - I'll keep it in mind.

It's your call, I understand.

@marc-hb
Copy link
Collaborator

marc-hb commented Apr 14, 2025

Superseded by #164, thank you for testing the latter.

@marc-hb marc-hb closed this Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants