Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree: automatically remove intermediate files with option to disable clean up #1723

Open
joverlee521 opened this issue Jan 15, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@joverlee521
Copy link
Contributor

Originally discussed in Slack with @huddlej

Currently, augur tree automatically removes intermediate tree builder files within each tree building function. The tree building functions all default to clean_up=True, but do not expose this as a CLI option so users cannot disable the clean up. On the other hand, the Augur specific intermediate files, masked_alignment_file and informative_sites, are never cleaned up. These can be confused as "outputs" of the command that are then mistakenly used for downstream analysis.

Ideally, all intermediate files are cleaned up by default and there's a CLI option to disable the clean up (e.g. --no-clean-up) for debugging purposes.

@joverlee521 joverlee521 added the enhancement New feature or request label Jan 15, 2025
@tsibley
Copy link
Member

tsibley commented Jan 15, 2025

I'd add that besides a CLI option, this is the sort of thing where an environment variable is super handy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants