Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As of django-filer 3.0 mptt is not needed as a dependency #224 #226

Merged
merged 3 commits into from
Jul 9, 2023

Conversation

yakky
Copy link
Member

@yakky yakky commented Jul 9, 2023

Description

Describe:

  • This PR only automatically adds mptt to INSTALLED_APPS for django-filer, if the installed version of django-filer is below 3.0.
  • django-filer as of version 3.0 does not depend on mptt any more.
  • Without this change, a ModuleNotFound exception will be raised in an environment without mptt

References

Fix #225

Fix #224

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.24 ⚠️

Comparison is base (195e4a6) 92.57% compared to head (efee403) 92.34%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #226      +/-   ##
===========================================
- Coverage    92.57%   92.34%   -0.24%     
===========================================
  Files            9        9              
  Lines          795      797       +2     
  Branches       125      126       +1     
===========================================
  Hits           736      736              
- Misses          22       23       +1     
- Partials        37       38       +1     
Flag Coverage Δ
unittests 92.34% <33.33%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app_helper/utils.py 92.97% <33.33%> (-0.78%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not add mptt in INSTALLED_APPS for django-filter 3
2 participants