Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: As of django-filer 3.0 mptt is not needed as a dependency #224

Closed
wants to merge 3 commits into from

Conversation

fsbraun
Copy link
Contributor

@fsbraun fsbraun commented Jun 19, 2023

Description

Describe:

  • This PR only automatically adds mptt to INSTALLED_APPS for django-filer, if the installed version of django-filer is below 3.0.
  • django-filer as of version 3.0 does not depend on mptt any more.
  • Without this change, a ModuleNotFound exception will be raised in an environment without mptt

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

@fsbraun fsbraun changed the title fix: As of django-fixer 3.0 mptt is not needed as a dependency fix: As of django-filer 3.0 mptt is not needed as a dependency Jun 21, 2023
@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.24 ⚠️

Comparison is base (1bba8eb) 92.68% compared to head (264b1bd) 92.45%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #224      +/-   ##
===========================================
- Coverage    92.68%   92.45%   -0.24%     
===========================================
  Files            9        9              
  Lines          793      795       +2     
  Branches       124      125       +1     
===========================================
  Hits           735      735              
- Misses          22       23       +1     
- Partials        36       37       +1     
Flag Coverage Δ
unittests 92.45% <33.33%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app_helper/utils.py 92.97% <33.33%> (-0.78%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yakky yakky closed this in #226 Jul 9, 2023
yakky added a commit that referenced this pull request Jul 9, 2023
* Update utils.py


---------

Co-authored-by: Fabian Braun <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@yakky
Copy link
Member

yakky commented Jul 9, 2023

@fsbraun thanks, I merged it with #226 and released version 3.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants