Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As of django-filer 3.0 mptt is not needed as a dependency #224 #226

Merged
merged 3 commits into from
Jul 9, 2023
Merged

As of django-filer 3.0 mptt is not needed as a dependency #224 #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ded194c
Update utils.py
fsbraun Jun 19, 2023
fa9d1fb
auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 19, 2023
efee403
Add towncrier file
yakky Jul 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app_helper/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,11 @@ def _make_settings(args, application, settings, STATIC_ROOT, MEDIA_ROOT): # NOQ
if "treebeard" not in default_settings["INSTALLED_APPS"]:
default_settings["INSTALLED_APPS"].append("treebeard")
if "filer" in default_settings["INSTALLED_APPS"] and "mptt" not in default_settings["INSTALLED_APPS"]:
default_settings["INSTALLED_APPS"].append("mptt")
from filer import __version__

if __version__ < "3":
# As of django-filer 3.0 mptt is not needed as a dependency
default_settings["INSTALLED_APPS"].append("mptt")
if "filer" in default_settings["INSTALLED_APPS"] and "easy_thumbnails" not in default_settings["INSTALLED_APPS"]:
default_settings["INSTALLED_APPS"].append("easy_thumbnails")

Expand Down
1 change: 1 addition & 0 deletions changes/225.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Do not add mptt with django-filer 3+