Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor GetFullText() #2587

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

certuna
Copy link
Contributor

@certuna certuna commented Nov 6, 2023

For some reason the mf.FullText and a.FullText fields are populated inside the sql Put() functions in the artist/mediafile repository code instead of where all other mf.* and a.* fields are populated.
Also, the getFullText() function used in Put() is not used for a.FullText in model/media_file.go

This refactoring:

  • moves getFullText() ands its test into utils/sanitize_strings.go
  • populates mf.FullText in scanner/mapping.go along with the rest of the mf.* fields
  • populates a.FullText in album.go along with the rest along with the rest of the a.* fields
  • uses the GetFullText() function also for a.FullText in model/media_file.go

Copy link

github-actions bot commented Nov 6, 2023

Download the artifacts for this pull request:

@deluan
Copy link
Member

deluan commented Nov 11, 2023

Also, the getFullText() function used in Put() is not used for a.FullText in model/media_file.go

There was a reason for that, I just don't remember what... I'll have to take a careful look at this before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants