Create artist objects for Artists without albums #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbumArtistsOnly server option
- rename a.* to al.* to reduce confusion - add ToArtist() - make Artist blank in fixAlbumArtist()
fix test for aggregating Size
change ToAlbumArtist() so that it doesn't add Size, as this is now done in ToArtist()
fix SongCount test due to changes in the ToAlbumArtist() function
change purgeEmpty() to only delete when artist has neither albums nor tracks.
remove removeNonAlbumArtistIds(), not needed anymore
removeNonAlbumArtistIds() not needed anymore
adds refreshSongArtists()
Change test for new fixAlbumArtist() function
revert change
Revert change in fixAlbumArtist(), not for this PR
|
Download the artifacts for this pull request: |
swap functions for easier comparison
certuna
changed the title
|
This is great! I really need it |
3 tasks
|
Please merge it already.. let 0.50.2 be a thing.. |
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates an Artist object in the DB for all artists (track artists & album artists). This makes all artists "clickable", even if they have no albums. This allows the user to read the biography, see which albums the artist is featured on, click through to last.fm & Musicbrainz, etc.
Adds a server option
AlbumArtistsOnlyto either display all artists, or just those with albums. Default istruewhich is current behaviour: I know a lot of users when they click on "Artists" don't want to see a huge list populated with artists without albums.Note: conflicts with #2587 and #2524