Multiple artist support #2524

certuna · 2023-09-16T12:47:38Z

Closes #238 and #277

Adds support for multiple artists. There are three commonly used methods to tag these, this PR support all three:

Using the official multi-artist support in tags: null-separated strings in id3v2.4 (Jay-Z<null>Kanye West), multiple ARTIST fields in FLAC/MP4 (ARTIST = Jay-Z, ARTIST = Kanye West)
Single string with non-standard separator, usually semicolon: ARTIST = Jay-Z;Kanye West
ARTISTS/ARTIST method used by MusicBrainz Picard: multi-valued ARTISTS (Jay-Z<null>Kanye West), singlevalued ARTIST (Jay-Z & Kanye West) for backwards compatibility

How this PR works in the Navidrome DB mediafile and album tables:

artist and album_artist are formed by concatenating multiple artists: Jay-Z · Kanye West
artist_id is populated with the id of the first artist 0e37575446e8659caa9f2a3e298afc86, i.e. clicking on Jay-Z · Kanye West will take you to the artist page of Jay-Z
all_artist_ids has the ids of all artists: 0e37575446e8659caa9f2a3e298afc86 0b48849166b97b6b053a0e1e5e131231, this makes the songs/albums show up in the artist discography
all artist names added to full_text, so available for search

Three new config options (we can drop some of them if we deem them good enough to stay enabled all the time):

Scanner.MultipleArtists (default true): if false, only the first artist in the tags is used.
Scanner.ArtistSeparators (default ;): just like Scanner.GenreSeparators
Scanner.RemixerToArtist (default true): this does what Spotify does: reads the Remixer tag and treats it as an additional Artist.

I've been testing this for over three months now, it's pretty solid. Open issues:

Dependencies/conflicts

Artist discography sorted own-albums-first #2580 is not strictly necessary but if we don't do it the discographies of artists with lots of compilation tracks and guest appearances/collabs will become a mess
Create artist objects for non-Album Artists #2583 is not strictly necessary but allows users to browse artists that have no albums but a lot of compilation tracks or guest appearances/collabs
Split albums by MusicBrainz Album ID #2538 is independent but conflicts with one line in scanner/mapping.go
refactor GetFullText() #2587 is independent but has conflicts

Subsonic clients

Mainly around "Go to {track artist}" functionality, where you can navigate to the artist of a song. None of them are showstoppers in my opinion. I've been cross-referencing the behaviour with LMS, another Subsonic server that supports multiple artists.

Substreamer: works as expected, with s small cosmetic hiccup:if you Go To Artist Jay-Z · Kanye West, it takes you to Jay-Z's discography, but still displays the Jay-Z · Kanye West artist name - probably only needs a small fix on the Substreamer side to refresh the artist name after the clickthrough. For comparison, LMS does not provide an ArtistID for tracks with multiple artists, so Go To Artist isn't possible at all
Play:Sub: Go To Artist gives an error, with both Navidrome and LMS. Seems it doesn't use the ArtistID, but does a lookup for up the Artist Name Jay-Z · Kanye West, which fails in both cases
Amperfy: It displays the first artist, so it looks like it split on the middle dot clients side. Go To Artist works correctly, without errors. For comparison: when clicking Go To Artist, LMS gives API Error but does seem to load the discography.
Supersonic: no issues
Sonixd: no issues
Feishin: no issues
Other subsonic clients?

Web UI Cosmetics

Since the artistID of the track only links to the first artist, clicking on the Jay-Z · Kanye West link in the WebUI will always take you to the artist page of Jay-Z, ideally the WebUI would make this clearer to the user by only hyperlinking Jay-Z, not the other artists. It's mainly cosmetic, but if we dislike it enough, someone with more JavaScript skills than me would have to take a look a this. At the moment this PR is 100% serverside.

Sort by Artist = Album Artist first, so it shows an artist's own albums first, and appearances on other albums second.

Alias match_album_artist, allows for sorting by an artist's own albums first, then his appearances on compilations/etc.

forgot args in line 89

prettier

reformatted

removed comment about Subsonic, it's irrelevant since this query is never done through the Subsonic API.

merge upstream changes

updated with multi-artist tags

Add function to remove duplicate values but keep the order intact

Add test for RemoveDuplicateStr()

fix AlbumID()

tab screws up lint

certuna · 2023-11-05T16:56:29Z

Cleaned it all up, tests all clear, ready to merge I think. OpenSubsonic support is better done in a separate PR.

fix test

RubenTeixeira · 2023-11-12T22:49:33Z

Hey @certuna , thanks for your work.

I'm getting this when using this PR:

Nov 12 22:47:35 raspberrypi navidrome[16356]: time="2023-11-12T22:47:35Z" level=fatal msg="Failed to apply new migrations" error="error: found 1 missing migrations:\n\tversion 20230615000000: /github/workspace/db/migration/20230615000000_add_all_artist_ids_to_mediafile.go"

What is missing?

certuna · 2023-11-15T10:17:57Z

Hey @certuna , thanks for your work.

I'm getting this when using this PR:

Nov 12 22:47:35 raspberrypi navidrome[16356]: time="2023-11-12T22:47:35Z" level=fatal msg="Failed to apply new migrations" error="error: found 1 missing migrations:\n\tversion 20230615000000: /github/workspace/db/migration/20230615000000_add_all_artist_ids_to_mediafile.go"

What is missing?

Ah yes I'll fix this, there have been new additions to the codebase so my migration is outdated.

RubenTeixeira · 2023-11-15T15:30:23Z

Ah yes I'll fix this, there have been new additions to the codebase so my migration is outdated.

Thank you so much! Looking forward to trying it out :)

…o 20231116000000_add_all_artist_ids_to_mediafile.go fix migration

fix migration

certuna · 2023-11-16T11:56:45Z

Ah yes I'll fix this, there have been new additions to the codebase so my migration is outdated.

Thank you so much! Looking forward to trying it out :)

Should work now. I don't know if this PR will be merged soon or if we wait until we can do it all together with OpenSubsonic API support.

RubenTeixeira · 2023-11-16T16:59:20Z

Should work now. I don't know if this PR will be merged soon or if we wait until we can do it all together with OpenSubsonic API support.

Yes it does! Looking good. Will keep happily testing and report if I find any incident.
Yeah I'm very excited for all the OpenSubsonic stuff. Can't wait :)

kobayashi90 · 2023-12-02T15:31:41Z

approve this and make 0.50.2 happen..

tty228 · 2023-12-21T17:45:08Z

The number of tracks for each individual singer in a choir cannot be displayed correctly at the moment. This issue is likely related to the fact that the artistID of a track is only linked to the first artist. Additionally, it would be great if hyperlinks could be selected for ensemble singers.

TacoCake · 2024-01-09T14:12:39Z

Hey, what's holding this PR back? Does it still need contributions?

RubenTeixeira · 2024-01-09T14:14:48Z

Hey, what's holding this PR back? Does it still need contributions?

Perhaps it's the fact that the author did not prepare support for OpenSubSonic API. It works great otherwise. I'm also looking forward for this.

dweymouth · 2024-01-09T16:12:34Z

Hey, what's holding this PR back? Does it still need contributions?

From conversations on Discord it's that this PR kind of "hacks" around the existing DB schema, whereas Deluan now prefers to redesign the database schema "properly" for the many-to-many relationships between artists and albums. So this PR will likely get scrapped in favor of a larger-scale database redesign. But this is a good thing as doing it right at the database level will probably be more performant and enable future extensions more easily.

TacoCake · 2024-01-09T16:29:03Z

Hey, what's holding this PR back? Does it still need contributions?

From conversations on Discord it's that this PR kind of "hacks" around the existing DB schema, whereas Deluan now prefers to redesign the database schema "properly" for the many-to-many relationships between artists and albums. So this PR will likely get scrapped in favor of a larger-scale database redesign. But this is a good thing as doing it right at the database level will probably be more performant and enable future extensions more easily.

Ah, I see, thanks for the info. Is there anywhere I can track this?

certuna added 30 commits June 27, 2023 10:37

Update ArtistShow.js

194a85c

Sort by Artist = Album Artist first, so it shows an artist's own albums first, and appearances on other albums second.

Update album_repository.go

6eb9f02

Alias match_album_artist, allows for sorting by an artist's own albums first, then his appearances on compilations/etc.

Update album_repository.go

df704ee

forgot args in line 89

Update ArtistShow.js

6150f26

prettier

Update ArtistShow.js

b45060a

prettier

Update album_repository.go

831f5fb

reformatted

Update album_repository.go

bb735a6

removed comment about Subsonic, it's irrelevant since this query is never done through the Subsonic API.

Merge pull request #6 from navidrome/master

7b3839c

merge upstream changes

Update configuration.go

d8f5367

Update agent.go

11d44b3

Update agent.go

94f2c61

Create 20230615000000_add_all_artist_ids_to_mediafile.go

4975032

Update album.go

c50cf98

Update album_test.go

e7d6898

Update mediafile_test.go

69520c9

Update mediafile.go

cad2e85

Update album_repository.go

1a3386f

Update artist_repository.go

28b3c1b

Update mediafile_repository.go

ab9bec2

Update persistence.go

652391b

Update taglib.go

77e9bd4

Update metadata.go

5c1b1c4

Update metadata_test.go

5217331

Update metadata_internal_test.go

0cdf443

Update mapping_internal_test.go

c84b1df

Update mapping.go

90af5a9

Update refresher.go

25412fd

Add files via upload

e549133

updated with multi-artist tags

RemoveDuplicateStr()

4f453f9

Add function to remove duplicate values but keep the order intact

RemoveDuplicateStr()

cae3b46

Add test for RemoveDuplicateStr()

certuna added 2 commits November 5, 2023 17:35

Update mapping.go

75789fe

fix AlbumID()

Update mapping.go

f8880fe

tab screws up lint

certuna mentioned this pull request Nov 7, 2023

Create artist objects for Artists without albums #2583

Open

Merge branch 'navidrome:master' into multi-artists

a774f60

certuna mentioned this pull request Nov 9, 2023

Classical music metadata support #2601

Open

certuna added 4 commits November 12, 2023 15:55

Update mapping_internal_test.go

9051b52

fix test

Merge branch 'navidrome:master' into multi-artists

85c8fb9

remove unneeded tests

f2b8944

formatting

3ea7efa

certuna added 3 commits November 16, 2023 12:45

Merge branch 'navidrome:master' into multi-artists

84b5f09

Update and rename 20230615000000_add_all_artist_ids_to_mediafile.go t…

d6f5dbc

…o 20231116000000_add_all_artist_ids_to_mediafile.go fix migration

Update 20231116000000_add_all_artist_ids_to_mediafile.go

e1a72b7

fix migration

metalheim mentioned this pull request Nov 17, 2023

[Bug]: Music files with multiple artists will only display the first artist. #2623

Closed

3 tasks

certuna added 2 commits November 23, 2023 00:20

Merge branch 'navidrome:master' into multi-artists

8ba2faa

Merge branch 'navidrome:master' into multi-artists

6157f33

certuna added 2 commits December 3, 2023 18:25

Merge branch 'navidrome:master' into multi-artists

b5becbe

Merge branch 'navidrome:master' into multi-artists

69929c9

deluan force-pushed the master branch from b6c4d97 to 2470471 Compare May 6, 2024 19:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiple artist support #2524

Multiple artist support #2524

certuna commented Sep 16, 2023 •

edited

certuna commented Nov 5, 2023 •

edited

RubenTeixeira commented Nov 12, 2023

certuna commented Nov 15, 2023

RubenTeixeira commented Nov 15, 2023

certuna commented Nov 16, 2023

RubenTeixeira commented Nov 16, 2023

kobayashi90 commented Dec 2, 2023

tty228 commented Dec 21, 2023

TacoCake commented Jan 9, 2024

RubenTeixeira commented Jan 9, 2024

dweymouth commented Jan 9, 2024

TacoCake commented Jan 9, 2024

Multiple artist support #2524

Are you sure you want to change the base?

Multiple artist support #2524

Conversation

certuna commented Sep 16, 2023 • edited

Dependencies/conflicts

Subsonic clients

Web UI Cosmetics

certuna commented Nov 5, 2023 • edited

RubenTeixeira commented Nov 12, 2023

certuna commented Nov 15, 2023

RubenTeixeira commented Nov 15, 2023

certuna commented Nov 16, 2023

RubenTeixeira commented Nov 16, 2023

kobayashi90 commented Dec 2, 2023

tty228 commented Dec 21, 2023

TacoCake commented Jan 9, 2024

RubenTeixeira commented Jan 9, 2024

dweymouth commented Jan 9, 2024

TacoCake commented Jan 9, 2024

certuna commented Sep 16, 2023 •

edited

certuna commented Nov 5, 2023 •

edited