chore(kad): remove unrequired generics #5476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we don't ever abstract over it, it's always parametrized to QueryInner
libp2p-core should aim to be thinier, see libp2p#3072 (reply in thread)
and rather create a new struct QueryPeers which should aim to have all the shared properties of the 3 different query types: Fixed, Closed, and ClosedDisjoint
guillaumemichel
approved these changes
Jun 25, 2024
|
cc @Wiezzel for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the unrequired generics in
kadand refactor the code for less duplication.Please review by commit order as it will be easier to understand each commit's rational and logic