Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kad): changelog #5478

Merged
merged 3 commits into from
Jun 25, 2024
Merged

fix(kad): changelog #5478

merged 3 commits into from
Jun 25, 2024

Conversation

guillaumemichel
Copy link
Contributor

Description

Correct kad changelog after #5475

kad 0.46.0 isn't released yet, hence changelog entry from #5475 will be published with 0.46.0.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

cc: @Wiezzel @stormshield-frb @jxs

@guillaumemichel guillaumemichel changed the title correct kad changelog after #5475 feat(kad): changelog Jun 25, 2024
@guillaumemichel guillaumemichel changed the title feat(kad): changelog fix(kad): changelog Jun 25, 2024
jxs
jxs approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gui!

protocols/kad/CHANGELOG.md Outdated Show resolved Hide resolved
@stormshield-frb
Copy link
Contributor

Should we not also update the Cargo.toml files ?

@stormshield-frb
Copy link
Contributor

And libp2p-core is also concerned. I don't know if you plan to do this in the same PR or another PR ?

@guillaumemichel
Copy link
Contributor Author

And libp2p-core is also concerned. I don't know if you plan to do this in the same PR or another PR ?

@stormshield-frb libp2p-core will be addressed by #5476

@mergify mergify bot merged commit d1025d2 into master Jun 25, 2024
72 checks passed
@mergify mergify bot deleted the fix/kad-changelog branch June 25, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guillaumemichel @stormshield-frb @jxs