Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(kad): remove unrequired generics #5476

Merged
merged 7 commits into from
Jun 27, 2024
Merged

chore(kad): remove unrequired generics #5476

merged 7 commits into from
Jun 27, 2024

Commits on Jun 24, 2024

  1. remove Query and QueryPool generic Tinner 

    we don't ever abstract over it, it's always parametrized to QueryInner
    @jxs
    jxs committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    074fc5a View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. remove exposure of QueryInner to Behaviour

    @jxs
    jxs committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    6d2e115 View commit details
    Browse the repository at this point in the history

  2. remove QueryInner

    @jxs
    jxs committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    1ac1c1e View commit details
    Browse the repository at this point in the history

  3. move PeerInfo out of libp2p-core, 

    libp2p-core should aim to be thinier, see libp2p#3072 (reply in thread)
    @jxs
    jxs committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    a2514f0 View commit details
    Browse the repository at this point in the history

  4. deprecate QueryResult 

    and rather create a new struct QueryPeers which should aim to have all the shared properties of the
3 different query types: Fixed, Closed, and ClosedDisjoint
    @jxs
    jxs committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    a37fe3a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into cleanup-kad-2

    @jxs
    jxs committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    186723c View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Merge branch 'master' into cleanup-kad-2

    @jxs
    jxs committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    ec7837c View commit details
    Browse the repository at this point in the history