Add charts repo

[lerrigatto]

What this PR does / why we need it:

This PR creates a repo for help charts, as discussed here: kubevirt/community#224

Special notes for your reviewer: That's my first PR here!

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

• Design: A design document was considered and is present (link) or not required: Add Helm charts proposal community#224
• PR: The PR description is expressive enough and will help future contributors
• Code: Write code that humans can understand and Keep it simple
• Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
• Upgrade: Impact of this change on upgrade flows was considered and addressed if required
• Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
• Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
• Community: Announcement to kubevirt-dev was considered

Release note:

NONE

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request adds a new repository named 'charts' to the organization configuration. This repository is intended to house Helm charts for KubeVirt.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Added a new 'charts' repository to the organization configuration.	Added a 'charts' entry under the 'orgs' section. Set the description for the 'charts' repo to 'Helm charts for KubeVirt'.	github/ci/prow-deploy/kustom/base/configs/current/orgs/orgs.yaml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[kubevirt-bot]

Hi @lerrigatto. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sourcery-ai]

Hey @lerrigatto - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding a link to the charts repo in the org description.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[dhiller]

/test ?

[kubevirt-bot]

@dhiller: The following commands are available to trigger required jobs:

/test build-autoowners-image

/test build-bootstrap-image

/test build-fedora-coreos-kubevirt-image

/test build-kubekins-e2e-image

/test build-kubevirt-infra-bootstrap-image

/test build-kubevirt-kubevirt.github.io-image

/test build-kubevirt-user-guide-image

/test build-pr-creator-image

/test build-prow-deploy-image

/test build-release-tool-image

/test build-shared-images-controller-image

/test build-test-label-analyzer-image

/test build-test-subset-image

/test build-vm-image-builder-image

/test check-prow-config

/test pull-kubevirt-org-github-config-updater

/test pull-project-infra-check-testgrid-config

/test pull-project-infra-ci-search-deploy-test

/test pull-project-infra-coverage

/test pull-project-infra-grafana-deploy-test

/test pull-project-infra-job-config-validator

/test pull-project-infra-lint

/test pull-project-infra-prow-deploy-test

/test pull-project-infra-test-external-plugins

/test pull-project-infra-test-github-ci-services

/test pull-project-infra-test-releng

/test pull-project-infra-test-robots

/test pull-prow-kubevirt-labels-update-precheck

/test pull-prow-nmstate-labels-update-precheck

Use /test all to run the following jobs that were automatically triggered:

check-prow-config

pull-kubevirt-org-github-config-updater

pull-project-infra-lint

pull-project-infra-prow-deploy-test

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dhiller]

/test pull-kubevirt-org-github-config-updater

[alagoutte]

Hi,

What missing for merge this change ?

[lerrigatto]

Ping @dhiller is this good?
Then the real work on building the chart can start!

[dhiller]

@lerrigatto apologies for the delay. Repo creation looks good to me. However, a blank repository doesn't get you very far.

In general we have a group of maintainers that take ownership of a repo. Therefore this PR is missing creation of a GitHub team that would contain you as maintainer. See this PR as an example.

Also the maintainers need to be onboarded to the KubeVirt GitHub organization (example #4152)

Before that happens every new member has to go through this process: https://github.com/kubevirt/community/blob/main/membership_policy.md#member

Please bear with us on this - KubeVirt org members receive certain privileges i.e. automatic CI runs etc - so we need to make sure every one goes through this.

So the path forward I'd suggest would be:

• Create a membership PR as described in the docs above, referencing this PR so people know why, and
• either update this PR to add a maintainers GitHub team that has write access to the repository
• or update this PR configuring prow merge automation as described here: https://github.com/kubevirt/community/blob/main/docs/add-merge-automation-to-your-repository.md

[dhiller]

@lerrigatto I'd be happy to sponsor you on the KubeVirt org membership PR

[dhiller]

@lerrigatto not sure whether you are still working on this - however I thought I'd give you a quick update that the configs for trigger, lgtm and approve plugin are missing if you want to get merge automation fully working. tide looks good already, that should work.

[lerrigatto]

@lerrigatto not sure whether you are still working on this - however I thought I'd give you a quick update that the configs for trigger, lgtm and approve plugin are missing if you want to get merge automation fully working. tide looks good already, that should work.

I will need some extra help then.
I checked the PR linked from the docs (#653) but it's 4y old and it seems that a big refactoring happened. I am not familiar with prow (yet, I guess :) ) and I tough that was enough.
If you can provide me with a more recent example or point me to the confs, I'll edit them here and open a docs pr too.

[dhiller]

@lerrigatto not sure whether you are still working on this - however I thought I'd give you a quick update that the configs for trigger, lgtm and approve plugin are missing if you want to get merge automation fully working. tide looks good already, that should work.

I will need some extra help then. I checked the PR linked from the docs (#653) but it's 4y old and it seems that a big refactoring happened. I am not familiar with prow (yet, I guess :) ) and I tough that was enough. If you can provide me with a more recent example or point me to the confs, I'll edit them here and open a docs pr too.

Our https://github.com/kubevirt/project-infra repository contains (besides other things) the setup for Prow, the central application within our CI environment. The configurations and deployments are applied to the prow-control-plane cluster after any change to them got merged.

The KubeVirt Prow instance is located at https://prow.ci.kubevirt.io - it's configuration can be found in https://github.com/kubevirt/project-infra/tree/main/github/ci/prow-deploy .

Prow consists of core components and plugins. For the merge automation to work for your repository you need to:

• configure tide (a component) for your repository, so that it looks at PRs and merges them
• configure trigger plugin for your repository, so that presubmits (basically jobs that run on the state of your PR) are executed automatically
• configure lgtm plugin for your repository, so that if org member review and approve your PR, an lgtm label is added (required for tide)
• configure approve plugin for your repository, so that users from the OWNERS file in your repository listed as approvers can approve the PR commenting /approve, in which case the approved label will be added and it will eventually get merged by tide
• and finally enable the plugins for your repository

Configuration locations

Target	Location
tide	project-infra/github/ci/prow-deploy/kustom/base/configs/current/config/config.yaml Line 86 in 0351d97 tide:
trigger	project-infra/github/ci/prow-deploy/kustom/base/configs/current/plugins/plugins.yaml Line 587 in 0351d97 triggers:
lgtm	project-infra/github/ci/prow-deploy/kustom/base/configs/current/plugins/plugins.yaml Line 711 in 0351d97 lgtm:
approve	project-infra/github/ci/prow-deploy/kustom/base/configs/current/plugins/plugins.yaml Line 646 in 0351d97 approve:
enable plugins	project-infra/github/ci/prow-deploy/kustom/base/configs/current/plugins/plugins.yaml Line 25 in 0351d97 plugins:

For specific configuration options you can either look at the plugin docs or at the prow source code for configurations

Note

Expand the section Snippet to see the config details

Hope that helps a bit. Ping me for any other questions you have.

And BTW I agree that the merge automation section could need an overhaul, I'd be happy to help on a PR to get that done 😄

[lerrigatto]

Thanks @dhiller.
Let me know if now we're good. I will open a PR on the docs with some proposal (I think just incorporating your message above will be great).

I noticed that I had to add the release plugin or prow was failing.

[dhiller]

I noticed that I had to add the release plugin or prow was failing.

Yeah, that's because there's two groups for tide. The second group (which you added the charts repo to) requires do-not-merge/release-note-label-needed to not be present .

If you put it into the first group it should work without release-note plugin enabled.

We can add it later if you need it but for now it should be good enough without it.

[dhiller]

^^ @lerrigatto

[dhiller]

Nearly there :)

[dhiller]

/approve

Thank you @lerrigatto ! 🎉

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dhiller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lerrigatto]

/test pull-kubevirt-org-github-config-updater

[kubevirt-bot]

@lerrigatto: Updated the following 2 configmaps:

• config configmap in namespace kubevirt-prow at cluster default using the following files:
  • key config.yaml using file github/ci/prow-deploy/kustom/base/configs/current/config/config.yaml
• plugins configmap in namespace kubevirt-prow at cluster default using the following files:
  • key plugins.yaml using file github/ci/prow-deploy/kustom/base/configs/current/plugins/plugins.yaml

Details

In response to this:

What this PR does / why we need it:

This PR creates a repo for help charts, as discussed here: kubevirt/community#224

Special notes for your reviewer: That's my first PR here!

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

• Design: A design document was considered and is present (link) or not required: Add Helm charts proposal community#224
• PR: The PR description is expressive enough and will help future contributors
• Code: Write code that humans can understand and Keep it simple
• Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
• Upgrade: Impact of this change on upgrade flows was considered and addressed if required
• Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
• Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
• Community: Announcement to kubevirt-dev was considered

Release note:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.