Skip to content

Conversation

@lerrigatto
Copy link
Member

What this PR does / why we need it:

We need (preliminary) maintainers for the charts repo.
My plan is to add the bare minimum to the repo (readme, codeowners) and start opening issues to discuss the implementation of the charts design doc: kubevirt/community#224
And, obviously, to write the charts :)

The charts repo have been created recently: #4093

I have added a new group for charts maintainers, I added @dhiller and myself but it doesn't need to be. Please let me know who should be in that list instead.
I added the repo to the release team, as for sure it's going to be related to them.

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 26, 2025
Signed-off-by: Enrico La Cava <enrico.lacava@flex.ai>
@lerrigatto lerrigatto force-pushed the add_charts_maintainers branch from bfbf4aa to 134ae31 Compare May 26, 2025 18:58
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels May 26, 2025
@lerrigatto lerrigatto marked this pull request as ready for review May 26, 2025 18:59
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2025
@kubevirt-bot kubevirt-bot requested a review from xpivarc May 26, 2025 18:59
@lerrigatto
Copy link
Member Author

@dhiller

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lerrigatto - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lerrigatto
Copy link
Member Author

lerrigatto commented May 26, 2025

CC @atanasdinov you spent a lot of time writing the design doc, do you want to open the VEP and track the work on the charts? https://github.com/kubevirt/enhancements/issues
Also should I add you to the repo maintainers?

@atanasdinov
Copy link

CC @atanasdinov you spent a lot of time writing the design doc, do you want to open the VEP and track the work on the charts? https://github.com/kubevirt/enhancements/issues Also should I add you to the repo maintainers?

Yes, I'll do it. As mentioned offline, I've been really busy over the last couple of weeks but I'll find a slot to go through the VEP process and create an initial draft of the chart that we can start reviewing and polishing.

Thanks for starting this!

@lerrigatto
Copy link
Member Author

{"component":"peribolos","level":"fatal","msg":"Configuration failed: failed to configure kubevirt team charts-maintainers repos: failed to list team 0(charts-maintainers) repos: return code not 2XX: 404 Not Found","severity":"fatal","time":"2025-05-26T19:47:32Z"}

And that isn't how you add teams :D
I will try to rtfm and fix this next week.

Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lerrigatto thanks - one change request inline, other than that it looks great!

Note that at some point we should add an OWNERS file to the charts repo.

Co-authored-by: Daniel Hiller <daniel.hiller.1972@googlemail.com>
Signed-off-by: Enrico La Cava <enrico.lacava@gmail.com>
@lerrigatto lerrigatto requested a review from dhiller May 27, 2025 14:24
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thank you @lerrigatto !

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2025
@dhiller
Copy link
Contributor

dhiller commented May 27, 2025

/override pull-kubevirt-org-github-config-updater

As the team doesn't exist this is an expected failure.

@kubevirt-bot
Copy link
Contributor

@dhiller: Overrode contexts on behalf of dhiller: pull-kubevirt-org-github-config-updater

Details

In response to this:

/override pull-kubevirt-org-github-config-updater

As the team doesn't exist this is an expected failure.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot merged commit f8c7988 into kubevirt:main May 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants