-
Notifications
You must be signed in to change notification settings - Fork 173
add maintainers for charts #4183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add maintainers for charts #4183
Conversation
|
Skipping CI for Draft Pull Request. |
Signed-off-by: Enrico La Cava <enrico.lacava@flex.ai>
bfbf4aa to
134ae31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lerrigatto - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
CC @atanasdinov you spent a lot of time writing the design doc, do you want to open the VEP and track the work on the charts? https://github.com/kubevirt/enhancements/issues |
Yes, I'll do it. As mentioned offline, I've been really busy over the last couple of weeks but I'll find a slot to go through the VEP process and create an initial draft of the chart that we can start reviewing and polishing. Thanks for starting this! |
And that isn't how you add teams :D |
dhiller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lerrigatto thanks - one change request inline, other than that it looks great!
Note that at some point we should add an OWNERS file to the charts repo.
github/ci/prow-deploy/kustom/base/configs/current/orgs/orgs.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Hiller <daniel.hiller.1972@googlemail.com> Signed-off-by: Enrico La Cava <enrico.lacava@gmail.com>
dhiller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thank you @lerrigatto !
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhiller The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override pull-kubevirt-org-github-config-updater As the team doesn't exist this is an expected failure. |
|
@dhiller: Overrode contexts on behalf of dhiller: pull-kubevirt-org-github-config-updater DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
We need (preliminary) maintainers for the charts repo.
My plan is to add the bare minimum to the repo (readme, codeowners) and start opening issues to discuss the implementation of the charts design doc: kubevirt/community#224
And, obviously, to write the charts :)
The charts repo have been created recently: #4093
I have added a new group for charts maintainers, I added @dhiller and myself but it doesn't need to be. Please let me know who should be in that list instead.
I added the repo to the release team, as for sure it's going to be related to them.
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.