Skip to content

Adds lerrigatto as member#4177

Merged
kubevirt-bot merged 1 commit intokubevirt:mainfrom
lerrigatto:add_lerrigatto_membership
May 22, 2025
Merged

Adds lerrigatto as member#4177
kubevirt-bot merged 1 commit intokubevirt:mainfrom
lerrigatto:add_lerrigatto_membership

Conversation

@lerrigatto
Copy link
Member

@lerrigatto lerrigatto commented May 20, 2025

GitHub Username

@lerrigatto

Requirements

Sponsors

List of contributions to the KubeVirt project

  • PRs reviewed and/or authored

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels May 20, 2025
@kubevirt-bot
Copy link
Contributor

Hi @lerrigatto. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Enrico La Cava <enrico.lacava@gmail.com>
@lerrigatto lerrigatto force-pushed the add_lerrigatto_membership branch from 7968f07 to bb34ac3 Compare May 20, 2025 19:43
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels May 20, 2025
@dhiller
Copy link
Contributor

dhiller commented May 21, 2025

/approve

@lerrigatto welcome to the KubeVirt community!

/cc @fossedihelm

@kubevirt-bot kubevirt-bot requested a review from fossedihelm May 21, 2025 14:47
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2025
@fossedihelm
Copy link
Contributor

/lgtm
Welcome

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2025
@lerrigatto lerrigatto marked this pull request as ready for review May 21, 2025 16:54
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2025
@kubevirt-bot kubevirt-bot requested a review from xpivarc May 21, 2025 16:54
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lerrigatto - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@dhiller
Copy link
Contributor

dhiller commented May 22, 2025

/retest-required

@kubevirt-bot kubevirt-bot merged commit a578247 into kubevirt:main May 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants