Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest GLFW #6587

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update to latest GLFW #6587

wants to merge 5 commits into from

Conversation

errissa
Copy link
Collaborator

@errissa errissa commented Jan 9, 2024

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Updates Open3D to use the latest GLFW as the version we had been using is several years old and predates Mac API changes. Also, updated to build system to build GLFW as external project to make it consistent with the rest of Open3D's use of third party libraries.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

@errissa errissa requested a review from ssheorey January 9, 2024 23:32
Copy link

update-docs bot commented Jan 9, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey
Copy link
Member

Looks good. We can merge after testing. Thanks!

@ssheorey
Copy link
Member

Possibly fixes #1673

@errissa errissa marked this pull request as ready for review January 30, 2024 15:57
@ssheorey
Copy link
Member

Test draw example and O3DVisualizer. Also test legacy visualizer.

@ssheorey
Copy link
Member

ssheorey commented Feb 9, 2024

Hi @errissa can you check the error in the documentation CI? Also, do all examples run for you? I got a crash in one draw.py example on Intel macOS.

@ssheorey
Copy link
Member

Works for me on intel Mac now.

@ssheorey
Copy link
Member

ssheorey commented Mar 5, 2024

Everything works, except double clicking on a file in macOS does not open the file with Open3D. Need to check how macOS is passing the file name to glfw.

@ssheorey ssheorey mentioned this pull request Apr 28, 2024
10 tasks
@ssheorey ssheorey added this to the v0.19 milestone Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants