Skip to content

fix: submit channel refactors #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

fix: submit channel refactors #94

wants to merge 7 commits into from

Conversation

dylanlott
Copy link
Contributor

@dylanlott dylanlott commented May 22, 2025 •
edited
Loading

fix: submit channel refactors

This PR includes several fixes and refactors to the channel submission logic.

  • Handle 403 errors with Skips instead of erroring
  • Adds retry_count increments to some code paths that weren't previously ticking the count
  • Adds per-slot limiting to the block building loop so that the retry function doesn't simply get called again after 3 attempts
  • Explicitly logs the call results of the blob transaction to aid with debugging
  • Adds gas bumping logic to the submit task to facilitate transaction replacement

Additionally, there are some configuration changes that needed to be made.

  • Additional broadcast hosts was just pointing back at the host RPC, which was adding noise to the logs and interfering with nonce debugging. This PR makes it optional and un-sets the duplicate host-rpc URL.
  • Slot offset and start timestamp were incorrectly configured and have been updated to their correct values

See: Builder Retry Logic

@dylanlott Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dylanlott dylanlott changed the title fix: remove arc and clones fix: submit channel refactors May 22, 2025
@dylanlott dylanlott changed the base branch from main to prestwich/env-cache-integration May 23, 2025 02:57
@dylanlott dylanlott force-pushed the dylan/submit-channel-refactors branch from 9a88965 to 8a1e80b Compare May 23, 2025 04:05
@dylanlott dylanlott changed the base branch from prestwich/env-cache-integration to main May 23, 2025 04:06
@dylanlott dylanlott changed the base branch from main to prestwich/env-cache-integration May 23, 2025 04:06
@dylanlott dylanlott changed the base branch from prestwich/env-cache-integration to main May 23, 2025 04:07
@dylanlott dylanlott force-pushed the dylan/submit-channel-refactors branch from 8a1e80b to 0498aae Compare May 23, 2025 17:02
@dylanlott dylanlott changed the base branch from main to prestwich/env-cache-integration May 23, 2025 17:03
dylanlott
dylanlott commented May 23, 2025
View reviewed changes
Cargo.toml
Comment on lines +30 to +40
# signet-constants = { path = "../signet-sdk/crates/constants" }
# signet-sim = { path = "../signet-sdk/crates/sim" }
# signet-tx-cache = { path = "../signet-sdk/crates/tx-cache" }
# signet-types = { path = "../signet-sdk/crates/types" }
# signet-zenith = { path = "../signet-sdk/crates/zenith" }

signet-constants = { git = "https://github.com/init4tech/signet-sdk", branch = "dylan/block-number" }
signet-sim = { git = "https://github.com/init4tech/signet-sdk", branch = "dylan/block-number" }
signet-tx-cache = { git = "https://github.com/init4tech/signet-sdk", branch = "dylan/block-number" }
signet-types = { git = "https://github.com/init4tech/signet-sdk", branch = "dylan/block-number" }
signet-zenith = { git = "https://github.com/init4tech/signet-sdk", branch = "dylan/block-number" }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be set back to main after PR is merged.

@prestwich prestwich force-pushed the prestwich/env-cache-integration branch from a239bcb to 2fd44a7 Compare May 23, 2025 18:02
@dylanlott dylanlott force-pushed the dylan/submit-channel-refactors branch from 0498aae to 16729a8 Compare May 23, 2025 19:36
@dylanlott dylanlott force-pushed the dylan/submit-channel-refactors branch from 444d0f3 to f762131 Compare May 23, 2025 21:38
@dylanlott dylanlott changed the base branch from prestwich/env-cache-integration to main May 23, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evalir Evalir Awaiting requested review from Evalir Evalir will be requested when the pull request is marked ready for review Evalir is a code owner

@prestwich prestwich Awaiting requested review from prestwich prestwich will be requested when the pull request is marked ready for review prestwich is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dylanlott