fix: submit channel refactors (#94)

# fix: submit channel refactors

This PR includes several fixes and refactors to the channel submission logic. 

- Handle 403 errors with `Skip`s instead of erroring
- Adds `retry_count` increments to some code paths that weren't previously ticking the count
- Adds per-slot limiting to the block building loop so that the retry function doesn't simply get called again after 3 attempts
- Explicitly logs the `call` results of the blob transaction to aid with debugging
- Adds gas bumping logic to the submit task to facilitate transaction replacement

Additionally, there are some configuration changes that needed to be made.

- Additional broadcast hosts was just pointing back at the host RPC, which was adding noise to the logs and interfering with nonce debugging. This PR makes it optional and un-sets the duplicate host-rpc URL.
- Slot offset and start timestamp were incorrectly configured and have been updated to their correct values

Closes ENG-1079

See: [Builder Retry Logic](https://www.notion.so/init4tech/Builder-Retry-Logic-1f43e1cd45398092a1b3fb692dd37787?pvs=4)

Author: dylanlott

Cargo.toml

@@ -27,11 +27,11 @@ integration = []
 [dependencies]
 init4-bin-base = { version = "0.4.1", features = ["perms"] }
 
-signet-constants = { git = "https://github.com/init4tech/signet-sdk", rev = "bd183b627dcb0eb682da801093b13f1f8311446b" }
-signet-sim = { git = "https://github.com/init4tech/signet-sdk", rev = "bd183b627dcb0eb682da801093b13f1f8311446b" }
-signet-tx-cache = { git = "https://github.com/init4tech/signet-sdk", rev = "bd183b627dcb0eb682da801093b13f1f8311446b" }
-signet-types = { git = "https://github.com/init4tech/signet-sdk", rev = "bd183b627dcb0eb682da801093b13f1f8311446b" }
-signet-zenith = { git = "https://github.com/init4tech/signet-sdk", rev = "bd183b627dcb0eb682da801093b13f1f8311446b" }
+signet-constants = { git = "https://github.com/init4tech/signet-sdk", rev = "ba5894f6fac35299d495ae115cd465a1f0791637" }
+signet-sim = { git = "https://github.com/init4tech/signet-sdk", rev = "ba5894f6fac35299d495ae115cd465a1f0791637" }
+signet-tx-cache = { git = "https://github.com/init4tech/signet-sdk", rev = "ba5894f6fac35299d495ae115cd465a1f0791637" }
+signet-types = { git = "https://github.com/init4tech/signet-sdk", rev = "ba5894f6fac35299d495ae115cd465a1f0791637" }
+signet-zenith = { git = "https://github.com/init4tech/signet-sdk", rev = "ba5894f6fac35299d495ae115cd465a1f0791637" }
 
 trevm = { version = "0.23.4", features = ["concurrent-db", "test-utils"] }
 

bin/submit_transaction.rs

@@ -11,7 +11,7 @@ use builder::config::HostProvider;
 use init4_bin_base::{
     deps::{
         metrics::{counter, histogram},
-        tracing,
+        tracing::{debug, error},
     },
     init4,
     utils::{from_env::FromEnv, signer::LocalOrAwsConfig},
@@ -52,16 +52,17 @@ async fn main() {
     let _guard = init4();
 
     let config = Config::from_env().unwrap();
-    tracing::trace!("connecting to provider");
+    debug!(?config.recipient_address, "connecting to provider");
+
     let provider = config.provider().await;
     let recipient_address = config.recipient_address;
     let sleep_time = config.sleep_time;
 
     loop {
-        tracing::debug!("attempting transaction");
+        debug!(?recipient_address, "attempting transaction");
         send_transaction(&provider, recipient_address).await;
 
-        tracing::debug!(sleep_time, "sleeping");
+        debug!(sleep_time, "sleeping");
         tokio::time::sleep(tokio::time::Duration::from_secs(sleep_time)).await;
     }
 }
@@ -78,18 +79,17 @@ async fn send_transaction(provider: &HostProvider, recipient_address: Address) {
     let dispatch_start_time: Instant = Instant::now();
 
     // dispatch the transaction
-    tracing::debug!("dispatching transaction");
     let result = provider.send_transaction(tx).await.unwrap();
 
     // wait for the transaction to mine
     let receipt = match timeout(Duration::from_secs(240), result.get_receipt()).await {
         Ok(Ok(receipt)) => receipt,
         Ok(Err(e)) => {
-            tracing::error!(error = ?e, "failed to get transaction receipt");
+            error!(error = ?e, "failed to get transaction receipt");
             return;
         }
         Err(_) => {
-            tracing::error!("timeout waiting for transaction receipt");
+            error!("timeout waiting for transaction receipt");
             counter!("txn_submitter.tx_timeout").increment(1);
             return;
         }
@@ -99,6 +99,6 @@ async fn send_transaction(provider: &HostProvider, recipient_address: Address) {
 
     // record metrics for how long it took to mine the transaction
     let mine_time = dispatch_start_time.elapsed().as_secs();
-    tracing::debug!(success = receipt.status(), mine_time, hash, "transaction mined");
+    debug!(success = receipt.status(), mine_time, hash, "transaction mined");
     histogram!("txn_submitter.tx_mine_time").record(mine_time as f64);
 }

src/config.rs

@@ -72,8 +72,9 @@ pub struct BuilderConfig {
     /// NOTE: should not include the host_rpc_url value
     #[from_env(
         var = "TX_BROADCAST_URLS",
-        desc = "Additional RPC URLs to which to broadcast transactions",
-        infallible
+        desc = "Additional RPC URLs to which the builder broadcasts transactions",
+        infallible,
+        optional
     )]
     pub tx_broadcast_urls: Vec<Cow<'static, str>>,
     /// address of the Zenith contract on Host.

src/tasks/block/sim.rs

@@ -94,10 +94,10 @@ impl Simulator {
             self.config.rollup_block_gas_limit,
         );
 
-        let block = block_build.build().await;
-        debug!(block = ?block, "finished block simulation");
+        let built_block = block_build.build().await;
+        debug!(block_number = ?built_block.block_number(), "finished building block");
 
-        Ok(block)
+        Ok(built_block)
     }
 
     /// Spawns the simulator task, which handles the setup and sets the deadline
@@ -155,8 +155,7 @@ impl Simulator {
 
             // If no env, skip this run
             let Some(block_env) = self.block_env.borrow_and_update().clone() else { return };
-
-            debug!(block_env = ?block_env, "building on block");
+            debug!(block_env = ?block_env, "building on block env");
 
             match self.handle_build(constants, sim_cache, finish_by, block_env).await {
                 Ok(block) => {