address review feedback

Author: dylanlott

Cargo.toml

@@ -28,13 +28,13 @@ integration = []
 init4-bin-base = { version = "0.3.4", features = ["perms"] }
 
 # TODO: Change sdk crate dependencies back to `main` after alloy / revm updates are merged
-signet-constants = { git = "https://github.com/init4tech/signet-sdk", branch = "dylan/block-number" }
-signet-sim = { git = "https://github.com/init4tech/signet-sdk", branch = "dylan/block-number" }
-signet-tx-cache = { git = "https://github.com/init4tech/signet-sdk", branch = "dylan/block-number" }
-signet-types = { git = "https://github.com/init4tech/signet-sdk", branch = "dylan/block-number" }
-signet-zenith = { git = "https://github.com/init4tech/signet-sdk", branch = "dylan/block-number" }
+signet-constants = { git = "https://github.com/dylanlott/signet-sdk", branch = "dylan/moar-logs" }
+signet-sim = { git = "https://github.com/dylanlott/signet-sdk", branch = "dylan/moar-logs" }
+signet-tx-cache = { git = "https://github.com/dylanlott/signet-sdk", branch = "dylan/moar-logs" }
+signet-types = { git = "https://github.com/dylanlott/signet-sdk", branch = "dylan/moar-logs" }
+signet-zenith = { git = "https://github.com/dylanlott/signet-sdk", branch = "dylan/moar-logs" }
 
-trevm = { version = "0.20.10", features = ["concurrent-db", "test-utils"] }
+trevm = { version = "0.20.12", features = ["concurrent-db", "test-utils"] }
 
 alloy = { version = "0.12.6", features = [
     "full",

bin/submit_transaction.rs

@@ -8,7 +8,7 @@ use builder::config::HostProvider;
 use init4_bin_base::{
     deps::{
         metrics::{counter, histogram},
-        tracing,
+        tracing::{debug, error},
     },
     init4,
     utils::{from_env::FromEnv, signer::LocalOrAwsConfig},
@@ -44,16 +44,17 @@ async fn main() {
     let _guard = init4();
 
     let config = Config::from_env().unwrap();
-    tracing::trace!("connecting to provider");
+    debug!(?config.recipient_address, "connecting to provider");
+
     let provider = config.provider().await;
     let recipient_address = config.recipient_address;
     let sleep_time = config.sleep_time;
 
     loop {
-        tracing::debug!("attempting transaction");
+        debug!(?recipient_address, "attempting transaction");
         send_transaction(&provider, recipient_address).await;
 
-        tracing::debug!(sleep_time, "sleeping");
+        debug!(sleep_time, "sleeping");
         tokio::time::sleep(tokio::time::Duration::from_secs(sleep_time)).await;
     }
 }
@@ -70,18 +71,17 @@ async fn send_transaction(provider: &HostProvider, recipient_address: Address) {
     let dispatch_start_time: Instant = Instant::now();
 
     // dispatch the transaction
-    tracing::debug!("dispatching transaction");
     let result = provider.send_transaction(tx).await.unwrap();
 
     // wait for the transaction to mine
     let receipt = match timeout(Duration::from_secs(240), result.get_receipt()).await {
         Ok(Ok(receipt)) => receipt,
         Ok(Err(e)) => {
-            tracing::error!(error = ?e, "failed to get transaction receipt");
+            error!(error = ?e, "failed to get transaction receipt");
             return;
         }
         Err(_) => {
-            tracing::error!("timeout waiting for transaction receipt");
+            error!("timeout waiting for transaction receipt");
             counter!("txn_submitter.tx_timeout").increment(1);
             return;
         }
@@ -91,6 +91,6 @@ async fn send_transaction(provider: &HostProvider, recipient_address: Address) {
 
     // record metrics for how long it took to mine the transaction
     let mine_time = dispatch_start_time.elapsed().as_secs();
-    tracing::debug!(success = receipt.status(), mine_time, hash, "transaction mined");
+    debug!(success = receipt.status(), mine_time, hash, "transaction mined");
     histogram!("txn_submitter.tx_mine_time").record(mine_time as f64);
 }

src/tasks/block/sim.rs

@@ -82,7 +82,7 @@ impl Simulator {
         block: BlockEnv,
     ) -> eyre::Result<BuiltBlock> {
         let db = self.create_db().await.unwrap();
-        
+
         let block_build: BlockBuild<_, NoOpInspector> = BlockBuild::new(
             db,
             constants,

src/tasks/submit.rs

@@ -21,7 +21,7 @@ use init4_bin_base::deps::{
 use signet_sim::BuiltBlock;
 use signet_types::{SignRequest, SignResponse};
 use signet_zenith::{
-    BundleHelper::{self, submitCall, BlockHeader, FillPermit2},
+    BundleHelper::{self, BlockHeader, FillPermit2, submitCall},
     Zenith::{self, IncorrectHostBlock},
 };
 use std::time::{Instant, UNIX_EPOCH};
@@ -32,7 +32,7 @@ pub const BASE_FEE_PER_GAS: u128 = 10 * GWEI_TO_WEI as u128;
 /// Base max priority fee per gas to use as a starting point for retry bumps
 pub const BASE_MAX_PRIORITY_FEE_PER_GAS: u128 = 2 * GWEI_TO_WEI as u128;
 /// Base maximum fee per blob gas to use as a starting point for retry bumps
-pub const BASE_MAX_FEE_PER_BLOB_GAS: u128 = 1 * GWEI_TO_WEI as u128;
+pub const BASE_MAX_FEE_PER_BLOB_GAS: u128 = GWEI_TO_WEI as u128;
 
 macro_rules! spawn_provider_send {
     ($provider:expr, $tx:expr) => {