Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-6723 AdaBoost API #15732

Merged
merged 9 commits into from
Sep 26, 2023
Merged

Conversation

valenad1
Copy link
Collaborator

@valenad1 valenad1 commented Sep 6, 2023

#6723

Implementation of AdaBoost algorithm - only API.

@valenad1 valenad1 force-pushed the valenad-6723-adaboost-api branch 2 times, most recently from 2b215ef to b0b7f07 Compare September 7, 2023 21:08
@valenad1 valenad1 force-pushed the valenad-6723-adaboost branch 3 times, most recently from 74dd6d1 to 6f024ec Compare September 8, 2023 14:24
@valenad1 valenad1 force-pushed the valenad-6723-adaboost-api branch 2 times, most recently from f03c3b9 to d58b1c3 Compare September 8, 2023 15:18
@valenad1 valenad1 force-pushed the valenad-6723-adaboost branch from 6f024ec to df188df Compare September 13, 2023 11:55
@valenad1 valenad1 force-pushed the valenad-6723-adaboost-api branch 3 times, most recently from 7e1e286 to 018c2c2 Compare September 15, 2023 17:35
@valenad1 valenad1 force-pushed the valenad-6723-adaboost branch 2 times, most recently from 79eaef1 to c08bef6 Compare September 18, 2023 16:57
@valenad1 valenad1 force-pushed the valenad-6723-adaboost-api branch 3 times, most recently from aea17c9 to 1fc5898 Compare September 19, 2023 14:31
@valenad1 valenad1 force-pushed the valenad-6723-adaboost branch from 18e679e to 719a356 Compare September 19, 2023 15:58
@valenad1 valenad1 force-pushed the valenad-6723-adaboost-api branch 2 times, most recently from 762445b to 80291c7 Compare September 19, 2023 16:35
@valenad1 valenad1 force-pushed the valenad-6723-adaboost-api branch from 80291c7 to cf8a50c Compare September 20, 2023 14:34
Copy link
Contributor

@maurever maurever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, just a few suggestions. Thanks @valenad1!

Copy link
Collaborator

@mn-mikke mn-mikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valenad1 valenad1 force-pushed the valenad-6723-adaboost-api branch 2 times, most recently from 7258fa9 to 3e669c4 Compare September 22, 2023 17:14
@valenad1 valenad1 force-pushed the valenad-6723-adaboost-api branch from 3e669c4 to 9018265 Compare September 26, 2023 14:57
@valenad1 valenad1 force-pushed the valenad-6723-adaboost branch from 44867f5 to aeaa11b Compare September 26, 2023 14:57
@valenad1 valenad1 merged commit 5b2b780 into valenad-6723-adaboost Sep 26, 2023
@valenad1 valenad1 deleted the valenad-6723-adaboost-api branch September 26, 2023 15:02
valenad1 added a commit that referenced this pull request Sep 26, 2023
* first version of Adaboost works similarly to scikit on prostate, airlines, and higgs

* add probabilities by Obtaining Calibrated Probabilities from Boosting paper

* add unit test to inner tasks

* use test files again in the large tests

* Improve basic training test to look into structure of weak learners

* add simple model summary

* implement possibility to have a custom weights column and ensure that the created weights column will always be the one we use

* add categorical test

* refactor learning rate to learn rate

* add documentation and validation to parameters

* add documentation to AdaBoost class

* add log

* add GLM as a learner

* add GBM as a weak learner

* refactor n_estimators to nlearners

* ensure that adaboost create exactly nlearners models

* GH-6723 AdaBoost API (#15732)

** implement AdaBoost API for python and R

** Expose weights column

** Refactor learning_rate to learn_rate

** Add GBM to the weak_learners

** Refactor n_estimators to nlearners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants