-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-6723 AdaBoost API #15732
Merged
Merged
GH-6723 AdaBoost API #15732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b215ef
to
b0b7f07
Compare
74dd6d1
to
6f024ec
Compare
f03c3b9
to
d58b1c3
Compare
6f024ec
to
df188df
Compare
7e1e286
to
018c2c2
Compare
79eaef1
to
c08bef6
Compare
aea17c9
to
1fc5898
Compare
18e679e
to
719a356
Compare
762445b
to
80291c7
Compare
80291c7
to
cf8a50c
Compare
maurever
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, just a few suggestions. Thanks @valenad1!
wendycwong
reviewed
Sep 21, 2023
wendycwong
approved these changes
Sep 21, 2023
mn-mikke
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7258fa9
to
3e669c4
Compare
3e669c4
to
9018265
Compare
44867f5
to
aeaa11b
Compare
valenad1
added a commit
that referenced
this pull request
Sep 26, 2023
* first version of Adaboost works similarly to scikit on prostate, airlines, and higgs * add probabilities by Obtaining Calibrated Probabilities from Boosting paper * add unit test to inner tasks * use test files again in the large tests * Improve basic training test to look into structure of weak learners * add simple model summary * implement possibility to have a custom weights column and ensure that the created weights column will always be the one we use * add categorical test * refactor learning rate to learn rate * add documentation and validation to parameters * add documentation to AdaBoost class * add log * add GLM as a learner * add GBM as a weak learner * refactor n_estimators to nlearners * ensure that adaboost create exactly nlearners models * GH-6723 AdaBoost API (#15732) ** implement AdaBoost API for python and R ** Expose weights column ** Refactor learning_rate to learn_rate ** Add GBM to the weak_learners ** Refactor n_estimators to nlearners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6723
Implementation of AdaBoost algorithm - only API.